New deutsch translations of remote translations interface have broke these specs where we were using English translations at specs to do the checks while the spec interface was in deutsch and now we have deutsch translations for the interface application is not returning english fallbacks anymore and a lot of specs of this file fails. This commits also changes the alternative language used at spec from deutsch to spanish which is maintaned by code not through Crowdin, so if any developer update current spanish translations for the user interface this specs will fail.
241 lines
8.2 KiB
Ruby
241 lines
8.2 KiB
Ruby
shared_examples "remotely_translatable" do |factory_name, path_name, path_arguments|
|
|
let(:arguments) do
|
|
path_arguments.map do |argument_name, path_to_value|
|
|
[argument_name, resource.send(path_to_value)]
|
|
end.to_h
|
|
end
|
|
let(:path) { send(path_name, arguments) }
|
|
let!(:resource) { create(factory_name) }
|
|
|
|
before do
|
|
Setting["feature.remote_translations"] = true
|
|
available_locales_response = %w[de en es fr pt zh-Hans]
|
|
expect(RemoteTranslations::Microsoft::AvailableLocales).to receive(:available_locales).at_most(3).times.
|
|
and_return(available_locales_response)
|
|
end
|
|
|
|
context "Button to request remote translation" do
|
|
scenario "should not be present when current locale translation exists", :js do
|
|
visit path
|
|
|
|
expect(page).not_to have_button("Translate page")
|
|
end
|
|
|
|
scenario "should be present when current locale translation does not exists", :js do
|
|
visit path
|
|
|
|
select("Español", from: "locale-switcher")
|
|
|
|
expect(page).to have_button("Traducir página")
|
|
end
|
|
|
|
scenario "should not be present when new current locale translation exists", :js do
|
|
add_translations(resource, :es)
|
|
visit path
|
|
expect(page).not_to have_button("Translate page")
|
|
|
|
select("Español", from: "locale-switcher")
|
|
|
|
expect(page).not_to have_button("Traducir página")
|
|
end
|
|
|
|
scenario "should not be present when there are no resources to translate", :js do
|
|
skip("only index_path") if show_path?(path_name)
|
|
resource.destroy!
|
|
visit path
|
|
|
|
select("Español", from: "locale-switcher")
|
|
|
|
expect(page).not_to have_button("Traducir página")
|
|
end
|
|
|
|
describe "with delayed job active", :delay_jobs do
|
|
scenario "should not be present when an equal RemoteTranslation is enqueued", :js do
|
|
create(:remote_translation, remote_translatable: resource, locale: :es)
|
|
visit path
|
|
|
|
select("Español", from: "locale-switcher")
|
|
|
|
expect(page).not_to have_button("Traducir página")
|
|
expect(page).to have_content("En un breve periodo de tiempo refrescando la página podrá ver todo el contenido en su idioma")
|
|
end
|
|
end
|
|
|
|
describe "should ignore missing translations on resource comments" do
|
|
before do
|
|
if show_path?(path_name) || !commentable?(resource)
|
|
skip("only index_path")
|
|
end
|
|
end
|
|
|
|
scenario "is not present when a resource translation exists but its comment has not tanslations", :js do
|
|
add_translations(resource, :es)
|
|
create(:comment, commentable: resource)
|
|
visit path
|
|
expect(page).not_to have_button("Translate page")
|
|
|
|
select("Español", from: "locale-switcher")
|
|
|
|
expect(page).not_to have_button("Traducir página")
|
|
end
|
|
end
|
|
|
|
describe "should evaluate missing translations on resource comments" do
|
|
before do
|
|
if index_path?(path_name)
|
|
skip("only show_path")
|
|
end
|
|
end
|
|
|
|
scenario "display when exists resource translations but the comment does not have a translation", :js do
|
|
add_translations(resource, :es)
|
|
create(:comment, commentable: resource)
|
|
visit path
|
|
expect(page).not_to have_button("Translate page")
|
|
|
|
select("Español", from: "locale-switcher")
|
|
|
|
expect(page).to have_button("Traducir página")
|
|
end
|
|
|
|
scenario "not display when exists resource translations but his comment has tanslations", :js do
|
|
add_translations(resource, :es)
|
|
create_comment_with_translations(resource, :es)
|
|
visit path
|
|
expect(page).not_to have_button("Translate page")
|
|
|
|
select("Español", from: "locale-switcher")
|
|
|
|
expect(page).not_to have_button("Traducir página")
|
|
end
|
|
end
|
|
|
|
describe "should evaluate missing translations on featured_debates" do
|
|
before { skip("only debates index path") if path_name != "debates_path" }
|
|
|
|
scenario "display when exists featured_debates without tanslations", :js do
|
|
add_translations(resource, :es)
|
|
create_featured_debates
|
|
visit path
|
|
expect(page).not_to have_button("Translate page")
|
|
|
|
select("Español", from: "locale-switcher")
|
|
|
|
expect(page).to have_button("Traducir página")
|
|
end
|
|
end
|
|
|
|
describe "should evaluate missing translations on featured_proposals" do
|
|
before { skip("only proposals index path") if path_name != "proposals_path" }
|
|
|
|
scenario "display when exists featured_proposals without tanslations", :js do
|
|
add_translations(resource, :es)
|
|
create_featured_proposals
|
|
visit path
|
|
expect(page).not_to have_button("Translate page")
|
|
|
|
select("Español", from: "locale-switcher")
|
|
|
|
expect(page).to have_button("Traducir página")
|
|
end
|
|
end
|
|
end
|
|
|
|
context "After click remote translations button" do
|
|
describe "with delayed jobs", :delay_jobs do
|
|
scenario "the remote translation button should not be present", :js do
|
|
visit path
|
|
select("Español", from: "locale-switcher")
|
|
|
|
click_button "Traducir página"
|
|
|
|
expect(page).not_to have_button("Traducir página")
|
|
end
|
|
|
|
scenario "the remote translation is pending to translate", :js do
|
|
visit path
|
|
select("Español", from: "locale-switcher")
|
|
|
|
expect { click_button "Traducir página" }.to change { RemoteTranslation.count }.from(0).to(1)
|
|
end
|
|
|
|
scenario "should be present enqueued notice and informative text", :js do
|
|
visit path
|
|
select("Español", from: "locale-switcher")
|
|
|
|
click_button "Traducir página"
|
|
|
|
expect(page).to have_content("Se han solicitado correctamente las traducciones.")
|
|
expect(page).to have_content("En un breve periodo de tiempo refrescando la página podrá ver todo el contenido en su idioma")
|
|
end
|
|
|
|
scenario "should be present only informative text when user visit page with all content enqueued", :js do
|
|
visit path
|
|
select("Español", from: "locale-switcher")
|
|
click_button "Traducir página"
|
|
expect(page).to have_content("Se han solicitado correctamente las traducciones.")
|
|
|
|
visit path
|
|
select("Español", from: "locale-switcher")
|
|
|
|
expect(page).not_to have_button "Traducir página"
|
|
expect(page).not_to have_content("Se han solicitado correctamente las traducciones.")
|
|
expect(page).to have_content("En un breve periodo de tiempo refrescando la página podrá ver todo el contenido en su idioma")
|
|
end
|
|
end
|
|
|
|
describe "without delayed jobs" do
|
|
scenario "the remote translation button should not be present", :js do
|
|
microsoft_translate_client_response = generate_response(resource)
|
|
expect_any_instance_of(RemoteTranslations::Microsoft::Client).to receive(:call).and_return(microsoft_translate_client_response)
|
|
visit path
|
|
select("Español", from: "locale-switcher")
|
|
|
|
click_button "Traducir página"
|
|
|
|
expect(page).not_to have_button("Traducir página")
|
|
end
|
|
|
|
scenario "the remote translation has been translated and destoyed", :js do
|
|
microsoft_translate_client_response = generate_response(resource)
|
|
expect_any_instance_of(RemoteTranslations::Microsoft::Client).to receive(:call).and_return(microsoft_translate_client_response)
|
|
visit path
|
|
select("Español", from: "locale-switcher")
|
|
|
|
click_button "Traducir página"
|
|
|
|
expect(RemoteTranslation.count).to eq(0)
|
|
expect(resource.translations.count).to eq(2)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
def add_translations(resource, locale)
|
|
new_translation = resource.translations.first.dup
|
|
new_translation.update!(locale: locale)
|
|
resource
|
|
end
|
|
|
|
def create_comment_with_translations(resource, locale)
|
|
comment = create(:comment, commentable: resource)
|
|
add_translations(comment, locale)
|
|
end
|
|
|
|
def index_path?(path)
|
|
["debates_path", "proposals_path", "root_path", "budget_investments_path"].include?(path)
|
|
end
|
|
|
|
def show_path?(path)
|
|
!index_path?(path)
|
|
end
|
|
|
|
def commentable?(resource)
|
|
Comment::COMMENTABLE_TYPES.include?(resource.class.to_s)
|
|
end
|
|
|
|
def generate_response(resource)
|
|
field_text = Faker::Lorem.characters(10)
|
|
resource.translated_attribute_names.map { field_text }
|
|
end
|