db97f9d08c
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
61 lines
1.9 KiB
Ruby
61 lines
1.9 KiB
Ruby
require "rails_helper"
|
|
|
|
# Specs in this file have access to a helper object that includes
|
|
# the CommentsHelper. For example:
|
|
#
|
|
# describe CommentsHelper do
|
|
# describe "string concat" do
|
|
# it "concats two strings with spaces" do
|
|
# expect(helper.concat_strings("this","that")).to eq("this that")
|
|
# end
|
|
# end
|
|
# end
|
|
RSpec.describe CommentsHelper, type: :helper do
|
|
describe "#user_level_class" do
|
|
def comment_double(as_administrator: false, as_moderator: false, official: false)
|
|
user = instance_double("User", official?: official, official_level: "Y")
|
|
instance_double("Comment", as_administrator?: as_administrator, as_moderator?: as_moderator, user: user)
|
|
end
|
|
|
|
it "returns is-admin for comment done as administrator" do
|
|
comment = comment_double(as_administrator: true)
|
|
|
|
expect(helper.user_level_class(comment)).to eq("is-admin")
|
|
end
|
|
|
|
it "returns is-moderator for comment done as moderator" do
|
|
comment = comment_double(as_moderator: true)
|
|
|
|
expect(helper.user_level_class(comment)).to eq("is-moderator")
|
|
end
|
|
|
|
it "returns level followed by official level if user is official" do
|
|
comment = comment_double(official: true)
|
|
|
|
expect(helper.user_level_class(comment)).to eq("level-Y")
|
|
end
|
|
|
|
it "returns an empty class otherwise" do
|
|
comment = comment_double
|
|
|
|
expect(helper.user_level_class(comment)).to eq("")
|
|
end
|
|
end
|
|
|
|
describe "#comment_author_class" do
|
|
it "returns is-author if author is the commenting user" do
|
|
author_id = 42
|
|
comment = instance_double("Comment", user_id: author_id)
|
|
|
|
expect(helper.comment_author_class(comment, author_id)).to eq("is-author")
|
|
end
|
|
|
|
it "returns an empty string if commenter is not the author" do
|
|
author_id = 42
|
|
comment = instance_double("Comment", user_id: author_id - 1)
|
|
|
|
expect(helper.comment_author_class(comment, author_id)).to eq("")
|
|
end
|
|
end
|
|
end
|