51a0bce58c
Both the calculate winners and delete actions benefit from some kind of hint. The "calculate winners" hint informs administrators that results won't be publicly available unless the "show results" option is enabled. The delete action was redirecting with an error message when the budget couldn't be deleted; IMHO it's better to disable it and inform administrators why it's disabled. Alternatively we could remove the button completely; however, users might be looking for a way to delete a budget and wouldn't find any hint about it. We're now removing the "Delete" action from the budgets index table, since most of the time it isn't possible to delete a budget and so the action takes up space and we get little gain in return. We could keep the "Delete" icon just for budgets which can be deleted; however, the alignment of the table rows would suffer, making it harder to find the intended action.
29 lines
625 B
Ruby
29 lines
625 B
Ruby
class Admin::Budgets::TableActionsComponent < ApplicationComponent
|
|
attr_reader :budget
|
|
|
|
def initialize(budget)
|
|
@budget = budget
|
|
end
|
|
|
|
private
|
|
|
|
def create_budget_poll_path
|
|
balloting_phase = budget.phases.find_by(kind: "balloting")
|
|
|
|
admin_polls_path(poll: {
|
|
name: budget.name,
|
|
budget_id: budget.id,
|
|
starts_at: balloting_phase.starts_at,
|
|
ends_at: balloting_phase.ends_at
|
|
})
|
|
end
|
|
|
|
def actions_component
|
|
Admin::TableActionsComponent.new(
|
|
budget,
|
|
edit_path: admin_budget_path(budget),
|
|
actions: [:edit]
|
|
)
|
|
end
|
|
end
|