We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
44 lines
1.4 KiB
Ruby
44 lines
1.4 KiB
Ruby
require "rails_helper"
|
|
|
|
describe Administrator do
|
|
describe "#description_or_name" do
|
|
let!(:user) { create(:user, username: "Billy Wilder") }
|
|
|
|
it "returns description if present" do
|
|
administrator = create(:administrator, user: user, description: "John Doe")
|
|
|
|
expect(administrator.description_or_name).to eq("John Doe")
|
|
end
|
|
|
|
it "returns name if description is nil" do
|
|
administrator = create(:administrator, user: user)
|
|
|
|
expect(administrator.description_or_name).to eq("Billy Wilder")
|
|
end
|
|
|
|
it "returns name if description is blank" do
|
|
administrator = create(:administrator, description: "")
|
|
|
|
expect(administrator.description_or_name).to eq(administrator.name)
|
|
end
|
|
end
|
|
|
|
describe "#description_or_name_and_email" do
|
|
let!(:user) { create(:user, username: "Billy Wilder", email: "test@test.com") }
|
|
|
|
it "returns description and email if decription present" do
|
|
administrator = create(:administrator,
|
|
description: "John Doe",
|
|
user: user)
|
|
|
|
expect(administrator.description_or_name_and_email).to eq("John Doe (test@test.com)")
|
|
end
|
|
|
|
it "returns name and email if description is not present" do
|
|
administrator = create(:administrator, user: user)
|
|
|
|
expect(administrator.description_or_name_and_email).to eq("Billy Wilder (test@test.com)")
|
|
end
|
|
end
|
|
end
|