2b962f2789
Many pages had this tag, but many other didn't, which made navigation inconsistent for people using screen readers. Note that there are slight changes in two pages: * The homepage now includes the banner and the content of the `shared/header` element inside the <main> tag * The budgets index now includes the banner inside the <main> tag I see both potential advantages and disadvantages of this approach, since banners aren't necessarily related to the main content of a page but on the other hand they aren't the same across pages and people using screen readers might accidentally skip them if they jump to the <main> tag. So I'm choosing the option that is easier to implement. Note we're adding a `public-content` class to the <main> element in the application layout. This might be redundat because the element could already be accessed through the `.public main` selector, but this is consistent with the `admin-content` class used in the admin section, and without it the <main> element would sometimes have an empty class attribute and we'd have to use `if content_for?(:main_class)` or `tag.main` which IMHO makes the code less consistent. The Capybara::DSL monkey-patch is only done on the `visit` method because it's the only reliable one. Other methods like `click_link` generate AJAX requests, so `expect(page).to have_css "main", count: 1` might be executed before the AJAX request is finished, meaning it wouldn't properly test anything.
85 lines
2.9 KiB
Plaintext
85 lines
2.9 KiB
Plaintext
<% provide :title do %><%= t("debates.index.title") %><% end %>
|
|
<% content_for :header_addon do %>
|
|
<%= render "shared/search_form",
|
|
search_path: debates_path(page: 1),
|
|
i18n_namespace: "debates.index.search_form" %>
|
|
<% end %>
|
|
<% content_for :canonical do %>
|
|
<%= render "shared/canonical", href: debates_url %>
|
|
<% end %>
|
|
|
|
<% if @search_terms || @advanced_search_terms %>
|
|
<%= render Shared::SearchResultsSummaryComponent.new(
|
|
results: @debates,
|
|
search_terms: @search_terms,
|
|
advanced_search_terms: @advanced_search_terms
|
|
) %>
|
|
<% else %>
|
|
<%= render "shared/section_header", i18n_namespace: "debates.index.section_header", image: "debates" %>
|
|
<% end %>
|
|
|
|
<% if feature?("user.recommendations") && @recommended_debates.present? %>
|
|
<%= render "shared/recommended_index", recommended: @recommended_debates,
|
|
disable_recommendations_path: recommendations_disable_debates_path,
|
|
namespace: "debates" %>
|
|
<% end %>
|
|
|
|
<div class="row">
|
|
<div id="debates" class="debates-list small-12 medium-9 column">
|
|
|
|
<%= render Shared::BannerComponent.new("debates") %>
|
|
|
|
<% unless @search_terms || !has_featured? %>
|
|
<%= render "featured_debates" %>
|
|
<% end %>
|
|
|
|
<div class="row">
|
|
<div class="small-12 column">
|
|
<%= render "view_mode" %>
|
|
</div>
|
|
</div>
|
|
|
|
<%= render Shared::AdvancedSearchComponent.new %>
|
|
|
|
<%= render "shared/order_links", i18n_namespace: "debates.index" %>
|
|
|
|
<div class="show-for-small-only">
|
|
<%= link_to t("debates.index.start_debate"), new_debate_path, class: "button expanded" %>
|
|
</div>
|
|
|
|
<% if @debates.any? || current_user.blank? %>
|
|
<% if debates_default_view? %>
|
|
<%= render @debates %>
|
|
<% else %>
|
|
<% @debates.each do |debate| %>
|
|
<%= render "debates/debate_minimal", debate: debate %>
|
|
<% end %>
|
|
<% end %>
|
|
<% else %>
|
|
<%= empty_recommended_debates_message_text(current_user) %>
|
|
<% end %>
|
|
<%= paginate @debates %>
|
|
|
|
<% unless @search_terms || @advanced_search_terms %>
|
|
<div id="section_help" class="margin" data-magellan-target="section_help">
|
|
<p class="lead">
|
|
<strong><%= t("debates.index.section_footer.title") %></strong>
|
|
</p>
|
|
<p><%= t("debates.index.section_footer.description") %></p>
|
|
<p><%= t("debates.index.section_footer.help_text_1") %></p>
|
|
<p><%= sanitize(t("debates.index.section_footer.help_text_2",
|
|
org: link_to(setting["org_name"], new_user_registration_path))) %></p>
|
|
</p>
|
|
</div>
|
|
<% end %>
|
|
</div>
|
|
|
|
<div class="small-12 medium-3 column">
|
|
|
|
<aside class="margin-bottom">
|
|
<%= link_to t("debates.index.start_debate"), new_debate_path, class: "button expanded" %>
|
|
<%= render "shared/tag_cloud", taggable: "Debate" %>
|
|
</aside>
|
|
</div>
|
|
</div>
|