2e6644d513
When we were visiting a page showing the content of a record which uses globalize and our locale was the default one and there was no translation for the default locale, the application was crashing in some places because there are no fallbacks for the default locale. For example, when visiting a legislation process, the line with `CGI.escape(title)` was crashing because `title` was `nil` for the default locale. We've decided to solve this issue by using any available translations as globalize fallbacks instead of showing a 404 error or a translation missing error because these solutions would (we thinkg) either require modifying many places in the application or making the translatable logic even more complex. Initially we tried to add this solution to an initializer, but it must be called after initializing the application so I18n.fallbacks[locale] gets the value defined in config.i18n.fallbacks. Also note the line: fallbacks[locale] = I18n.fallbacks[locale] + I18n.available_locales Doesn't mention `I18n.default_locale` because the method `I18n.fallbacks[locale]` automatically adds the default locale.
94 lines
2.7 KiB
Ruby
94 lines
2.7 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe AdminNotification do
|
|
let(:admin_notification) { build(:admin_notification) }
|
|
|
|
it_behaves_like "globalizable", :admin_notification
|
|
|
|
it "is valid" do
|
|
expect(admin_notification).to be_valid
|
|
end
|
|
|
|
it 'is not valid without a title' do
|
|
admin_notification.title = nil
|
|
expect(admin_notification).not_to be_valid
|
|
end
|
|
|
|
it 'is not valid without a body' do
|
|
admin_notification.body = nil
|
|
expect(admin_notification).not_to be_valid
|
|
end
|
|
|
|
it 'is not valid without a segment_recipient' do
|
|
admin_notification.segment_recipient = nil
|
|
expect(admin_notification).not_to be_valid
|
|
end
|
|
|
|
describe '#complete_link_url' do
|
|
it 'does not change link if there is no value' do
|
|
expect(admin_notification.link).to be_nil
|
|
end
|
|
|
|
it 'fixes a link without http://' do
|
|
admin_notification.link = 'lol.consul.dev'
|
|
|
|
expect(admin_notification).to be_valid
|
|
expect(admin_notification.link).to eq('http://lol.consul.dev')
|
|
end
|
|
|
|
it 'fixes a link with wwww. but without http://' do
|
|
admin_notification.link = 'www.lol.consul.dev'
|
|
|
|
expect(admin_notification).to be_valid
|
|
expect(admin_notification.link).to eq('http://www.lol.consul.dev')
|
|
end
|
|
|
|
it 'does not modify a link with http://' do
|
|
admin_notification.link = 'http://lol.consul.dev'
|
|
|
|
expect(admin_notification).to be_valid
|
|
expect(admin_notification.link).to eq('http://lol.consul.dev')
|
|
end
|
|
|
|
it 'does not modify a link with https://' do
|
|
admin_notification.link = 'https://lol.consul.dev'
|
|
|
|
expect(admin_notification).to be_valid
|
|
expect(admin_notification.link).to eq('https://lol.consul.dev')
|
|
end
|
|
|
|
it 'does not modify a link with http://wwww.' do
|
|
admin_notification.link = 'http://www.lol.consul.dev'
|
|
|
|
expect(admin_notification).to be_valid
|
|
expect(admin_notification.link).to eq('http://www.lol.consul.dev')
|
|
end
|
|
end
|
|
|
|
describe '#valid_segment_recipient?' do
|
|
it 'is false when segment_recipient value is invalid' do
|
|
admin_notification.update(segment_recipient: 'invalid_segment_name')
|
|
error = 'The user recipients segment is invalid'
|
|
|
|
expect(admin_notification).not_to be_valid
|
|
expect(admin_notification.errors.messages[:segment_recipient]).to include(error)
|
|
end
|
|
end
|
|
|
|
describe '#list_of_recipients' do
|
|
let(:erased_user) { create(:user, username: 'erased_user') }
|
|
|
|
before do
|
|
2.times { create(:user) }
|
|
erased_user.erase
|
|
admin_notification.update(segment_recipient: 'all_users')
|
|
end
|
|
|
|
it 'returns list of all active users' do
|
|
expect(admin_notification.list_of_recipients.count).to eq(2)
|
|
expect(admin_notification.list_of_recipients).not_to include(erased_user)
|
|
end
|
|
end
|
|
|
|
end
|