2b962f2789
Many pages had this tag, but many other didn't, which made navigation inconsistent for people using screen readers. Note that there are slight changes in two pages: * The homepage now includes the banner and the content of the `shared/header` element inside the <main> tag * The budgets index now includes the banner inside the <main> tag I see both potential advantages and disadvantages of this approach, since banners aren't necessarily related to the main content of a page but on the other hand they aren't the same across pages and people using screen readers might accidentally skip them if they jump to the <main> tag. So I'm choosing the option that is easier to implement. Note we're adding a `public-content` class to the <main> element in the application layout. This might be redundat because the element could already be accessed through the `.public main` selector, but this is consistent with the `admin-content` class used in the admin section, and without it the <main> element would sometimes have an empty class attribute and we'd have to use `if content_for?(:main_class)` or `tag.main` which IMHO makes the code less consistent. The Capybara::DSL monkey-patch is only done on the `visit` method because it's the only reliable one. Other methods like `click_link` generate AJAX requests, so `expect(page).to have_css "main", count: 1` might be executed before the AJAX request is finished, meaning it wouldn't properly test anything.
39 lines
1.2 KiB
Plaintext
39 lines
1.2 KiB
Plaintext
<!DOCTYPE html>
|
|
<html <%= common_html_attributes %>>
|
|
<head>
|
|
<%= render "layouts/common_head", default_title: setting["org_name"] %>
|
|
<%= render "layouts/meta_tags" %>
|
|
<%= raw setting["html.per_page_code_head"] %>
|
|
</head>
|
|
|
|
<body class="auth-page">
|
|
<%= raw setting["html.per_page_code_body"] %>
|
|
<div class="wrapper">
|
|
<div class="auth-image small-12 medium-3 column"
|
|
style="<%= attached_background_css asset_url(image_path_for("auth_bg.jpg")) %>">
|
|
<h1 class="logo margin">
|
|
<%= link_to root_path do %>
|
|
<%= image_tag(image_path_for("logo_header.png"), class: "float-left", alt: setting["org_name"]) %>
|
|
<% end %>
|
|
</h1>
|
|
</div>
|
|
|
|
<div class="small-12 medium-9 column">
|
|
<div class="row">
|
|
<div class="small-12 medium-9 large-7 small-centered column">
|
|
<main class="auth-form margin <%= yield(:main_class) %>">
|
|
<%= render "layouts/flash" %>
|
|
|
|
<%= yield %>
|
|
</main>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="footer">
|
|
<%= render Layout::FooterComponent.new %>
|
|
</div>
|
|
</body>
|
|
</html>
|