Files
nairobi/spec/system/admin/budget_headings_spec.rb
Julian Herrero 2b709f1a36 Groups and headings CRUD from budget view
Before, users needed to navigate to the list of groups in order to
add, edit or delete a group.

Also, they need to navigate to the list of groups first, and then to
the list of headings for that group in order to add, edit or delete a
heading.

Now, it's possible to do all these actions for any group or heading
from the participatory budget view to bring simplicity and to reduce
the number of clicks from a user perspective.

Co-Authored-By: Javi Martín <javim@elretirao.net>
2021-10-25 18:01:47 +02:00

251 lines
9.0 KiB
Ruby

require "rails_helper"
describe "Admin budget headings", :admin do
let(:budget) { create(:budget, :drafting) }
let!(:group) { create(:budget_group, budget: budget) }
context "Load" do
let!(:budget) { create(:budget, slug: "budget_slug") }
let!(:group) { create(:budget_group, slug: "group_slug", budget: budget) }
let!(:heading) { create(:budget_heading, slug: "heading_slug", group: group) }
scenario "finds budget, group and heading by slug" do
visit edit_admin_budget_group_heading_path("budget_slug", "group_slug", "heading_slug")
expect(page).to have_content(budget.name)
expect(page).to have_content(group.name)
expect(page).to have_field "Heading name", with: heading.name
end
end
context "List of headings in the budget page" do
scenario "Displaying no headings for group" do
visit admin_budget_path(budget)
within "section", text: "Groups and headings" do
expect(page).to have_content "There are no headings."
end
end
scenario "Displaying headings" do
create(:budget_heading, name: "Laptops", group: group, price: 1000, allow_custom_content: true)
create(:budget_heading, name: "Tablets", group: group, price: 2000, population: 10000)
create(:budget_heading, name: "Phones", group: group, price: 3000, population: 20000)
visit admin_budget_path(budget)
within "section", text: "Groups and headings" do
within "tbody" do
expect(page).to have_selector "tr", count: 3
within "tr", text: "Laptops" do
expect(page).to have_content "€1,000"
expect(page).not_to have_content "10000"
expect(page).to have_content "Yes"
end
within "tr", text: "Tablets" do
expect(page).to have_content "€2,000"
expect(page).to have_content "10000"
expect(page).to have_content "No"
end
within "tr", text: "Phones" do
expect(page).to have_content "€3,000"
expect(page).to have_content "20000"
expect(page).to have_content "No"
end
end
end
end
scenario "Delete a heading without investments" do
create(:budget_heading, group: group, name: "Lemuria")
visit admin_budget_path(budget)
within("tr", text: "Lemuria") { accept_confirm { click_button "Delete" } }
expect(page).to have_content "Heading deleted successfully"
expect(page).not_to have_content "Lemuria"
end
scenario "Try to delete a heading with investments" do
heading = create(:budget_heading, group: group, name: "Atlantis")
create(:budget_investment, heading: heading)
visit admin_budget_path(budget)
within(".heading", text: "Atlantis") { accept_confirm { click_button "Delete" } }
expect(page).to have_content "You cannot delete a Heading that has associated investments"
expect(page).to have_content "Atlantis"
end
end
context "New" do
scenario "Create heading" do
visit admin_budget_path(budget)
within "section", text: "Groups and headings" do
within("section", text: group.name) { click_link "Add heading" }
end
fill_in "Heading name", with: "All City"
fill_in "Money amount", with: "1000"
fill_in "Population (optional)", with: "10000"
check "Allow content block"
click_button "Create new heading"
expect(page).to have_content "Heading created successfully!"
within "tr", text: "All City" do
expect(page).to have_content "€1,000"
expect(page).to have_content "10000"
expect(page).to have_content "Yes"
end
end
scenario "Heading name is mandatory" do
visit new_admin_budget_group_heading_path(budget, group)
click_button "Create new heading"
expect(page).not_to have_content "Heading created successfully!"
expect(page).to have_css(".is-invalid-label", text: "Heading name")
expect(page).to have_content "can't be blank"
end
scenario "Heading amount is mandatory" do
visit new_admin_budget_group_heading_path(budget, group)
click_button "Create new heading"
expect(page).not_to have_content "Heading created successfully!"
expect(page).to have_css(".is-invalid-label", text: "Money amount")
expect(page).to have_content "can't be blank"
end
describe "Max votes is optional" do
scenario "do no show max_ballot_lines field for knapsack budgets" do
visit new_admin_budget_group_heading_path(budget, group)
expect(page).not_to have_field "Votes allowed"
end
scenario "create heading with max_ballot_lines for appoval budgets" do
budget.update!(voting_style: "approval")
visit new_admin_budget_group_heading_path(budget, group)
expect(page).to have_field "Votes allowed", with: 1
fill_in "Heading name", with: "All City"
fill_in "Money amount", with: "1000"
fill_in "Votes allowed", with: 14
click_button "Create new heading"
expect(page).to have_content "Heading created successfully!"
within("tr", text: "All City") { expect(page).to have_content 14 }
end
end
end
context "Edit" do
scenario "Show heading information" do
heading = create(:budget_heading, group: group)
visit admin_budget_path(budget)
within("#budget_heading_#{heading.id}") { click_link "Edit" }
expect(page).to have_field "Heading name", with: heading.name
expect(page).to have_field "Money amount", with: heading.price
expect(page).to have_field "Population (optional)", with: heading.population
expect(page).to have_field "Longitude (optional)", with: heading.longitude
expect(page).to have_field "Latitude (optional)", with: heading.latitude
expect(find_field("Allow content block")).not_to be_checked
end
scenario "Changing name for current locale will update the slug if budget is in draft phase" do
heading = create(:budget_heading, group: group, name: "Old English Name")
visit edit_admin_budget_group_heading_path(budget, group, heading)
select "Español", from: :add_language
fill_in "Heading name", with: "Spanish name"
click_button "Save heading"
expect(page).to have_content "Heading updated successfully"
visit budget_investments_path(budget, heading_id: "old-english-name")
expect(page).to have_content "Old English Name"
visit edit_admin_budget_group_heading_path(budget, group, heading)
select "English", from: :select_language
fill_in "Heading name", with: "New English Name"
click_button "Save heading"
expect(page).to have_content "Heading updated successfully"
visit budget_investments_path(budget, heading_id: "new-english-name")
expect(page).to have_content "New English Name"
end
end
context "Update" do
let(:heading) do
create(:budget_heading,
group: group,
name: "All City",
price: 1000,
population: 10000,
longitude: 20.50,
latitude: -10.50,
allow_custom_content: true)
end
scenario "Updates group" do
visit edit_admin_budget_group_heading_path(budget, group, heading)
expect(page).to have_field "Heading name", with: "All City"
expect(page).to have_field "Money amount", with: 1000
expect(page).to have_field "Population (optional)", with: 10000
expect(page).to have_field "Longitude (optional)", with: 20.50
expect(page).to have_field "Latitude (optional)", with: -10.50
expect(find_field("Allow content block")).to be_checked
fill_in "Heading name", with: "Districts"
fill_in "Money amount", with: "2000"
fill_in "Population (optional)", with: "20000"
fill_in "Longitude (optional)", with: "-40.47"
fill_in "Latitude (optional)", with: "25.25"
uncheck "Allow content block"
click_button "Save heading"
expect(page).to have_content "Heading updated successfully"
visit edit_admin_budget_group_heading_path(budget, group, heading)
expect(page).to have_field "Heading name", with: "Districts"
expect(page).to have_field "Money amount", with: 2000
expect(page).to have_field "Population (optional)", with: 20000
expect(page).to have_field "Longitude (optional)", with: -40.47
expect(page).to have_field "Latitude (optional)", with: 25.25
expect(find_field("Allow content block")).not_to be_checked
end
scenario "Heading name is already used" do
create(:budget_heading, group: group, name: "Districts")
visit edit_admin_budget_group_heading_path(budget, group, heading)
expect(page).to have_field "Heading name", with: "All City"
fill_in "Heading name", with: "Districts"
click_button "Save heading"
expect(page).not_to have_content "Heading updated successfully"
expect(page).to have_css(".is-invalid-label", text: "Heading name")
expect(page).to have_css("small.form-error", text: "has already been taken")
end
end
end