28aafbd4bc
This rule was added in rubocop 1.44.0. It's useful to avoid accidental `unless !condition` clauses. Note we aren't replacing `unless zero?` with `if nonzero?` because we never use `nonzero?`; using it sounds like `if !zero?`. Replacing `unless any?` with `if none?` is only consistent if we also replace `unless present?` with `if blank?`, so we're also adding this case. For consistency, we're also replacing `unless blank?` with `if present?`. We're also simplifying code dealing with `> 0` conditions in order to make the code (hopefully) easier to understand. Also for consistency, we're enabling the `Style/InverseMethods` rule, which follows a similar idea.
18 lines
379 B
Ruby
18 lines
379 B
Ruby
module Dashboard::ExpectsDateRange
|
|
extend ActiveSupport::Concern
|
|
|
|
include Dashboard::HasProposal
|
|
|
|
def start_date(fallback_date = proposal.created_at.to_date)
|
|
return Date.parse(params[:start_date]) if params[:start_date].present?
|
|
|
|
fallback_date
|
|
end
|
|
|
|
def end_date
|
|
return Date.parse(params[:end_date]) if params[:end_date].present?
|
|
|
|
Date.current
|
|
end
|
|
end
|