2658bb55f6
This way we can show/hide that div when displaying translations, and we can remove the duplication applying the same logic to the label, the input, the error and the CKEditor. This way we also solve the problem of the textarea of the CKEditor taking space when we switch locales, as well as CKEditor itself taking space even when not displayed.
313 lines
8.6 KiB
Ruby
313 lines
8.6 KiB
Ruby
shared_examples "translatable" do |factory_name, path_name, input_fields, textarea_fields = {}|
|
|
let(:language_texts) do
|
|
{
|
|
es: "en español",
|
|
en: "in English",
|
|
fr: "en Français",
|
|
"pt-BR": "Português"
|
|
}
|
|
end
|
|
|
|
let(:translatable_class) { build(factory_name).class }
|
|
|
|
let(:input_fields) { input_fields } # So it's accessible by methods
|
|
let(:textarea_fields) { textarea_fields } # So it's accessible by methods
|
|
|
|
let(:fields) { input_fields + textarea_fields.keys }
|
|
|
|
let(:attributes) do
|
|
fields.product(%i[en es]).map do |field, locale|
|
|
[:"#{field}_#{locale}", text_for(field, locale)]
|
|
end.to_h
|
|
end
|
|
|
|
let(:optional_fields) do
|
|
fields.select do |field|
|
|
translatable.translations.last.dup.tap { |duplicate| duplicate.send(:"#{field}=", "") }.valid?
|
|
end
|
|
end
|
|
|
|
let(:required_fields) do
|
|
fields - optional_fields
|
|
end
|
|
|
|
let(:translatable) { create(factory_name, attributes) }
|
|
let(:path) { send(path_name, *resource_hierarchy_for(translatable)) }
|
|
before { login_as(create(:administrator).user) }
|
|
|
|
context "Manage translations" do
|
|
before do
|
|
if translatable_class.name == "I18nContent"
|
|
skip "Translation handling is different for site customizations"
|
|
end
|
|
end
|
|
|
|
scenario "Add a translation", :js do
|
|
visit path
|
|
|
|
select "Français", from: "translation_locale"
|
|
fields.each { |field| fill_in_field field, :fr, with: text_for(field, :fr) }
|
|
click_button update_button_text
|
|
|
|
visit path
|
|
field = fields.sample
|
|
|
|
expect_page_to_have_translatable_field field, :en, with: text_for(field, :en)
|
|
|
|
click_link "Español"
|
|
expect_page_to_have_translatable_field field, :es, with: text_for(field, :es)
|
|
|
|
click_link "Français"
|
|
expect_page_to_have_translatable_field field, :fr, with: text_for(field, :fr)
|
|
end
|
|
|
|
scenario "Add an invalid translation", :js do
|
|
skip("can't have invalid translations") if required_fields.empty?
|
|
|
|
field = required_fields.sample
|
|
|
|
visit path
|
|
|
|
select "Français", from: "translation_locale"
|
|
fill_in_field field, :fr, with: ""
|
|
click_button update_button_text
|
|
|
|
expect(page).to have_css "#error_explanation"
|
|
|
|
click_link "Français"
|
|
|
|
expect_page_to_have_translatable_field field, :fr, with: ""
|
|
end
|
|
|
|
scenario "Update a translation", :js do
|
|
visit path
|
|
|
|
click_link "Español"
|
|
field = fields.sample
|
|
updated_text = "Corrección de #{text_for(field, :es)}"
|
|
|
|
fill_in_field field, :es, with: updated_text
|
|
|
|
click_button update_button_text
|
|
|
|
visit path
|
|
|
|
expect_page_to_have_translatable_field field, :en, with: text_for(field, :en)
|
|
|
|
select('Español', from: 'locale-switcher')
|
|
|
|
expect_page_to_have_translatable_field field, :es, with: updated_text
|
|
end
|
|
|
|
scenario "Update a translation with invalid data", :js do
|
|
skip("can't have invalid translations") if required_fields.empty?
|
|
|
|
field = required_fields.sample
|
|
|
|
visit path
|
|
click_link "Español"
|
|
|
|
expect_page_to_have_translatable_field field, :es, with: text_for(field, :es)
|
|
|
|
fill_in_field field, :es, with: ""
|
|
click_button update_button_text
|
|
|
|
expect(page).to have_css "#error_explanation"
|
|
|
|
click_link "Español"
|
|
|
|
expect_page_to_have_translatable_field field, :es, with: ""
|
|
end
|
|
|
|
scenario "Remove a translation", :js do
|
|
visit path
|
|
|
|
click_link "Español"
|
|
click_link "Remove language"
|
|
|
|
expect(page).not_to have_link "Español"
|
|
|
|
click_button update_button_text
|
|
|
|
visit path
|
|
expect(page).not_to have_link "Español"
|
|
end
|
|
|
|
scenario "Remove a translation with invalid data", :js do
|
|
skip("can't have invalid translations") if required_fields.empty?
|
|
|
|
field = required_fields.sample
|
|
|
|
visit path
|
|
|
|
click_link "Español"
|
|
click_link "Remove language"
|
|
|
|
click_link "English"
|
|
fill_in_field field, :en, with: ""
|
|
click_button update_button_text
|
|
|
|
expect(page).to have_css "#error_explanation"
|
|
expect_page_to_have_translatable_field field, :en, with: ""
|
|
expect(page).not_to have_link "Español"
|
|
|
|
visit path
|
|
click_link "Español"
|
|
|
|
expect_page_to_have_translatable_field field, :es, with: text_for(field, :es)
|
|
end
|
|
|
|
scenario 'Change value of a translated field to blank', :js do
|
|
skip("can't have translatable blank fields") if optional_fields.empty?
|
|
|
|
field = optional_fields.sample
|
|
|
|
visit path
|
|
expect_page_to_have_translatable_field field, :en, with: text_for(field, :en)
|
|
|
|
fill_in_field field, :en, with: ''
|
|
click_button update_button_text
|
|
|
|
visit path
|
|
expect_page_to_have_translatable_field field, :en, with: ''
|
|
end
|
|
|
|
scenario "Add a translation for a locale with non-underscored name", :js do
|
|
visit path
|
|
|
|
select "Português brasileiro", from: "translation_locale"
|
|
fields.each { |field| fill_in_field field, :"pt-BR", with: text_for(field, :"pt-BR") }
|
|
click_button update_button_text
|
|
|
|
visit path
|
|
|
|
select('Português brasileiro', from: 'locale-switcher')
|
|
|
|
field = fields.sample
|
|
expect_page_to_have_translatable_field field, :"pt-BR", with: text_for(field, :"pt-BR")
|
|
end
|
|
end
|
|
|
|
context "Globalize javascript interface" do
|
|
scenario "Highlight current locale", :js do
|
|
visit path
|
|
|
|
expect(find("a.js-globalize-locale-link.is-active")).to have_content "English"
|
|
|
|
select('Español', from: 'locale-switcher')
|
|
|
|
expect(find("a.js-globalize-locale-link.is-active")).to have_content "Español"
|
|
end
|
|
|
|
scenario "Highlight selected locale", :js do
|
|
visit path
|
|
|
|
expect(find("a.js-globalize-locale-link.is-active")).to have_content "English"
|
|
|
|
click_link "Español"
|
|
|
|
expect(find("a.js-globalize-locale-link.is-active")).to have_content "Español"
|
|
end
|
|
|
|
scenario "Show selected locale form", :js do
|
|
visit path
|
|
field = fields.sample
|
|
|
|
expect_page_to_have_translatable_field field, :en, with: text_for(field, :en)
|
|
|
|
click_link "Español"
|
|
|
|
expect_page_to_have_translatable_field field, :es, with: text_for(field, :es)
|
|
end
|
|
|
|
scenario "Select a locale and add it to the form", :js do
|
|
visit path
|
|
|
|
select "Français", from: "translation_locale"
|
|
|
|
expect(page).to have_link "Français"
|
|
|
|
click_link "Français"
|
|
|
|
expect_page_to_have_translatable_field fields.sample, :fr, with: ""
|
|
end
|
|
end
|
|
end
|
|
|
|
def text_for(field, locale)
|
|
I18n.with_locale(locale) do
|
|
"#{translatable_class.human_attribute_name(field)} #{language_texts[locale]}"
|
|
end
|
|
end
|
|
|
|
def field_for(field, locale, visible: true)
|
|
if translatable_class.name == "I18nContent"
|
|
"contents_content_#{translatable.key}values_#{field}_#{locale}"
|
|
else
|
|
within(".translatable_fields[data-locale='#{locale}']") do
|
|
find("input[id$='_#{field}'], textarea[id$='_#{field}']", visible: visible)[:id]
|
|
end
|
|
end
|
|
end
|
|
|
|
def fill_in_field(field, locale, with:)
|
|
if input_fields.include?(field)
|
|
fill_in field_for(field, locale), with: with
|
|
else
|
|
fill_in_textarea(field, textarea_fields[field], locale, with: with)
|
|
end
|
|
end
|
|
|
|
def fill_in_textarea(field, textarea_type, locale, with:)
|
|
if textarea_type == :markdownit
|
|
click_link class: "fullscreen-toggle"
|
|
fill_in field_for(field, locale), with: with
|
|
click_link class: "fullscreen-toggle"
|
|
elsif textarea_type == :ckeditor
|
|
fill_in_ckeditor field_for(field, locale, visible: false), with: with
|
|
end
|
|
end
|
|
|
|
def expect_page_to_have_translatable_field(field, locale, with:)
|
|
if input_fields.include?(field)
|
|
if translatable_class.name == "I18nContent" && with.blank?
|
|
expect(page).to have_field field_for(field, locale)
|
|
else
|
|
expect(page).to have_field field_for(field, locale), with: with
|
|
end
|
|
else
|
|
textarea_type = textarea_fields[field]
|
|
|
|
if textarea_type == :markdownit
|
|
click_link class: "fullscreen-toggle"
|
|
expect(page).to have_field field_for(field, locale), with: with
|
|
click_link class: "fullscreen-toggle"
|
|
elsif textarea_type == :ckeditor
|
|
within("div.js-globalize-attribute[data-locale='#{locale}'] .ckeditor ") do
|
|
within_frame(0) { expect(page).to have_content with }
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
# FIXME: button texts should be consistent. Right now, buttons don't
|
|
# even share the same colour.
|
|
def update_button_text
|
|
case translatable_class.name
|
|
when "Budget::Investment::Milestone"
|
|
"Update milestone"
|
|
when "AdminNotification"
|
|
"Update notification"
|
|
when "Poll"
|
|
"Update poll"
|
|
when "Poll::Question", "Poll::Question::Answer"
|
|
"Save"
|
|
when "SiteCustomization::Page"
|
|
"Update Custom page"
|
|
when "Widget::Card"
|
|
"Save card"
|
|
else
|
|
"Save changes"
|
|
end
|
|
end
|