As mentioned in commits likea586ba806,a7664ad81,006128da5,b41fbfa52andc480cdd91, accessing the database after starting the browser with the `visit` method sometimes results in database corruption and failing tests on our CI due to the process running the test accessing the database after the process running the browser has started. In this case, we were hiding a proposal after starting the process running the browser to check what happens when accessing a notification for a hidden proposal. We can avoid database access in the middle of the test by hidding a proposal before starting the browser. The process to create a notification using the browser is already tested in other specs, so we don't need to do it here as well. Note that, to simplify the test, we're extracting the `notify_users` method. I wonder whether this method should be called in an `after_create` callback instead... That's a topic for another time, though.
279 lines
7.9 KiB
Ruby
279 lines
7.9 KiB
Ruby
class Proposal < ApplicationRecord
|
|
include Flaggable
|
|
include Taggable
|
|
include Conflictable
|
|
include Measurable
|
|
include Sanitizable
|
|
include Searchable
|
|
include Filterable
|
|
include HasPublicAuthor
|
|
include Graphqlable
|
|
include Followable
|
|
include Communitable
|
|
include Imageable
|
|
include Mappable
|
|
include Notifiable
|
|
include Documentable
|
|
include Videoable
|
|
include Relationable
|
|
include Milestoneable
|
|
include Randomizable
|
|
include SDG::Relatable
|
|
|
|
acts_as_votable
|
|
acts_as_paranoid column: :hidden_at
|
|
include ActsAsParanoidAliases
|
|
|
|
RETIRE_OPTIONS = %w[duplicated started unfeasible done other].freeze
|
|
|
|
translates :title, touch: true
|
|
translates :description, touch: true
|
|
translates :summary, touch: true
|
|
translates :retired_explanation, touch: true
|
|
include Globalizable
|
|
translation_class_delegate :retired_at
|
|
|
|
belongs_to :author, -> { with_hidden }, class_name: "User", inverse_of: :proposals
|
|
belongs_to :geozone
|
|
has_many :comments, as: :commentable, inverse_of: :commentable, dependent: :destroy
|
|
has_many :proposal_notifications, dependent: :destroy
|
|
has_many :dashboard_executed_actions, dependent: :destroy, class_name: "Dashboard::ExecutedAction"
|
|
has_many :dashboard_actions, through: :dashboard_executed_actions, class_name: "Dashboard::Action"
|
|
has_many :polls, as: :related, inverse_of: :related
|
|
has_one :summary_comment, as: :commentable, class_name: "MlSummaryComment", dependent: :destroy
|
|
|
|
validates_translation :title, presence: true, length: { in: 4..Proposal.title_max_length }
|
|
validates_translation :description, length: { maximum: Proposal.description_max_length }
|
|
validates_translation :summary, presence: true
|
|
validates_translation :retired_explanation, presence: true, unless: -> { retired_at.blank? }
|
|
|
|
validates :author, presence: true
|
|
validates :responsible_name, presence: true, unless: :skip_user_verification?
|
|
|
|
validates :responsible_name,
|
|
length: { in: 6..Proposal.responsible_name_max_length },
|
|
unless: :skip_user_verification?
|
|
validates :retired_reason,
|
|
presence: true,
|
|
inclusion: { in: ->(*) { RETIRE_OPTIONS }}, unless: -> { retired_at.blank? }
|
|
|
|
validates :terms_of_service, acceptance: { allow_nil: false }, on: :create
|
|
|
|
before_validation :set_responsible_name
|
|
|
|
before_save :calculate_hot_score, :calculate_confidence_score
|
|
|
|
after_create :send_new_actions_notification_on_create
|
|
|
|
scope :for_render, -> { includes(:tags) }
|
|
scope :sort_by_hot_score, -> { reorder(hot_score: :desc) }
|
|
scope :sort_by_confidence_score, -> { reorder(confidence_score: :desc) }
|
|
scope :sort_by_created_at, -> { reorder(created_at: :desc) }
|
|
scope :sort_by_most_commented, -> { reorder(comments_count: :desc) }
|
|
scope :sort_by_relevance, -> { all }
|
|
scope :sort_by_flags, -> { order(flags_count: :desc, updated_at: :desc) }
|
|
scope :sort_by_archival_date, -> { archived.sort_by_confidence_score }
|
|
scope :sort_by_recommendations, -> { order(cached_votes_up: :desc) }
|
|
|
|
scope :archived, -> { where(created_at: ...Setting.archived_proposals_date_limit) }
|
|
scope :not_archived, -> { where(created_at: Setting.archived_proposals_date_limit..) }
|
|
scope :last_week, -> { where(created_at: 7.days.ago..) }
|
|
scope :retired, -> { where.not(retired_at: nil) }
|
|
scope :not_retired, -> { excluding(retired) }
|
|
scope :successful, -> { where(cached_votes_up: Proposal.votes_needed_for_success..) }
|
|
scope :unsuccessful, -> { where(cached_votes_up: ...Proposal.votes_needed_for_success) }
|
|
scope :public_for_api, -> { all }
|
|
scope :selected, -> { where(selected: true) }
|
|
scope :not_selected, -> { where(selected: false) }
|
|
scope :published, -> { where.not(published_at: nil) }
|
|
scope :draft, -> { excluding(published) }
|
|
|
|
scope :not_supported_by_user, ->(user) { where.not(id: user.find_voted_items(votable_type: "Proposal")) }
|
|
scope :created_by, ->(author) { where(author: author) }
|
|
|
|
def publish
|
|
update!(published_at: Time.current)
|
|
send_new_actions_notification_on_published
|
|
end
|
|
|
|
def published?
|
|
!published_at.nil?
|
|
end
|
|
|
|
def draft?
|
|
published_at.nil?
|
|
end
|
|
|
|
def self.recommendations(user)
|
|
tagged_with(user.interests, any: true)
|
|
.where.not(author_id: user.id)
|
|
.unsuccessful
|
|
.excluding(followed_by_user(user))
|
|
.not_archived
|
|
.not_supported_by_user(user)
|
|
end
|
|
|
|
def to_param
|
|
"#{id}-#{title}".parameterize
|
|
end
|
|
|
|
def searchable_translations_definitions
|
|
{ title => "A",
|
|
summary => "C",
|
|
description => "D" }
|
|
end
|
|
|
|
def searchable_values
|
|
{
|
|
author.username => "B",
|
|
tag_list.join(" ") => "B",
|
|
geozone&.name => "B"
|
|
}.merge!(searchable_globalized_values)
|
|
end
|
|
|
|
def self.search(terms)
|
|
by_code = search_by_code(terms.strip)
|
|
by_code.presence || pg_search(terms)
|
|
end
|
|
|
|
def self.search_by_code(terms)
|
|
matched_code = match_code(terms)
|
|
results = where(id: matched_code[1]) if matched_code
|
|
results if results.present? && results.first.code == terms
|
|
end
|
|
|
|
def self.match_code(terms)
|
|
/\A#{Setting["proposal_code_prefix"]}-\d\d\d\d-\d\d-(\d*)\z/.match(terms)
|
|
end
|
|
|
|
def self.for_summary
|
|
summary = {}
|
|
categories = Tag.category_names.sort
|
|
geozones = Geozone.names.sort
|
|
|
|
groups = categories + geozones
|
|
groups.each do |group|
|
|
summary[group] = search(group).last_week.sort_by_confidence_score.limit(3)
|
|
end
|
|
summary
|
|
end
|
|
|
|
def total_votes
|
|
cached_votes_up
|
|
end
|
|
|
|
def voters
|
|
User.active.where(id: votes_for.voters)
|
|
end
|
|
|
|
def editable?
|
|
total_votes <= Setting["max_votes_for_proposal_edit"].to_i
|
|
end
|
|
|
|
def editable_by?(user)
|
|
author_id == user.id && editable?
|
|
end
|
|
|
|
def votable_by?(user)
|
|
user&.level_two_or_three_verified?
|
|
end
|
|
|
|
def retired?
|
|
retired_at.present?
|
|
end
|
|
|
|
def register_vote(user, vote_value)
|
|
if votable_by?(user) && !archived?
|
|
vote_by(voter: user, vote: vote_value)
|
|
end
|
|
end
|
|
|
|
def code
|
|
"#{Setting["proposal_code_prefix"]}-#{created_at.strftime("%Y-%m")}-#{id}"
|
|
end
|
|
|
|
def after_commented
|
|
save # update cache when it has a new comment
|
|
end
|
|
|
|
def calculate_hot_score
|
|
self.hot_score = ScoreCalculator.hot_score(self)
|
|
end
|
|
|
|
def calculate_confidence_score
|
|
self.confidence_score = ScoreCalculator.confidence_score(total_votes, total_votes)
|
|
end
|
|
|
|
def after_hide
|
|
tags.each { |t| t.decrement_custom_counter_for("Proposal") }
|
|
end
|
|
|
|
def after_restore
|
|
tags.each { |t| t.increment_custom_counter_for("Proposal") }
|
|
end
|
|
|
|
def self.votes_needed_for_success
|
|
Setting["votes_for_proposal_success"].to_i
|
|
end
|
|
|
|
def successful?
|
|
total_votes >= Proposal.votes_needed_for_success
|
|
end
|
|
|
|
def archived?
|
|
created_at <= Setting.archived_proposals_date_limit
|
|
end
|
|
|
|
def notifications
|
|
proposal_notifications
|
|
end
|
|
|
|
def users_to_notify
|
|
followers - [author]
|
|
end
|
|
|
|
def notify_users(notification)
|
|
users_to_notify.each do |user|
|
|
Notification.add(user, notification)
|
|
end
|
|
end
|
|
|
|
def self.proposals_orders(user)
|
|
orders = %w[hot_score confidence_score created_at relevance archival_date]
|
|
|
|
if Setting["feature.user.recommendations_on_proposals"] && user&.recommended_proposals
|
|
orders << "recommendations"
|
|
end
|
|
|
|
orders
|
|
end
|
|
|
|
def skip_user_verification?
|
|
Setting["feature.user.skip_verification"].present?
|
|
end
|
|
|
|
def send_new_actions_notification_on_create
|
|
new_actions = Dashboard::Action.detect_new_actions_since(Date.yesterday, self)
|
|
|
|
if new_actions.present?
|
|
Dashboard::Mailer.delay.new_actions_notification_on_create(self)
|
|
end
|
|
end
|
|
|
|
def send_new_actions_notification_on_published
|
|
new_actions_ids = Dashboard::Action.detect_new_actions_since(Date.yesterday, self)
|
|
|
|
if new_actions_ids.present?
|
|
Dashboard::Mailer.delay.new_actions_notification_on_published(self, new_actions_ids)
|
|
end
|
|
end
|
|
|
|
protected
|
|
|
|
def set_responsible_name
|
|
if author&.document_number?
|
|
self.responsible_name = author.document_number
|
|
end
|
|
end
|
|
end
|