Files
nairobi/app/controllers/admin/legislation/questions_controller.rb
Javi Martín 11832cc07d Make it easier to customize allowed parameters
When customizing CONSUL, one of the most common actions is adding a new
field to a form.

This requires modifying the permitted/allowed parameters. However, in
most cases, the method returning these parameters returned an instance
of `ActionController::Parameters`, so adding more parameters to it
wasn't easy.

So customizing the code required copying the method returning those
parameters and adding the new ones. For example:

```
def something_params
  params.require(:something).permit(
    :one_consul_attribute,
    :another_consul_attribute,
    :my_custom_attribute
  )
end
```

This meant that, if the `something_params` method changed in CONSUL, the
customization of this method had to be updated as well.

So we're extracting the logic returning the parameters to a method which
returns an array. Now this code can be customized without copying the
original method:

```
alias_method :consul_allowed_params, :allowed_params

def allowed_params
  consul_allowed_params + [:my_custom_attribute]
end
```
2022-04-07 19:35:40 +02:00

63 lines
1.7 KiB
Ruby

class Admin::Legislation::QuestionsController < Admin::Legislation::BaseController
include Translatable
load_and_authorize_resource :process, class: "Legislation::Process"
load_and_authorize_resource :question, class: "Legislation::Question", through: :process
def index
@questions = @process.questions
end
def new
end
def create
@question.author = current_user
if @question.save
notice = t("admin.legislation.questions.create.notice", link: question_path)
redirect_to admin_legislation_process_questions_path, notice: notice
else
flash.now[:error] = t("admin.legislation.questions.create.error")
render :new
end
end
def update
if @question.update(question_params)
notice = t("admin.legislation.questions.update.notice", link: question_path)
redirect_to edit_admin_legislation_process_question_path(@process, @question), notice: notice
else
flash.now[:error] = t("admin.legislation.questions.update.error")
render :edit
end
end
def destroy
@question.destroy!
notice = t("admin.legislation.questions.destroy.notice")
redirect_to admin_legislation_process_questions_path, notice: notice
end
private
def question_path
legislation_process_question_path(@process, @question)
end
def question_params
params.require(:legislation_question).permit(allowed_params)
end
def allowed_params
[
translation_params(::Legislation::Question),
question_options_attributes: [:id, :_destroy,
translation_params(::Legislation::QuestionOption)]
]
end
def resource
@question || ::Legislation::Question.find(params[:id])
end
end