11832cc07d
When customizing CONSUL, one of the most common actions is adding a new
field to a form.
This requires modifying the permitted/allowed parameters. However, in
most cases, the method returning these parameters returned an instance
of `ActionController::Parameters`, so adding more parameters to it
wasn't easy.
So customizing the code required copying the method returning those
parameters and adding the new ones. For example:
```
def something_params
params.require(:something).permit(
:one_consul_attribute,
:another_consul_attribute,
:my_custom_attribute
)
end
```
This meant that, if the `something_params` method changed in CONSUL, the
customization of this method had to be updated as well.
So we're extracting the logic returning the parameters to a method which
returns an array. Now this code can be customized without copying the
original method:
```
alias_method :consul_allowed_params, :allowed_params
def allowed_params
consul_allowed_params + [:my_custom_attribute]
end
```
70 lines
1.6 KiB
Ruby
70 lines
1.6 KiB
Ruby
class Admin::BannersController < Admin::BaseController
|
|
include Translatable
|
|
|
|
has_filters %w[all with_active with_inactive], only: :index
|
|
|
|
before_action :banner_sections, only: [:edit, :new, :create, :update]
|
|
|
|
respond_to :html, :js
|
|
|
|
load_and_authorize_resource
|
|
|
|
def index
|
|
@banners = Banner.send(@current_filter).page(params[:page])
|
|
end
|
|
|
|
def create
|
|
@banner = Banner.new(banner_params)
|
|
if @banner.save
|
|
redirect_to admin_banners_path, notice: t("admin.banners.create.notice")
|
|
else
|
|
render :new
|
|
end
|
|
end
|
|
|
|
def update
|
|
if @banner.update(banner_params)
|
|
redirect_to admin_banners_path, notice: t("admin.banners.update.notice")
|
|
else
|
|
render :edit
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
@banner.destroy!
|
|
redirect_to admin_banners_path
|
|
end
|
|
|
|
private
|
|
|
|
def banner_params
|
|
params.require(:banner).permit(allowed_params)
|
|
end
|
|
|
|
def allowed_params
|
|
[:target_url, :post_started_at, :post_ended_at, :background_color, :font_color,
|
|
translation_params(Banner),
|
|
web_section_ids: []]
|
|
end
|
|
|
|
def banner_styles
|
|
@banner_styles = Setting.all.banner_style.map do |banner_style|
|
|
[banner_style.value, banner_style.key.split(".")[1]]
|
|
end
|
|
end
|
|
|
|
def banner_imgs
|
|
@banner_imgs = Setting.all.banner_img.map do |banner_img|
|
|
[banner_img.value, banner_img.key.split(".")[1]]
|
|
end
|
|
end
|
|
|
|
def banner_sections
|
|
@banner_sections = WebSection.all
|
|
end
|
|
|
|
def resource
|
|
@banner ||= Banner.find(params[:id])
|
|
end
|
|
end
|