consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
05eecaf46ca92d02e1edb105a385e3e3b0ddcd32
nairobi/app/models
History
Javi Martín 28aafbd4bc Add and apply Style/InvertibleUnlessCondition rule 
This rule was added in rubocop 1.44.0. It's useful to avoid accidental
`unless !condition` clauses.

Note we aren't replacing `unless zero?` with `if nonzero?` because we
never use `nonzero?`; using it sounds like `if !zero?`.

Replacing `unless any?` with `if none?` is only consistent if we also replace
`unless present?` with `if blank?`, so we're also adding this case. For
consistency, we're also replacing `unless blank?` with `if present?`.

We're also simplifying code dealing with `> 0` conditions in order to
make the code (hopefully) easier to understand.

Also for consistency, we're enabling the `Style/InverseMethods` rule,
which follows a similar idea.
2023-09-07 19:14:03 +02:00
..
abilities
Apply Layout/LineLength rubocop rule
2023-08-30 14:46:35 +02:00
ahoy
Add and apply Layout/ExtraSpacing rubocop rule
2019-10-24 18:11:58 +02:00
banner
Replace occurrences of ActiveRecord::Base on new models
2019-04-17 17:40:56 +02:00
budget
Bump rubocop from 1.35.1 to 1.56.2
2023-09-07 13:09:11 +02:00
ckeditor
Fix deleted file case in CKEditor
2022-02-23 18:21:38 +01:00
comment
Add experimental machine learning
2021-08-16 16:31:04 +02:00
concerns
Add and apply Style/InvertibleUnlessCondition rule
2023-09-07 19:14:03 +02:00
custom
Use the new name in code comments
2023-07-12 16:05:33 +02:00
dashboard
Add and apply MultilineMethodCallIndentation rule
2023-08-18 14:56:16 +02:00
legislation
Bump rubocop from 1.35.1 to 1.56.2
2023-09-07 13:09:11 +02:00
local_census_records
Add and appy MultilineOperationIndentation rule
2023-08-18 14:56:16 +02:00
milestone
Replace occurrences of ActiveRecord::Base on new models
2019-04-17 17:40:56 +02:00
officing
Add and apply rules for multi-line hashes
2023-08-18 14:56:16 +02:00
poll
Apply Layout/LineLength rubocop rule
2023-08-30 14:46:35 +02:00
proposal
Add experimental machine learning
2021-08-16 16:31:04 +02:00
sdg
Add and apply rules for multi-line hashes
2023-08-18 14:56:16 +02:00
site_customization
Add and apply Style/InvertibleUnlessCondition rule
2023-09-07 19:14:03 +02:00
verification
Apply Layout/LineLength rubocop rule
2023-08-30 14:46:35 +02:00
widget
Do not show unpublished proposals on the homepage
2021-09-08 12:38:54 +02:00
.keep
…
ability.rb
Use just one action to hide users
2021-12-30 15:50:02 +01:00
active_poll.rb
Replace occurrences of ActiveRecord::Base on new models
2019-04-17 17:40:56 +02:00
activity.rb
Add lambda to the validations that use model constants
2022-03-22 15:52:36 +01:00
admin_notification.rb
Add and apply Style/InvertibleUnlessCondition rule
2023-09-07 19:14:03 +02:00
administrator.rb
Fix crash deleting admin with assigned budgets
2022-05-03 18:39:42 +02:00
application_record.rb
Make it easier to customize validations
2022-03-24 17:05:35 +01:00
audit.rb
Use a different controller for investment audits
2019-11-05 13:03:45 +01:00
banner.rb
Apply Layout/LineLength rubocop rule
2023-08-30 14:46:35 +02:00
budget_administrator.rb
Apply Layout/LeadingBlankLines rubocop rule
2019-10-26 13:03:48 +02:00
budget_valuator.rb
Add historic fields to participatory budget
2019-06-12 18:03:53 +02:00
budget.rb
Add polygon geographies to Budgets' map
2023-05-31 16:56:15 +02:00
campaign.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
comment_notifier.rb
Add and apply Style/SoleNestedConditional rule
2021-09-03 11:49:53 +02:00
comment.rb
Add and apply MultilineMethodCallBraceLayout rule
2023-08-18 14:56:16 +02:00
community.rb
Use hash conditions instead of SQL's IN
2020-07-08 18:34:58 +02:00
dashboard.rb
Fix more hound warnings
2019-03-27 15:22:14 +01:00
debate.rb
Apply Layout/LineLength rubocop rule
2023-08-30 14:46:35 +02:00
direct_message.rb
Use Date#all_day in DirectMessage.today
2020-04-27 19:26:37 +02:00
direct_upload.rb
Apply Layout/LineLength rubocop rule
2023-08-30 14:46:35 +02:00
document.rb
Remove Paperclip and use just Active Storage
2022-02-23 18:43:48 +01:00
evaluation_comment_notifier.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
failed_census_call.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
flag.rb
Add and apply EmptyLineAfterGuardClause rule
2019-10-24 17:56:03 +02:00
follow.rb
Avoid a brakeman security warning
2021-04-13 13:52:18 +02:00
geozone.rb
Add polygon geographies to Budgets' map
2023-05-31 16:56:15 +02:00
geozones_poll.rb
Apply Rails/HasAndBelongsToMany rubocop rule
2019-10-25 19:29:12 +02:00
i18n_content_translation.rb
Replace occurrences of ActiveRecord::Base on new models
2019-04-17 17:40:56 +02:00
i18n_content.rb
Add and apply Style/MapToHash rubocop rule
2022-10-19 14:26:49 +02:00
identity.rb
Apply Rails/SaveBang rubocop rule
2019-10-23 14:39:31 +02:00
image.rb
Remove metadata from images
2023-06-12 14:30:00 +02:00
legislation.rb
Use double quotes in models
2019-03-14 17:25:43 +01:00
link.rb
Use Rails 5 conventions in Dashboard
2019-04-29 13:08:43 -05:00
local_census_record.rb
Use aria-label in admin table actions
2021-09-20 20:27:37 +02:00
lock.rb
Add and apply Style/InvertibleUnlessCondition rule
2023-09-07 19:14:03 +02:00
machine_learning_info.rb
Add experimental machine learning
2021-08-16 16:31:04 +02:00
machine_learning_job.rb
Add experimental machine learning
2021-08-16 16:31:04 +02:00
machine_learning.rb
Add and apply Style/InvertibleUnlessCondition rule
2023-09-07 19:14:03 +02:00
manager.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
map_location.rb
Add and apply Style/InvertibleUnlessCondition rule
2023-09-07 19:14:03 +02:00
milestone.rb
Add and apply Rails/WhereNot rubocop rule
2021-08-09 23:52:47 +02:00
ml_summary_comment.rb
Add experimental machine learning
2021-08-16 16:31:04 +02:00
moderator.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
newsletter.rb
Extract methods to get recipients and valid segments
2021-12-20 15:07:46 +01:00
notification.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
organization.rb
Apply Layout/LineLength rubocop rule
2023-08-30 14:46:35 +02:00
poll.rb
Add and apply Style/InvertibleUnlessCondition rule
2023-09-07 19:14:03 +02:00
progress_bar.rb
Apply Layout/LineLength rubocop rule
2023-08-30 14:46:35 +02:00
proposal_notification.rb
Apply Layout/LineLength rubocop rule
2023-08-30 14:46:35 +02:00
proposal.rb
Bump rubocop from 1.35.1 to 1.56.2
2023-09-07 13:09:11 +02:00
related_content_score.rb
Apply Layout/RedundantLineBreak rule to short lines
2021-09-03 11:49:53 +02:00
related_content.rb
Apply Layout/LineLength rubocop rule
2023-08-30 14:46:35 +02:00
remote_translation.rb
Rename AvailableLocales.available_locales method
2023-08-30 14:46:35 +02:00
report.rb
Apply rubocop rules to freeze constants
2019-10-26 13:21:36 +02:00
sdg.rb
Add SDG goal model
2020-12-02 12:13:02 +01:00
setting.rb
Add method to get the archived proposals date limit
2023-08-30 14:46:35 +02:00
signature_sheet.rb
Add lambda to the validations that use model constants
2022-03-22 15:52:36 +01:00
signature.rb
Apply Layout/LineLength rubocop rule
2023-08-30 14:46:35 +02:00
site_customization.rb
Use double quotes in models
2019-03-14 17:25:43 +01:00
stats_version.rb
Add table to store stats versions
2019-05-21 13:50:19 +02:00
tag_cloud.rb
Add and apply MultilineMethodCallIndentation rule
2023-08-18 14:56:16 +02:00
tag.rb
Add experimental machine learning
2021-08-16 16:31:04 +02:00
tagging.rb
Add experimental machine learning
2021-08-16 16:31:04 +02:00
tenant.rb
Add and apply Style/InvertibleUnlessCondition rule
2023-09-07 19:14:03 +02:00
topic.rb
Apply Rails/InverseOf rubocop rule
2019-10-25 19:29:12 +02:00
user.rb
Add and apply Style/InvertibleUnlessCondition rule
2023-09-07 19:14:03 +02:00
valuator_group.rb
Replace all occurrences of ActiveRecord::Base with ApplicationRecord
2019-04-17 17:40:56 +02:00
valuator.rb
Add and apply rubocop rules for empty lines
2019-10-24 17:11:47 +02:00
verified_user.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
visit.rb
models inherits from ApplicationRecord
2019-04-17 17:40:56 +02:00
votation_type.rb
Add VotationType model
2022-10-18 10:38:59 +02:00
vote.rb
allows querying for a proposal's votes
2017-12-15 19:21:02 +01:00
web_section.rb
Add sdg management header controller
2021-02-26 16:16:51 +01:00
widget.rb
Simplify widget table prefix
2021-01-12 14:50:37 +01:00