Commit Graph

8801 Commits

Author SHA1 Message Date
Vicente Mendoza
910d49d18c Focus the search of the button 2018-02-09 12:51:15 +01:00
Bertocq
fe071fcf38 Update unreleased section of changelog 2018-02-09 12:17:16 +01:00
BertoCQ
37f0a412d9 Merge pull request #2454 from wairbut-m2c/backport_1191_flaky_budget_investments_orders_random
Fix flaky spec: random investments order scenario
2018-02-09 12:11:18 +01:00
BertoCQ
2bcb9b321f Merge pull request #2452 from consul/help-text
Help text
2018-02-09 12:08:59 +01:00
decabeza
2154a614c2 Adds new legislation processes section on help page 2018-02-08 19:06:41 +01:00
Bertocq
31cece096b Verify manager & moderator sample users in dev_seeds 2018-02-08 18:23:29 +01:00
Raúl Fuentes
dbf4ec9716 changed test, fixed variable instead os us the let option 2018-02-08 16:36:35 +01:00
Raúl Fuentes
ebebbdf078 Added bigger pool for random seeds, now with a 9 * 10e-07 % of chance of appearing, also added test to cover edge cases (case in fact, the coincidence of the seeds it's correct)
Conflicts:
	app/controllers/budgets/investments_controller.rb
2018-02-08 16:33:15 +01:00
Raúl Fuentes
ae25fdfc15 fix for the flaky 2018-02-08 16:29:21 +01:00
BertoCQ
5ddcac8aab Merge pull request #2453 from wairbut-m2c/backport-1194-emails-users-wo-email-should-not-receive-emails
Backport PR #1206 from Madrid's fork
2018-02-08 15:37:34 +01:00
iagirre
80f97b3ca6 The flaky test has been modified completely to test the functionality described. JS has been avoided because it was one of the problems involved and it wasn't completely necessary. 2018-02-08 14:47:10 +01:00
decabeza
dac5b7c9a2 Adds missing polls button on help page 2018-02-07 19:09:30 +01:00
Bertocq
9579a751ab Improve flaky issue template 2018-02-07 02:03:17 +01:00
Bertocq
2e82442dbf Update unreleased section of changelog 2018-02-06 23:35:36 +01:00
Raimond Garcia
f5c5293321 Merge pull request #2444 from consul/specs
Improve spec boot time and clean up logs
2018-02-06 17:15:03 +01:00
BertoCQ
f9770d1243 Merge pull request #2445 from consul/coveralls-badge
Expire Coveralls badge cache
2018-02-06 14:12:55 +01:00
Bertocq
b54b27da79 Add travis failed build link to flakie spec issue template 2018-02-06 13:12:24 +01:00
rgarcia
3a182629ca Remove default profiling
This makes tests run a tiny bit faster and cleans up the logs when
running specs locally

We can still configure rspec to run the profiler when we go into improving spec performance
2018-02-06 12:22:34 +01:00
rgarcia
7b7a426f6a Run Coveralls only in Travis CI
We were seeing a log message when running specs locally

```
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's 'rails' settings.
```

As Coveralls is mainly used in Travis CI, we do not need to load it in
every spec run
2018-02-06 12:22:34 +01:00
rgarcia
6f4d23fdef Remove circular argument reference warning
We were seeing this warning when running specs
`spec/features/admin/budgets_spec.rb:322: warning: circular argument
reference - phase_kind`

This commit should fix the warning
2018-02-06 12:22:34 +01:00
rgarcia
a359517288 Regenerate bin stubs
These are the new binstubs available in the our current `spring`
version, which make specs run much faster 😌
2018-02-06 12:22:19 +01:00
rgarcia
3a07d419f2 Expire Coveralls badge cache
Coverall’s badge seems to be cached and not updating correctly
This commit should expire it and as master is the default Coverall’s
branch, it should display the correct percentage

https://github.com/lemurheavy/coveralls-public/issues/281
2018-02-06 02:11:11 +01:00
Bertocq
f44d64207c Release v0.13 2018-02-05 21:10:09 +01:00
Bertocq
b78a29d607 Update unreleased section of Changelog 2018-02-05 20:28:19 +01:00
BertoCQ
087c8b0a99 Merge pull request #2395 from consul/hidden-comments
Hidden comments
2018-02-05 20:27:05 +01:00
Bertocq
7e67e8c93b Remove unnecesary empty line at milestone model 2018-02-05 15:54:33 +01:00
Bertocq
1ab4c7e578 Update unreleased section of Changelog 2018-02-05 15:54:08 +01:00
Bertocq
64bca8164b Update unreleased section of Changelog 2018-02-05 15:54:05 +01:00
Bertocq
4243f1ce4d Update unreleased section of Changelog 2018-02-05 15:53:47 +01:00
BertoCQ
c16e42e1e3 Merge pull request #2434 from consul/slug_generation_logic
Only change budget slugs if its on draft phase
2018-02-05 15:35:58 +01:00
BertoCQ
4829b97cb6 Merge pull request #2431 from consul/fix_milestones_order
Fix milestones order
2018-02-05 15:35:00 +01:00
BertoCQ
e1d6d4a8f8 Merge pull request #2416 from wairbut-m2c/show_error_message_when_relating_content_to_itself
Show error message when relating content to itself
2018-02-05 12:45:56 +01:00
Bertocq
e0871e5dc6 Only update slug if empty or model condition is met 2018-02-04 23:04:48 +01:00
Bertocq
198ff0cd1f Use updatable slug factory trait to sluggable concern
Slugs should only be updated on certain conditions, we need a trait that
meets that conditions and the name of the trait passed as a mandatory &
named argument on the sluggable concern
2018-02-04 23:04:48 +01:00
Bertocq
8e6e360fc8 Create traits for budget group & heading with drafting budget 2018-02-04 23:04:48 +01:00
Bertocq
8f72972344 Change budget factory name to avoid collisions 2018-02-04 23:04:47 +01:00
Bertocq
2eab6a476e Refactor sluggable concern spec 2018-02-04 22:36:23 +01:00
Bertocq
ea089c1b87 Add missing legislation proposal commentable path 2018-02-03 23:54:22 +01:00
Bertocq
d5c7565b31 Update unreleased section of changelog 2018-02-03 23:22:59 +01:00
Bertocq
770086779e Use new milestone order_by_publication_date order scope 2018-02-03 19:15:59 +01:00
Bertocq
a297faec4b Add order scope to milestone for publication date 2018-02-03 19:15:31 +01:00
Bertocq
67663804c5 Improve investments milestone scenario for ordering
Milestones should be listed ordered by publication date instead of
creation date. The spec was creating only one milestone and not even
expecting the descriptions to be present in the page.
2018-02-03 18:46:43 +01:00
Bertocq
b39c1b5992 Recommend trying mobile viewport & screenshot on PR template 2018-02-03 18:30:14 +01:00
Bertocq
86b27b5bac Add github issue template for flaky specs 2018-02-03 14:47:54 +01:00
Bertocq
6e9191dc7c Budget Investment controller has no update method 2018-02-03 01:19:25 +01:00
Bertocq
04de1e19f5 Make mappable 100 line length compliant 2018-02-02 21:51:49 +01:00
Bertocq
24b1e64113 Validate MapLocation lat/long/zoom have numeric values 2018-02-02 21:37:50 +01:00
Bertocq
6f87f4b07c Correctly check map location attr presence validations 2018-02-02 21:37:05 +01:00
BertoCQ
59b600dd1a Merge pull request #2390 from wairbut-m2c/aperez-user-permissions-specs
Add specs to check users permissions to delete images & documents
2018-02-02 19:42:27 +01:00
BertoCQ
38b66e8c6c Merge pull request #2295 from wairbut-m2c/aperez-mappable-objects
Improvements for Mappable objects
2018-02-02 19:26:47 +01:00