Commit Graph

12 Commits

Author SHA1 Message Date
Javi Martín
a1439d0790 Apply Layout/LineLength rubocop rule
Note we're excluding a few files:

* Configuration files that weren't generated by us
* Migration files that weren't generated by us
* The Gemfile, since it includes an important comment that must be on
  the same line as the gem declaration
* The Budget::Stats class, since the heading statistics are a mess and
  having shorter lines would require a lot of refactoring
2023-08-30 14:46:35 +02:00
Javi Martín
db97f9d08c Add and apply rubocop rules for empty lines
We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
2019-10-24 17:11:47 +02:00
Julian Herrero
31ac8b7f55 Change single quotes to double quotes 2019-02-15 11:40:39 +01:00
Bertocq
ed16a78f42 Enables RSpec/ExampleWording and fixes all issues
Both avoiding 'should' and repiting 'it' on the tests description
improves reading them and also makes all descriptions consistent.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
2018-01-07 01:03:45 +01:00
Bertocq
dc116cc3fe Fix line lenght above 140 2017-11-13 02:31:55 +01:00
Bertocq
f20db4e3e4 Fix user helper expectation 2017-10-19 13:32:48 +02:00
decabeza
b9eb6867d7 updates tags on specs 2017-08-03 10:14:45 +02:00
Juanjo Bazán
7a448b6890 adds BudgetInvestment case to users_helpers 2017-01-10 20:58:01 +01:00
Juanjo Bazán
5aa9cf9c50 changes links in 'My activity' to point to comment
(instead of to commentable)
Closes #947
2016-03-14 13:17:29 +01:00
rgarcia
08c499d4f6 removes spec focus 2015-11-09 13:49:21 +01:00
rgarcia
f4cee3b1c1 adds helper specs 2015-11-09 13:46:37 +01:00
rgarcia
7259ac06e8 renames user_helper 2015-11-09 13:28:02 +01:00