nairobi

Author SHA1 Message Date

Author	SHA1	Message	Date
Javi Martín	92ddcb7aef	Use JavaScript in system tests by default JavaScript is used by about 98% of web users, so by testing without it enabled, we're only testing that the application works for a very reduced number of users. We proceeded this way in the past because CONSUL started using Rails 4.2 and truncating the database between JavaScript tests with database cleaner, which made these tests terribly slow. When we upgraded to Rails 5.1 and introduced system tests, we started using database transactions in JavaScript tests, making these tests much faster. So now we can use JavaScript tests everywhere without critically slowing down our test suite.	2021-04-07 14:41:06 +02:00
Javi Martín	d348e4b688	Add and apply RSpec/EmptyHook rule This rule was added in rubocop-rspec 1.39.0. Now leaving an empty block by accident like I did in commit `91c21b09` is harder :).	2020-10-25 14:23:53 +01:00
Javi Martín	9427f01442	Use system specs instead of feature specs We get rid of database cleaner, and JavaScript tests are faster because between tests we now rollback transactions instead of truncating the database.	2020-04-24 15:43:54 +02:00

Javi Martín

92ddcb7aef

Use JavaScript in system tests by default

JavaScript is used by about 98% of web users, so by testing without it
enabled, we're only testing that the application works for a very
reduced number of users.

We proceeded this way in the past because CONSUL started using Rails 4.2
and truncating the database between JavaScript tests with database
cleaner, which made these tests terribly slow.

When we upgraded to Rails 5.1 and introduced system tests, we started
using database transactions in JavaScript tests, making these tests much
faster. So now we can use JavaScript tests everywhere without critically
slowing down our test suite.

2021-04-07 14:41:06 +02:00

Javi Martín

d348e4b688

Add and apply RSpec/EmptyHook rule

This rule was added in rubocop-rspec 1.39.0. Now leaving an empty block
by accident like I did in commit 91c21b09 is harder :).

2020-10-25 14:23:53 +01:00

Javi Martín

9427f01442

Use system specs instead of feature specs

We get rid of database cleaner, and JavaScript tests are faster because
between tests we now rollback transactions instead of truncating the
database.

2020-04-24 15:43:54 +02:00

3 Commits