Javi Martín
95a90b1895
Simplify method to calculate document max size
...
Since we're only doing the convertion from bytes to megabytes in one
place, IMHO adding an extra method makes the code harder to read.
This way we don't have do include the DocumentsHelper in the specs
anymore, reducing the risk of possible method naming collisions.
2020-04-16 12:08:09 +02:00
Javi Martín
db97f9d08c
Add and apply rubocop rules for empty lines
...
We were very inconsistent regarding these rules.
Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.
The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.
[1] https://rubystyle.guide/#empty-lines-around-bodies
2019-10-24 17:11:47 +02:00
Julian Herrero
8e0bbf54f6
Replace harcoded images and documents settings
2019-06-04 11:50:09 +02:00
rgarcia
f23fd6f3bb
Remove parameterise deprecation warning
...
DEPRECATION WARNING: Passing the separator argument as a positional
parameter is deprecated and will soon be removed. Use `separator: '_'`
instead.
2019-04-17 17:40:55 +02:00
Javi Martín
4c35df4812
Use double quotes inside string interpolation
2019-03-25 14:58:54 +01:00
Julian Herrero
b460c024f3
Use double quotes in app/helpers
2019-03-15 09:26:49 +01:00
Manuel Ortega
2fef9c14d0
Moving humanized_content_type from DocumentablesHelper to Document model. Removing humanized_file_size in favor of direct use of number_to_human_size form ActionViewHelper. Added additional documentens to all concerned views
2017-10-18 22:21:01 +02:00
Manuel Ortega
97fb986626
Added documentable feature to legislation processes
2017-10-18 19:50:34 +02:00
Bertocq
ce0a7f6fad
Rubocop autocorrections
2017-10-17 22:00:00 +02:00
Senén Rodero Rodríguez
2993ef8707
Remove documents single uploads
2017-09-27 11:04:56 +02:00
Senén Rodero Rodríguez
2854c0b683
Some fixes and refactor
2017-09-26 13:57:14 +02:00
Senén Rodero Rodríguez
346c329919
Some fixes after rebase against master
2017-09-26 13:56:06 +02:00
Senén Rodero Rodríguez
824dd26d5a
User new direct uploads controllers action on documentable. Skipped spec.
2017-09-26 13:55:51 +02:00
Senén Rodero Rodríguez
c6dabedb4a
Add missing image model spec. Add shared specs to check image validations at any imageable model
2017-09-26 13:55:03 +02:00
Senén Rodero Rodríguez
6f71da07ee
Duplicate documentable code and rename for imageable
2017-09-26 13:55:03 +02:00
Bertocq
a3428ee589
Use snake_case for method names
2017-09-15 14:06:17 +02:00
Bertocq
e4e78c8f16
Rubocop autocorrections
2017-09-14 15:08:35 +02:00
Senén Rodero Rodríguez
b2a6189cf5
Views and helpers refactor
2017-08-25 18:34:54 +02:00
Senén Rodero Rodríguez
cc89907bff
Add nested documents to proposal form.
2017-08-25 18:34:52 +02:00
Senén Rodero Rodríguez
e9c5f77368
Accept nested attributes for documents on proposals. Adapt documentable js file to allow many input files at the same page.
2017-08-25 18:34:51 +02:00
Senén Rodero Rodríguez
a709cd0479
Add accept HTML attribute to documents form file input.
2017-08-25 18:34:50 +02:00
Senén Rodero Rodríguez
92e8468e89
Use documentables helper method within specs and document model.
2017-08-25 18:34:50 +02:00
Senén Rodero Rodríguez
3a7c9d9f83
Add documentables helper
2017-08-25 18:34:49 +02:00
