Commit Graph

11315 Commits

Author SHA1 Message Date
Alberto
25b56e84ec Merge pull request #3196 from consul/refactor_milestones_css
[Backport] Refactor milestones css
2019-01-24 12:02:15 +01:00
Alberto
227f496f6d Merge pull request #3195 from consul/milestone_progress_bar
[Backport] Manage milestone progress bars
2019-01-24 11:59:24 +01:00
Alberto
c3d77820ab Merge pull request #3203 from consul/admin-budgets-form
[Backport] Show current phase as selected on phase select on admin budgets form
2019-01-23 15:21:19 +01:00
decabeza
75531c6c80 Show current phase as selected on phase select on admin budgets form 2019-01-23 14:30:35 +01:00
Alberto
d4eaa03c52 Merge pull request #3200 from consul/legislation-proposal-new
Remove help and recommendations on legislation proposal new form
2019-01-23 14:27:06 +01:00
Manu
abcb96ffda added test spec for creation of legislative process with image 2019-01-22 16:32:05 -05:00
Julian Herrero
33d6f6c18d Sort Legislation Processes by descending start date 2019-01-22 18:51:22 +01:00
decabeza
f5c7065d90 Remove help and recommendations on legislation proposal new form 2019-01-22 11:52:25 +01:00
Manu
bf219a0a43 schema.rb changes 2019-01-21 12:02:27 -05:00
Manu
14d64e94d0 rspec tests were added for the process banner 2019-01-21 12:02:27 -05:00
Manu
b462b7131e validations were added for the process banner 2019-01-21 12:02:27 -05:00
Manu
d08fc08769 added i18n to process form 2019-01-21 12:02:27 -05:00
Manu
b6cfe92d76 fixed banner styles issues 2019-01-21 12:02:27 -05:00
Manu
37edfb94a4 changed h4 instead of h3 2019-01-21 12:02:27 -05:00
Manu
1e020f4df8 use banners js in new legislative process 2019-01-21 12:02:27 -05:00
Manu
e5cba7ac2e removed wrong tables from schema.rb 2019-01-21 12:02:27 -05:00
Manu
bd4e12112d Add image to legislation processes and banner colors 2019-01-21 12:02:27 -05:00
Javi Martín
486100bf53 Add specs for custom page cards 2019-01-21 10:40:24 -05:00
Javi Martín
2926e4e375 Fix managing widget cards for homepage
The condition `params[:page_id] != 0` didn't work properly when editing
the homepage because in that case the parameter was `nil`, and the line
`SiteCustomization::Page.find(@card.site_customization_page_id)` raised
an exception because it couldn't find a page with a `nil` ID.

Fixing the issue while maintaining the check against `0` lead to complex
code, and so allowing `nil` in the database and assuming cards with no
`site_customization_page_id` belonged in the homepage seemed to be the
easiest solution.
2019-01-21 10:40:14 -05:00
Javi Martín
9c050ca6bd Extract method to redirect when managing cards 2019-01-21 10:40:04 -05:00
Javi Martín
8a643c72e7 Use I18n for card notice messages 2019-01-21 10:39:42 -05:00
Alberto
858faa481c Merge pull request #3198 from consul/budget-text
[Backport] Update budgets confirm group es translation
2019-01-18 17:55:31 +01:00
decabeza
908afb5f32 Update budgets confirm group es translation 2019-01-18 17:02:32 +01:00
Manu
162b61f94c updated test file for cards 2019-01-18 09:54:43 -05:00
Manu
bff3a3b379 use relation between cards and page models 2019-01-18 09:54:43 -05:00
Manu
238ddc2595 fixed trailing whitespace hound alert 2019-01-18 09:54:43 -05:00
Manu
142a0403d6 added new scss class 'custom-page' 2019-01-18 09:54:43 -05:00
Manu
86d75767e8 change h3 tag to h2 and added title of the custom page which we are adding the cards 2019-01-18 09:54:43 -05:00
Manu
26db37a17f fixed wrong menu selection inside site content 2019-01-18 09:54:43 -05:00
Manu
7657a0e0b4 added i18n text to custom pages cards 2019-01-18 09:54:43 -05:00
Manu
5627d2cf23 added associations between cards and pages models 2019-01-18 09:54:43 -05:00
Manu
2dd953bdfd added hound corrections and removed wrong tables form the schema.rb 2019-01-18 09:54:43 -05:00
Manu
722a431b54 Add cards to custom pages 2019-01-18 09:54:43 -05:00
Javi Martín
fb72fc48fd Simplify milestones styles for small devices
The selector `nth-child(even)` didn't need specific rules, and it's
easier to understand the code for the selector `nth-child(odd)` if all
breakpoints are grouped together.
2019-01-18 14:26:17 +01:00
Javi Martín
46296b702e Group milestone content CSS rules together 2019-01-18 14:26:11 +01:00
Javi Martín
39c8d431f8 Group milestones timeline li CSS rules together 2019-01-18 14:26:08 +01:00
Javi Martín
cb92d29ddc Simplify nth-child selectors
Using `nth-child(odd), nth-child(even)` is the same as selecting all
the elements.
2019-01-18 14:26:05 +01:00
Javi Martín
51a4ca98ad Move milestone styles to their own sheet 2019-01-18 14:26:02 +01:00
Javi Martín
789476e6ab Synchronize percentage for new progress bars
According to the HTML specification:

> The default value is the minimum plus half the difference between the
> minimum and the maximum, unless the maximum is less than the minimum,
> in which case the default value is the minimum.

So for new progress bars, we had a numeric value of `nil` and a range
value of `50`, meaning the input fields weren't in sync.

Manually triggering the event on the progress, while not an ideal
solution (ideally we would be able to define `0` as default), sets the
value of the numeric field.
2019-01-18 14:17:53 +01:00
Javi Martín
fff5673ec0 Simplify hiding/showing progress bar type field
With a parent element for just input and label, there aren't conflicts
with the globalize tabs code anymore.
2019-01-18 14:17:48 +01:00
Javi Martín
96454a41f0 Use I18n keys instead of human_attribute_name
Even if it means duplicating the translations in many cases, it's
consistent with the rest of the application.
2019-01-18 14:17:45 +01:00
decabeza
7c0fb96b02 Adds styles to admin progress bars views 2019-01-18 14:17:40 +01:00
Javi Martín
dfdf0b0636 Hide title field for primary progress bars
These bars don't have a title.
2019-01-18 14:17:37 +01:00
Javi Martín
c5d32c5ab9 Manage progress bars in the admin area 2019-01-18 14:17:33 +01:00
Javi Martín
4f25581636 Add progress bar polymorphic views 2019-01-18 14:17:29 +01:00
Javi Martín
eaea95ccfb Add progress bar model 2019-01-18 14:17:12 +01:00
Javi Martín
c3c9b02220 Move milestone factories to their own file 2019-01-18 14:15:27 +01:00
Julian Nicolas Herrero
357d0617e2 Merge pull request #3174 from consul/backport-1736-pending_specs_proposal_notification_limits
[Backport] Add pending specs proposal notification limits
2019-01-18 11:06:03 +01:00
Julian Nicolas Herrero
db404429fc Merge pull request #3190 from consul/release_0.18.1
Release 0.18.1
2019-01-18 10:43:43 +01:00
Javi Martín
f2210bc5b5 Update changelog for release 0.18.1 2019-01-17 13:17:38 +01:00