Commit Graph

16282 Commits

Author SHA1 Message Date
dependabot-preview[bot]
853119437b Bump database_cleaner from 1.7.0 to 1.8.5
Bumps [database_cleaner](https://github.com/DatabaseCleaner/database_cleaner) from 1.7.0 to 1.8.5.
- [Release notes](https://github.com/DatabaseCleaner/database_cleaner/releases)
- [Changelog](https://github.com/DatabaseCleaner/database_cleaner/blob/master/History.rdoc)
- [Commits](https://github.com/DatabaseCleaner/database_cleaner/compare/v1.7.0...v1.8.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-24 13:17:00 +00:00
Javi Martín
c5f4cd6229 Fix invalid "hint" attribute in forms
Using `hint: false` was generating an input with `hint="false"` instead
of generating no hint at all.
2020-08-22 23:00:14 +02:00
Javi Martín
f49745d7ba Simplify passing the object in the form builder
The object is already a method, so we don't need to pass it around.
2020-08-22 23:00:14 +02:00
Javier Martín
9761558d01 Merge pull request #4092 from consul/dependabot/bundler/capistrano-rails-1.6.1
Bump capistrano-rails from 1.4.0 to 1.6.1
2020-08-22 17:05:39 +02:00
Javier Martín
6023ee5c0e Merge pull request #4088 from consul/dependabot/bundler/web-console-3.7.0
Bump web-console from 3.3.0 to 3.7.0
2020-08-22 15:54:18 +02:00
Javier Martín
daf11cbfb3 Merge pull request #4095 from consul/dependabot/bundler/font-awesome-sass-5.13.0
Bump font-awesome-sass from 5.8.1 to 5.13.0
2020-08-22 15:39:13 +02:00
dependabot-preview[bot]
cce9d0dd55 Bump font-awesome-sass from 5.8.1 to 5.13.0
Bumps [font-awesome-sass](https://github.com/FortAwesome/font-awesome-sass) from 5.8.1 to 5.13.0.
- [Release notes](https://github.com/FortAwesome/font-awesome-sass/releases)
- [Commits](https://github.com/FortAwesome/font-awesome-sass/compare/5.8.1...5.13.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-22 13:24:17 +00:00
dependabot-preview[bot]
e28fa4be3b Bump web-console from 3.3.0 to 3.7.0
Bumps [web-console](https://github.com/rails/web-console) from 3.3.0 to 3.7.0.
- [Release notes](https://github.com/rails/web-console/releases)
- [Changelog](https://github.com/rails/web-console/blob/master/CHANGELOG.markdown)
- [Commits](https://github.com/rails/web-console/compare/v3.3.0...v3.7.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-22 13:08:17 +00:00
Javier Martín
affd12a046 Merge pull request #4093 from consul/dependabot/bundler/scss_lint-0.59.0
Bump scss_lint from 0.55.0 to 0.59.0
2020-08-22 15:06:33 +02:00
dependabot-preview[bot]
f7f532ab47 Bump initialjs-rails from 0.2.0.8 to 0.2.0.9
Bumps [initialjs-rails](https://github.com/dgilperez/initialjs-rails) from 0.2.0.8 to 0.2.0.9.
- [Release notes](https://github.com/dgilperez/initialjs-rails/releases)
- [Changelog](https://github.com/dgilperez/initialjs-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/dgilperez/initialjs-rails/compare/v0.2.0.8...v0.2.0.9)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-22 13:02:48 +00:00
Javier Martín
3178f388ea Merge pull request #4094 from consul/dependabot/bundler/i18n-tasks-0.9.31
Bump i18n-tasks from 0.9.29 to 0.9.31
2020-08-22 15:01:04 +02:00
Javier Martín
94f261f667 Merge pull request #4091 from consul/dependabot/bundler/capybara-webmock-0.5.5
Bump capybara-webmock from 0.5.3 to 0.5.5
2020-08-22 14:56:56 +02:00
dependabot-preview[bot]
8be7facf15 Bump i18n-tasks from 0.9.29 to 0.9.31
Bumps [i18n-tasks](https://github.com/glebm/i18n-tasks) from 0.9.29 to 0.9.31.
- [Release notes](https://github.com/glebm/i18n-tasks/releases)
- [Changelog](https://github.com/glebm/i18n-tasks/blob/master/CHANGES.md)
- [Commits](https://github.com/glebm/i18n-tasks/compare/v0.9.29...v0.9.31)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-18 13:14:56 +00:00
dependabot-preview[bot]
1367b30934 Bump scss_lint from 0.55.0 to 0.59.0
Bumps [scss_lint](https://github.com/sds/scss-lint) from 0.55.0 to 0.59.0.
- [Release notes](https://github.com/sds/scss-lint/releases)
- [Changelog](https://github.com/sds/scss-lint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sds/scss-lint/compare/v0.55.0...v0.59.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-18 13:14:12 +00:00
dependabot-preview[bot]
d8e4dac573 Bump capistrano-rails from 1.4.0 to 1.6.1
Bumps [capistrano-rails](https://github.com/capistrano/rails) from 1.4.0 to 1.6.1.
- [Release notes](https://github.com/capistrano/rails/releases)
- [Commits](https://github.com/capistrano/rails/compare/v1.4.0...v1.6.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-17 13:17:20 +00:00
dependabot-preview[bot]
67f3b7dc67 Bump capybara-webmock from 0.5.3 to 0.5.5
Bumps [capybara-webmock](https://github.com/hashrocket/capybara-webmock) from 0.5.3 to 0.5.5.
- [Release notes](https://github.com/hashrocket/capybara-webmock/releases)
- [Commits](https://github.com/hashrocket/capybara-webmock/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-17 13:16:36 +00:00
Javier Martín
1ab1e68832 Merge pull request #4082 from consul/disable_phase
Disable phase date fields when a phase is disabled
2020-08-15 13:47:24 +02:00
Javi Martín
1e70a3db02 Disable phase date fields when a phase is disabled
The JavaScript involved wasn't working since we removed the disable-date
attribute in commit 73ff6881.

We're also improving the JavaScript in two ways:

First, we trigger the `change` event immediately, so when the page loads
date fields are disabled when phases are disabled.

And second, we don't remove the selected dates when disabling a phase,
so disabling it and enabling it again will keep the selected values.
2020-08-15 13:31:32 +02:00
Javi Martín
6172dd0a56 Group phase related fields in fieldsets
We were using a <label> tag with no associated field where a <legend>
tag was more appropriate. With a fieldset, we also make it obvious these
fields are related.
2020-08-15 13:31:32 +02:00
Javier Martín
146ffc8b9a Merge pull request #3905 from consul/dependabot/bundler/paperclip-6.1.0
Bump paperclip from 5.2.1 to 6.1.0
2020-08-14 23:17:12 +02:00
Javier Martín
9995d873bd Merge pull request #4075 from consul/dependabot/bundler/groupdate-5.1.0
Bump groupdate from 3.2.0 to 5.1.0
2020-08-14 23:11:40 +02:00
dependabot-preview[bot]
9d9824d1f3 Bump groupdate from 3.2.0 to 5.1.0
Bumps [groupdate](https://github.com/ankane/groupdate) from 3.2.0 to 5.1.0.
- [Release notes](https://github.com/ankane/groupdate/releases)
- [Changelog](https://github.com/ankane/groupdate/blob/master/CHANGELOG.md)
- [Commits](https://github.com/ankane/groupdate/compare/v3.2.0...v5.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-14 20:42:18 +00:00
Javier Martín
b6153c9e08 Merge pull request #3935 from consul/dependabot/bundler/omniauth-1.9.1
Bump omniauth from 1.9.0 to 1.9.1
2020-08-14 22:40:29 +02:00
dependabot-preview[bot]
8419d7fbd7 [Security] Bump omniauth from 1.9.0 to 1.9.1
Bumps [omniauth](https://github.com/omniauth/omniauth) from 1.9.0 to 1.9.1. **This update includes a security fix.**
- [Release notes](https://github.com/omniauth/omniauth/releases)
- [Commits](https://github.com/omniauth/omniauth/compare/v1.9.0...v1.9.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-14 20:26:15 +00:00
dependabot-preview[bot]
7786e45114 Bump paperclip from 5.2.1 to 6.1.0
Bumps [paperclip](https://github.com/thoughtbot/paperclip) from 5.2.1 to 6.1.0.
- [Release notes](https://github.com/thoughtbot/paperclip/releases)
- [Changelog](https://github.com/thoughtbot/paperclip/blob/master/NEWS)
- [Commits](https://github.com/thoughtbot/paperclip/compare/v5.2.1...v6.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-14 20:24:08 +00:00
Javier Martín
9b955bdd67 Merge pull request #3665 from consul/dependabot/bundler/daemons-and-capistrano3-delayed-job-1.3.1
Bump daemons and capistrano3-delayed-job
2020-08-14 22:22:18 +02:00
dependabot-preview[bot]
f397d91e04 Bump daemons and capistrano3-delayed-job
Bumps [daemons](https://github.com/thuehlinger/daemons) and [capistrano3-delayed-job](https://github.com/AgileConsultingLLC/capistrano3-delayed-job). These dependencies needed to be updated together.

Updates `daemons` from 1.2.6 to 1.3.1
- [Release notes](https://github.com/thuehlinger/daemons/releases)
- [Changelog](https://github.com/thuehlinger/daemons/blob/master/Releases)
- [Commits](https://github.com/thuehlinger/daemons/compare/v1.2.6...v1.3.1)

Updates `capistrano3-delayed-job` from 1.7.5 to 1.7.6
- [Release notes](https://github.com/AgileConsultingLLC/capistrano3-delayed-job/releases)
- [Commits](https://github.com/AgileConsultingLLC/capistrano3-delayed-job/compare/v1.7.5...v1.7.6)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-14 20:09:08 +00:00
Javier Martín
3ae7148ff4 Merge pull request #4044 from consul/dependabot/bundler/wicked_pdf-2.1.0
Bump wicked_pdf from 1.1.0 to 2.1.0
2020-08-14 22:03:04 +02:00
dependabot-preview[bot]
0de2b7d56d Bump wicked_pdf from 1.1.0 to 2.1.0
Bumps [wicked_pdf](https://github.com/mileszs/wicked_pdf) from 1.1.0 to 2.1.0.
- [Release notes](https://github.com/mileszs/wicked_pdf/releases)
- [Changelog](https://github.com/mileszs/wicked_pdf/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mileszs/wicked_pdf/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-14 18:46:10 +00:00
Javier Martín
07a6279f58 Merge pull request #3710 from consul/dependabot/bundler/jquery-fileupload-rails-1.0.0
Bump jquery-fileupload-rails from 0.4.7 to 1.0.0
2020-08-14 20:42:36 +02:00
Javier Martín
4d947e5cd5 Merge pull request #3662 from consul/dependabot/bundler/rails-assets-markdown-it-9.0.1
Bump rails-assets-markdown-it from 8.2.2 to 9.0.1
2020-08-14 20:29:03 +02:00
dependabot-preview[bot]
7bbaad9f52 Bump jquery-fileupload-rails from 0.4.7 to 1.0.0
Bumps [jquery-fileupload-rails](https://github.com/tors/jquery-fileupload-rails) from 0.4.7 to 1.0.0.
- [Release notes](https://github.com/tors/jquery-fileupload-rails/releases)
- [Commits](https://github.com/tors/jquery-fileupload-rails/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-14 18:26:31 +00:00
dependabot-preview[bot]
637d162b74 Bump rails-assets-markdown-it from 8.2.2 to 9.0.1
Bumps rails-assets-markdown-it from 8.2.2 to 9.0.1.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-14 18:07:14 +00:00
Javier Martín
84a690f19e Merge pull request #3605 from consul/dependabot/bundler/rails-assets-leaflet-1.5.1
Bump rails-assets-leaflet from 1.2.0 to 1.5.1
2020-08-14 20:05:27 +02:00
Javier Martín
11204b0194 Merge pull request #4083 from consul/disable_buttons
Don't disable button to download emails
2020-08-14 18:37:07 +02:00
dependabot-preview[bot]
3ccc0cfcf0 Bump rails-assets-leaflet from 1.2.0 to 1.5.1
Bumps rails-assets-leaflet from 1.2.0 to 1.5.1.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-14 11:15:05 +00:00
Javier Martín
545501ae0f Merge pull request #3708 from consul/dependabot/bundler/cocoon-1.2.14
Bump cocoon from 1.2.11 to 1.2.14
2020-08-14 13:11:52 +02:00
Javier Martín
2094c25eba Merge pull request #3865 from consul/dependabot/bundler/acts-as-taggable-on-6.5.0
Bump acts-as-taggable-on from 6.0.0 to 6.5.0
2020-08-14 12:56:25 +02:00
dependabot-preview[bot]
c23ece99e1 Bump cocoon from 1.2.11 to 1.2.14
Bumps [cocoon](https://github.com/nathanvda/cocoon) from 1.2.11 to 1.2.14.
- [Release notes](https://github.com/nathanvda/cocoon/releases)
- [Changelog](https://github.com/nathanvda/cocoon/blob/master/History.md)
- [Commits](https://github.com/nathanvda/cocoon/compare/v1.2.11...v1.2.14)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-08-14 10:41:23 +00:00
Javier Martín
13e70ed492 Merge pull request #4077 from consul/fix_orbit
Fix poll answer images not being displayed
2020-08-13 18:27:57 +02:00
Javi Martín
e319b93dc6 Don't disable button to download emails
Rails automatically disables buttons when submitting a form. This works
fine most of the time: for AJAX requests, it enables them again after
the request is complete, and for non-AJAX requests, the button is
replaced by a new element when the new page loads.

However, there's an exception. When a request returns data so users can
download a fire, the request is not an AJAX one and the button is not
replaced. So users are left with a disabled button they can no longer
click.

So in this case, we aren't disabling the button after a user clicks it.
2020-08-13 18:11:02 +02:00
Javi Martín
38ebfed6ea Remove redundant code to prevent double submission
As mentioned in commit 7f30d0c6, Rails already does it automatically.
2020-08-13 18:11:02 +02:00
Javier Martín
373661025c Merge pull request #4080 from consul/banner_margin
Fix banner overlapping with other content
2020-08-12 18:25:41 +02:00
Javi Martín
e5f71d33d0 Fix poll answer images not being displayed
After updating foundation-rails in commit 58071fd6, the orbit slider
stopped working properly. That's because the `.orbit-slide` elements now
use a `position: absolute` rule, and so our rule for `.orbit-container`
elements making their height 100% (which we added in order to be able to
add images with different heights) makes them have a height of 0px,
since now the `.orbit-slide` elements are not part of the document flow
anymore.

Making the `.orbit-slide` elements have relative position fixes this
issue, but introduces a different one, producing a really bad-looking
animation when changing a slide.

So we're disabling the animation as well in order to avoid this jump.

This change also fixes another issue introduced in commit 58071fd6 which
caused slide controls to stop working when changing slides back and
forth.
2020-08-12 17:18:49 +02:00
Javi Martín
0b83be6837 Apply banner default colors to dev seeds
Banners created through the admin form were getting the default color.
However, banners created by other means (like the `db:dev_seed` rake
task) were not getting these default values.

This feature was originally implemented when we were using Rails 4.
With Rails 5, we can provide default values to all new banners and
simplify the code at the same time thanks to its `attribute` method.

Now, when creating a new banner, instead of getting a blank space, we
get an empty line with the banner's default background color, which most
users won't know what it's about until they fill in the banner's title.
So we're not displaying the content of the banner when it's empty,
thanks to the `:empty` CSS pseudoclass.
2020-08-12 17:16:11 +02:00
Javi Martín
361b7ee09d Fix banner text alignment
Unlike the rest of the page, it had no left margin nor padding
whatsoever.
2020-08-12 17:01:40 +02:00
Javi Martín
14a5d82377 Fix banner overlapping with other content
In some sections we had negative top margins to compensate the header
bottom margin. However, when adding a banner between the header and
those sections, the negative margin caused the content of those sections
to overlap with the content of the banner.

Removing the negative margins when a banner is present solves the issue.
2020-08-12 17:01:40 +02:00
Javi Martín
400c3a6fa0 Move header margin styles to CSS
Using HTML classes to apply styles to certain elements makes views
harder to customize.
2020-08-12 17:01:40 +02:00
Javier Martín
b8894eac70 Merge pull request #3699 from consul/upgrade_turbolinks
Bump turbolinks to 5.2.1
2020-08-12 14:34:19 +02:00
Javier Martín
a56c2d4a23 Merge pull request #4079 from consul/get_params
Fix redirect with GET params of after POST requests
2020-08-12 14:25:08 +02:00