nairobi

consul/nairobi

Fork 0

Commit Graph

Author	SHA1	Message	Date
Javi Martín	3da4ee00b8	Simplify tests requiring admin login We were repeating the same code over and over (with a few variants) to setup tests which require an administrator. We can use a tag and simplify the code.	2020-12-02 15:33:19 +01:00
Javi Martín	37361a6f3d	Replace render :nothing with head :ok Using `render :nothing` was deprecated, but we never noticed it because we didn't have a test for the action using it. In Rails 5.1, it raises an exception. Using `head :ok` and adding a test for this scenario solves the issue.	2020-04-24 15:43:54 +02:00
Javi Martín	9427f01442	Use system specs instead of feature specs We get rid of database cleaner, and JavaScript tests are faster because between tests we now rollback transactions instead of truncating the database.	2020-04-24 15:43:54 +02:00

Author

SHA1

Message

Date

Javi Martín

3da4ee00b8

Simplify tests requiring admin login

We were repeating the same code over and over (with a few variants) to
setup tests which require an administrator. We can use a tag and
simplify the code.

2020-12-02 15:33:19 +01:00

Javi Martín

37361a6f3d

Replace render :nothing with head :ok

Using `render :nothing` was deprecated, but we never noticed it because
we didn't have a test for the action using it. In Rails 5.1, it raises
an exception.

Using `head :ok` and adding a test for this scenario solves the issue.

2020-04-24 15:43:54 +02:00

Javi Martín

9427f01442

Use system specs instead of feature specs

We get rid of database cleaner, and JavaScript tests are faster because
between tests we now rollback transactions instead of truncating the
database.

2020-04-24 15:43:54 +02:00

3 Commits