consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,771 Commits 1 Branch 0 Tags
cb15a2e25b3db45815f23589797812884785b35c
Commit Graph

8771 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bertocq
dea67bb078 Update README.md and translate to README_ES.md 
* Links to documentation and project's website were outdated
* There where some linting issues reported from Markdownlinter
 2018-01-09 14:52:57 +01:00
Raúl Fuentes
29018e3062 changes made at the request of voodoorai2000 2018-01-09 13:08:03 +01:00
Raúl Fuentes
b3461b2051 final details 2018-01-09 12:45:30 +01:00
Raúl Fuentes
4f096a005d more style corrections 2018-01-09 12:45:30 +01:00
Raúl Fuentes
d7cc5d14c6 fixed test 2018-01-09 12:45:30 +01:00
Raúl Fuentes
56f4c3c3b9 added test to csv download and style corrections 2018-01-09 12:45:30 +01:00
Raúl Fuentes
95c1aa43e8 added csv download link to budget_investments (issue 1625) 2018-01-09 12:45:30 +01:00
María Checa
27ce8c9b1b Updated changelog 2018-01-09 12:19:16 +01:00
María Checa
c27e6ab1d1 Merge pull request #2223 from wairbut-m2c/iagirre-prevent-edition-if-budget-final-phase 
Prevent edition of investments if budget is in the final phase
 2018-01-09 12:18:23 +01:00
María Checa
1d82c6a80d Updated changelog 2018-01-09 11:56:58 +01:00
María Checa
96859190be Merge pull request #2280 from consul/2277-budgets_new_form 
Budgets new form
 2018-01-09 11:55:10 +01:00
Bertocq
a770961f74 Update unreleased section of changelog 2018-01-09 11:39:46 +01:00
rgarcia
69d0dc5825 Updates Changelog 2018-01-09 11:11:47 +01:00
BertoCQ
5f1d222582 Merge pull request #2283 from consul/feature/2275#destroy_budgets 
Allow destroying budgets without investments
 2018-01-09 11:04:01 +01:00
BertoCQ
6e96c8c057 Merge branch 'master' into feature/2275#destroy_budgets 2018-01-09 11:03:51 +01:00
BertoCQ
01c41c7cca Merge pull request #2284 from consul/feature/2276#admin_budget_edit_redirect 
Redirect admin to budget lists after edit
 2018-01-09 10:50:54 +01:00
BertoCQ
bcec5f779a Merge pull request #2285 from consul/feature/2278#budget_draft_phase 
Feature/2278#budget draft phase
 2018-01-09 10:50:40 +01:00
Bertocq
7c7f903ed0 Make customization engine spec less prone to flaky failures 2018-01-09 01:33:44 +01:00
Bertocq
2c3d8e9fd5 Avoid creating a budget in drafting phase to test results access 2018-01-09 01:16:09 +01:00
Bertocq
beee890285 Login as admin before visiting drafting budget on spec 2018-01-09 00:34:16 +01:00
Bertocq
0f5999fb8d Move admin creation into shared let on spec 2018-01-09 00:33:55 +01:00
María Checa
cd53884d72 Updated dev_seeds 2018-01-09 00:09:56 +01:00
María Checa
d8a6bb0f91 Changed tests 2018-01-09 00:09:50 +01:00
María Checa
385db76a24 Changed location attribute label text 2018-01-08 23:23:02 +01:00
María Checa
5161988844 Removed external_url input 2018-01-08 23:22:46 +01:00
Bertocq
4916f9a3c3 Avoid listing non-published Budgets to the public 
Why:

Non-admins shouldn't be aware of non-published Budgets

How:

Using the budget_published? helper method
 2018-01-08 23:02:18 +01:00
Bertocq
76e05d58b1 Return 404 status for non-published Budget access 
Why:

Non-admin users shouldn't be able to access, or know of the existence
of a non-published Budget.

How:

Raising an ActionController::RoutingError (404 error) to simulate the
same behaviour as accesing a non-existing Budget.

We could have used CanCanCan abilities for this but then an user could
be aware of existing but not published Budgets by trying different urls
 2018-01-08 22:59:20 +01:00
Bertocq
03f4fce2dd Add budget_published? helper method to BudgetHelper 
We need to check if the budget is in drafting phase to avoid showing
it to the users, unless the current user is an administrator.
 2018-01-08 22:56:47 +01:00
Bertocq
f9803ce9ca Add drafting phase to budget model & translations 2018-01-08 22:56:11 +01:00
Bertocq
d0937d7022 Add description_drafting column to budgets table 2018-01-08 22:55:37 +01:00
Bertocq
9739576e4e Add drafting phase trait to budget factory 2018-01-08 22:54:10 +01:00
Bertocq
1f0eb49ddc Increase budget model spec for drafting phase 2018-01-08 22:53:14 +01:00
Bertocq
63694b5bae Increase admin budget feature spec for drafting phase 2018-01-08 22:52:56 +01:00
Bertocq
2026f537e6 Add drafting phase scenario to budget feature spec for list & show checks 2018-01-08 22:51:01 +01:00
Bertocq
506293fc80 Move level two user creation to a shared let on budget feature 2018-01-08 19:59:14 +01:00
Bertocq
377a514128 Refactor commmon budget creation to a shared one at budget feature spec 2018-01-08 19:40:27 +01:00
Bertocq
4ca0a48df6 Reduce rubocop's Metrics/LineLength max to 100 chars by common agreement 2018-01-08 19:11:04 +01:00
Bertocq
03e1481fb1 Redirect admin to budget lists after editing a budget 2018-01-08 18:47:09 +01:00
Bertocq
53842ba919 Add Update scenario to admin budget feature spec 2018-01-08 18:46:50 +01:00
Raimond Garcia
05031dffa1 Merge pull request #2202 from wairbut-m2c/aperez-social-metatags 
Use 'image_url' properties to improve SEO for proposals & investments
 2018-01-08 18:33:07 +01:00
Bertocq
b1d685c4dc Add budget destroy texts for admin section 2018-01-08 18:21:46 +01:00
Bertocq
799b96cc40 Add destroy action to admin budget controller 2018-01-08 18:21:45 +01:00
Bertocq
dd3a0add2a Add destroy budget button to admin budget edit view 2018-01-08 17:48:46 +01:00
Bertocq
51e3d75c62 Add destroy scenario to budget section of admin panel 2018-01-08 17:48:06 +01:00
Raimond Garcia
bce0729a61 Merge pull request #1899 from xarlybovi/legislation-process-html-fixes 
Legislation process minor html fixes
 2018-01-08 16:00:26 +01:00
BertoCQ
c641aee605 Merge pull request #2273 from consul/depfu/update/uglifier-4.1.3 
Update uglifier: 4.1.2 → 4.1.3 (patch)
 2018-01-08 10:49:34 +01:00
depfu[bot]
205fd242d2 Update uglifier to version 4.1.3 2018-01-08 00:44:52 +01:00
Bertocq
581a6eb3ef Upgrade from factory_girl_rails to factory_bot_rails 
Guide at https://github.com/thoughtbot/factory_bot/blob/v4.9.0/UPGRADE_FROM_FACTORY_GIRL.md
 2018-01-07 23:32:37 +01:00
BertoCQ
fc1b4f4134 Merge pull request #2270 from consul/depfu/upgrade/uglifier-4.1.2 
Upgrade uglifier: 3.2.0 → 4.1.2 (major)
 2018-01-07 18:58:53 +01:00
Bertocq
4fc03fe395 Enable RSpec/VoidExpect cop without issues 2018-01-07 18:48:59 +01:00