consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,771 Commits 1 Branch 0 Tags
cb15a2e25b3db45815f23589797812884785b35c
Commit Graph

2691 Commits

Author SHA1 Message Date
Bertocq
3563b87399 Increase Budget Investment model spec for should_show_price & explantion methods 2018-01-10 01:14:23 +01:00
Bertocq
3bc683edce Increase budget factory with publishing_price trait & description value 2018-01-10 01:12:11 +01:00
Bertocq
cb1151f1d6 Increase Budget model spec for new publishing_prices phase 2018-01-10 01:04:32 +01:00
Bertocq
f350b99123 Remove deprecated investment test scenario for price explanation 2018-01-10 01:04:32 +01:00
Bertocq
1d6c3034cb Add test scenarios to check investment price showing rules 2018-01-10 01:04:31 +01:00
Angel Perez
9a0eca73d7 Fix: Deprecation warnings when running test suite (#2287) 2018-01-09 17:54:46 -04:00
Raúl Fuentes
29018e3062 changes made at the request of voodoorai2000 2018-01-09 13:08:03 +01:00
Raúl Fuentes
b3461b2051 final details 2018-01-09 12:45:30 +01:00
Raúl Fuentes
4f096a005d more style corrections 2018-01-09 12:45:30 +01:00
Raúl Fuentes
d7cc5d14c6 fixed test 2018-01-09 12:45:30 +01:00
Raúl Fuentes
56f4c3c3b9 added test to csv download and style corrections 2018-01-09 12:45:30 +01:00
María Checa
c27e6ab1d1 Merge pull request #2223 from wairbut-m2c/iagirre-prevent-edition-if-budget-final-phase 
Prevent edition of investments if budget is in the final phase
 2018-01-09 12:18:23 +01:00
María Checa
96859190be Merge pull request #2280 from consul/2277-budgets_new_form 
Budgets new form
 2018-01-09 11:55:10 +01:00
BertoCQ
6e96c8c057 Merge branch 'master' into feature/2275#destroy_budgets 2018-01-09 11:03:51 +01:00
BertoCQ
01c41c7cca Merge pull request #2284 from consul/feature/2276#admin_budget_edit_redirect 
Redirect admin to budget lists after edit
 2018-01-09 10:50:54 +01:00
BertoCQ
bcec5f779a Merge pull request #2285 from consul/feature/2278#budget_draft_phase 
Feature/2278#budget draft phase
 2018-01-09 10:50:40 +01:00
Bertocq
7c7f903ed0 Make customization engine spec less prone to flaky failures 2018-01-09 01:33:44 +01:00
Bertocq
2c3d8e9fd5 Avoid creating a budget in drafting phase to test results access 2018-01-09 01:16:09 +01:00
Bertocq
beee890285 Login as admin before visiting drafting budget on spec 2018-01-09 00:34:16 +01:00
Bertocq
0f5999fb8d Move admin creation into shared let on spec 2018-01-09 00:33:55 +01:00
María Checa
d8a6bb0f91 Changed tests 2018-01-09 00:09:50 +01:00
María Checa
5161988844 Removed external_url input 2018-01-08 23:22:46 +01:00
Bertocq
d0937d7022 Add description_drafting column to budgets table 2018-01-08 22:55:37 +01:00
Bertocq
9739576e4e Add drafting phase trait to budget factory 2018-01-08 22:54:10 +01:00
Bertocq
1f0eb49ddc Increase budget model spec for drafting phase 2018-01-08 22:53:14 +01:00
Bertocq
63694b5bae Increase admin budget feature spec for drafting phase 2018-01-08 22:52:56 +01:00
Bertocq
2026f537e6 Add drafting phase scenario to budget feature spec for list & show checks 2018-01-08 22:51:01 +01:00
Bertocq
506293fc80 Move level two user creation to a shared let on budget feature 2018-01-08 19:59:14 +01:00
Bertocq
377a514128 Refactor commmon budget creation to a shared one at budget feature spec 2018-01-08 19:40:27 +01:00
Bertocq
53842ba919 Add Update scenario to admin budget feature spec 2018-01-08 18:46:50 +01:00
Bertocq
51e3d75c62 Add destroy scenario to budget section of admin panel 2018-01-08 17:48:06 +01:00
Bertocq
581a6eb3ef Upgrade from factory_girl_rails to factory_bot_rails 
Guide at https://github.com/thoughtbot/factory_bot/blob/v4.9.0/UPGRADE_FROM_FACTORY_GIRL.md
 2018-01-07 23:32:37 +01:00
Bertocq
830bb37189 Enable RSpec/VerifiedDoubles cop, fix issues & stash one 
Can't figureout solution for offense at spec/models/verification/management/email_spec.rb
 so its stashed at .rubocop_todo.yml

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/VerifiedDoubles
 2018-01-07 18:47:19 +01:00
Bertocq
3762fd347e Enable RSpec/ScatteredSetup & fix issue 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ScatteredSetup
 2018-01-07 18:46:58 +01:00
Bertocq
f8fb32db76 Enable RSpec/ScatteredLet cop & fix issue 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ScatteredLet
 2018-01-07 18:46:58 +01:00
Bertocq
16eae689f9 Enable RSpec/RepeatedExample cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedExample
 2018-01-07 18:46:32 +01:00
Bertocq
4f6597b200 Enable RSpec/RepeatedDescription cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedDescription
 2018-01-07 17:45:34 +01:00
Bertocq
e89d081a47 Enable RSpec/PredicateMatcher cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/PredicateMatcher
 2018-01-07 17:42:59 +01:00
Bertocq
34bb9d65b1 Enable RSpec/NotToNot cop and fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
 2018-01-07 17:39:48 +01:00
Bertocq
c4aa2d7093 Enable RSpec/MessageExpectation cop & fix issues 
There was 34 `allow` occurences and 17 `expect` occurences, so to be consistent `allow` form was chosen.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MessageExpectation
 2018-01-07 16:36:18 +01:00
Bertocq
2d355ce938 Enable RSpec/LetSetup cop & fix issues 
Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetSetup
 2018-01-07 16:23:49 +01:00
Bertocq
3509bfe3e4 Remove spending proposals from sitemap and its test, deprecated model 2018-01-07 15:38:44 +01:00
Bertocq
cdbf0a77e1 Improve consul.json request spec, to avoid maintaining the setting features list up with seeds.rb content 2018-01-07 15:24:46 +01:00
BertoCQ
abfa203f5c Merge pull request #2249 from wairbut-m2c/aperez-sitemap-specs 
Specs for valid sitemap generation
 2018-01-07 11:24:43 +01:00
Bertocq
3e5b13ae4d Enable RSpec/LetBeforeExamples cop & fix issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetBeforeExamples
 2018-01-07 02:28:06 +01:00
Bertocq
eaf66e3ec1 Enable RSpec/IteratedExpectation cop and fix issues 
Suggested refactor is only available for `.to` and not for `.not_to` :(

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IteratedExpectation
 2018-01-07 02:24:24 +01:00
Bertocq
1441de5107 Enable RSpec/HookArgument cop and fix issues 
To be consistent about before/after arguments, as `:each` or `:example`
 are same and default scopes, best not to send an argument in those
 scenarios.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/HookArgument
 2018-01-07 02:07:19 +01:00
Bertocq
95733f52f2 Enable RSpec/FilePath cop and fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/FilePath
 2018-01-07 02:05:10 +01:00
Bertocq
97c5490995 Fix unnecesary spacing 2018-01-07 01:58:45 +01:00
Bertocq
f6aed3f9f1 Enable RSpec/ExpectActual cop and fix all issues 
Always use a variable and not a literal as `expect` argument

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectActual
 2018-01-07 01:55:38 +01:00