consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,771 Commits 1 Branch 0 Tags
cb15a2e25b3db45815f23589797812884785b35c
Commit Graph

2691 Commits

Author SHA1 Message Date
María Checa
0c84619cef Recovered LocalCensusRecord model validations 2017-07-19 19:49:16 +02:00
Senén Rodero Rodríguez
dec7d2d2b5 Add followable specific notices to follows controller actions and render notice on AJAX JS response. 2017-07-19 19:43:05 +02:00
Senén Rodero Rodríguez
c9a6630c94 Remove popup on follow buttons and remove uneeded code. 2017-07-19 17:51:45 +02:00
BertoCQ
ada3d1a667 Merge pull request #1756 from consul/feature/social_metatags_images 
Allow social image tags to be overwritten
 2017-07-18 13:37:45 +02:00
Bertocq
7b0d3093e5 Fix social media icon expectation 2017-07-18 12:04:35 +02:00
decabeza
2844c03e43 adds consistency on social media filenames 2017-07-18 11:40:19 +02:00
Bertocq
705ef19f6d Improvements on budget results view & table 2017-07-17 20:19:54 +02:00
María Checa
d576fd5951 Merge branch 'master' into 1725-census_local_copy_user_verification 2017-07-14 15:50:26 +02:00
María Checa
dccf221b47 New tests added for Census calls 
Added new spec files for `CensusCaller` and `LocalCensus` libraries.
 2017-07-14 15:39:49 +02:00
taitus
cef67c50a8 Increased test coverage to Following user public page. 2017-07-13 20:33:58 +02:00
rgarcia
c0d3ccaf46 Adds specs for loading first heading 2017-07-13 12:37:14 +02:00
BertoCQ
8d7a467397 Merge pull request #1746 from consul/rubocop/rails_fixes 
Rubocop fixes 🤖: Rails edition 💎🛤
 2017-07-11 22:28:55 +02:00
Bertocq
dd54be111d Fix follower notifications flaky spec 2017-07-11 18:08:58 +02:00
BertoCQ
204ea13c85 Merge branch 'master' into followable 2017-07-11 11:30:49 +02:00
Bertocq
5a358bce17 Fix all Rails/FilePath rubocop issues 2017-07-10 23:08:02 +02:00
Bertocq
3a54713ed0 Fix all Rails/DynamicFindBy rubocop issues 2017-07-10 23:04:27 +02:00
Bertocq
11a793d63f Hide incompatible and non-winner investments by default 2017-07-10 19:43:55 +02:00
Bertocq
741a342bb0 Restrict compatilibility edit on admin investment form 
Why:

* A non-winner but compatible investment shouldn't be marked as incompatible

How:

* Show incompatilibility checkbox only if investment is winner or incompatible
 2017-07-10 17:34:05 +02:00
Bertocq
2fba9de33b Don't display incompatible investment's table if empty 2017-07-10 17:12:28 +02:00
Bertocq
2b85deabec Recalculate heading winners on incompatibility change 
Why:

* We should recalculate winners also when an incompatible investment is flagged as compatible again

How:

* Removing the condition to recalculate that was checking only for a winner investment flagged as incompatible
* Extending the Budget::Result model spec to cover that new scenario
 2017-07-10 14:24:55 +02:00
Bertocq
69f4e1c683 Fix all rubocop Metrics/LineLength issues (140+) 2017-07-10 13:22:49 +02:00
Bertocq
824a672292 Fix spectations for localized milestone date 2017-07-09 16:44:34 +02:00
María Checa
feff9fff0f LocalCensus model created 2017-07-08 19:56:10 +02:00
Senén Rodero Rodríguez
112e0649bf Add missing proposal model specs to check new users_to_notify method. 2017-07-07 15:18:37 +02:00
Senén Rodero Rodríguez
4b2310c135 Move and refactor method from follow to user model to get user interests. Add specification to check the discard of duplicate interests. 2017-07-07 15:18:34 +02:00
taitus
e54e33f296 Use display in followable shared specs names when referring to DOM elements renderization. Add whitespace to proposal page. 2017-07-07 13:38:53 +02:00
taitus
97ee107157 Do not show flaggable and followable buttons on budgets_investment and proposals pages when user is not logged. 2017-07-07 13:38:52 +02:00
taitus
b29bf62f56 Send proposals notifications to followers. 2017-07-07 13:37:55 +02:00
taitus
35f7f11177 Add dependent destroy to followable. 2017-07-07 13:37:55 +02:00
Senén Rodero Rodríguez
1f22286e29 Create rspec shared examples to test followable features on any followable entity. 2017-07-07 13:34:54 +02:00
taitus
19820e4432 Add public interests validation and show interests on user profile 2017-07-07 13:34:43 +02:00
taitus
bce28afe36 Add followable to budget investment model. 2017-07-07 12:07:25 +02:00
Senén Rodero Rodríguez
84dbef16a4 Create followable concern, follow model. Add followable to proposal model. 2017-07-07 12:02:00 +02:00
BertoCQ
e990568895 Merge pull request #1721 from consul/feature/add_slugs_to_budget_related 
Add slugs to budget related
 2017-07-05 13:16:24 +02:00
BertoCQ
c439454ec7 Merge pull request #1722 from consul/chore/rubocop_cleaning 
Rubocop cleaning
 2017-07-05 13:12:09 +02:00
Bertocq
512059e021 Increase Budget, Heading and Group model specs to cover slug uniqueness 
Why:

* Slug must be unique among:
 1. Budget slug: among other budgets
 2. Group slug: among other groups from its budget
 3. Heading slug: among other headings from all the groups from its budget

How:

* Adding checks for all possible scenarios on each model specs
 2017-07-05 12:33:17 +02:00
Bertocq
29b58298db Fix Style/NegatedIf rubocop issue 2017-07-05 11:55:52 +02:00
Bertocq
39fa6ec2de Increase admin investment feature to cover selected checkbox 2017-07-04 23:47:11 +02:00
Bertocq
28970c6701 Fix all Style/UnneededInterpolation rubocop issues and remove from rubocop_tod 2017-07-04 22:44:08 +02:00
Bertocq
73e0a5a88d Add to Budget Budget::Heading Budget::Group specs the sluggable shared example 
Why:

* Those classes have a slug attribute that needs to be filled

How:

* Just adding the shared example to Budget model spec, and creating the model spec file for Heading and Group to include it as well
 2017-07-04 18:40:54 +02:00
Bertocq
148b58f71d Add sluggable shared example for Sluggable concern 
Why:

* We need certain models that use a Sluggable to generate a slug based on name attribute on save

How:

* Creating a shared example that knows how to create a factory of the described class
* Checking in it that new objects of the described class get the correct slug
 2017-07-04 18:40:01 +02:00
Raimond Garcia
e7e5b3c4a3 Merge branch 'master' into 1647-locale_site_customization 2017-07-04 12:11:07 +02:00
Bertocq
10b17eae8f Update user budget's result feature spec to include incompatible ones 2017-07-04 02:14:54 +02:00
Bertocq
9c157e25bb Increase Admin Budget Investment edit to cover new incompatible checkbox edit 
Why:

* Admins can now mark/unmark a investment as incompatible

How:

* With a new checkbox in the edit form and a section at the investment details view to show the current status
 2017-07-04 01:34:22 +02:00
Bertocq
21864f3fb5 Increase Budget Result spec to check incompatible investments can't be winners 
Why:

* A incompatible investment can't be chosen as a winner
* When a winner investment is marked as incompatible, winnersmust be recalculated and it can't be a winner

How:

* Increasing existing scenarios to include a incompatible investment
* Adding a new scenario where a winner investment gets flagged as incompatible
 2017-07-03 15:59:01 +02:00
Bertocq
e8c6c6ad8c Add incompatible boolean column to Budget Investments table and factory 2017-07-03 15:40:34 +02:00
María Checa
ecaf7192c5 Merge branch '1647-locale_site_customization' of https://github.com/MariaCheca/consul into 1647-locale_site_customization 2017-07-03 12:59:09 +02:00
María Checa
da2b55942a Added specs for custom pages 
New test to check pages are rendered in their matching locale.
 2017-07-03 12:53:12 +02:00
María Checa
36d51b380b Merge branch 'master' into 1647-locale_site_customization 2017-07-02 23:19:40 +02:00
María Checa
dca346bd4c Fixed tests 
Added new custom pages attribute to tests to make them run properly.
 2017-07-02 22:13:40 +02:00