Senén Rodero Rodríguez
0fbffdc73e
Fix abilities definition and related specs
2017-08-25 18:34:53 +02:00
Senén Rodero Rodríguez
c92827e89e
Add abilities to documentable authors and admins to create and destroy documents.
2017-08-25 17:27:37 +02:00
Senén Rodero Rodríguez
a141c82e33
Create new polymorphic model Document.
2017-08-25 17:27:37 +02:00
Bertocq
ef81c277a0
Remove spending proposal specs, deprecated feature with flaky tests
2017-08-02 12:08:50 +02:00
Bertocq
7d406cae76
Rubocop autocorrections
2017-07-25 13:01:03 +02:00
Bertocq
361e0efe00
Remove Poll Recount model and all usages
2017-07-23 23:29:24 +02:00
BertoCQ
204ea13c85
Merge branch 'master' into followable
2017-07-11 11:30:49 +02:00
Bertocq
2b85deabec
Recalculate heading winners on incompatibility change
...
Why:
* We should recalculate winners also when an incompatible investment is flagged as compatible again
How:
* Removing the condition to recalculate that was checking only for a winner investment flagged as incompatible
* Extending the Budget::Result model spec to cover that new scenario
2017-07-10 14:24:55 +02:00
Bertocq
69f4e1c683
Fix all rubocop Metrics/LineLength issues (140+)
2017-07-10 13:22:49 +02:00
Senén Rodero Rodríguez
112e0649bf
Add missing proposal model specs to check new users_to_notify method.
2017-07-07 15:18:37 +02:00
Senén Rodero Rodríguez
4b2310c135
Move and refactor method from follow to user model to get user interests. Add specification to check the discard of duplicate interests.
2017-07-07 15:18:34 +02:00
taitus
e54e33f296
Use display in followable shared specs names when referring to DOM elements renderization. Add whitespace to proposal page.
2017-07-07 13:38:53 +02:00
taitus
19820e4432
Add public interests validation and show interests on user profile
2017-07-07 13:34:43 +02:00
taitus
bce28afe36
Add followable to budget investment model.
2017-07-07 12:07:25 +02:00
Senén Rodero Rodríguez
84dbef16a4
Create followable concern, follow model. Add followable to proposal model.
2017-07-07 12:02:00 +02:00
BertoCQ
e990568895
Merge pull request #1721 from consul/feature/add_slugs_to_budget_related
...
Add slugs to budget related
2017-07-05 13:16:24 +02:00
Bertocq
512059e021
Increase Budget, Heading and Group model specs to cover slug uniqueness
...
Why:
* Slug must be unique among:
1. Budget slug: among other budgets
2. Group slug: among other groups from its budget
3. Heading slug: among other headings from all the groups from its budget
How:
* Adding checks for all possible scenarios on each model specs
2017-07-05 12:33:17 +02:00
Bertocq
28970c6701
Fix all Style/UnneededInterpolation rubocop issues and remove from rubocop_tod
2017-07-04 22:44:08 +02:00
Bertocq
73e0a5a88d
Add to Budget Budget::Heading Budget::Group specs the sluggable shared example
...
Why:
* Those classes have a slug attribute that needs to be filled
How:
* Just adding the shared example to Budget model spec, and creating the model spec file for Heading and Group to include it as well
2017-07-04 18:40:54 +02:00
Bertocq
148b58f71d
Add sluggable shared example for Sluggable concern
...
Why:
* We need certain models that use a Sluggable to generate a slug based on name attribute on save
How:
* Creating a shared example that knows how to create a factory of the described class
* Checking in it that new objects of the described class get the correct slug
2017-07-04 18:40:01 +02:00
Bertocq
21864f3fb5
Increase Budget Result spec to check incompatible investments can't be winners
...
Why:
* A incompatible investment can't be chosen as a winner
* When a winner investment is marked as incompatible, winnersmust be recalculated and it can't be a winner
How:
* Increasing existing scenarios to include a incompatible investment
* Adding a new scenario where a winner investment gets flagged as incompatible
2017-07-03 15:59:01 +02:00
Raimond Garcia
22d28d9c79
Merge branch 'master' into issue#1575-tag-administration
2017-06-29 19:09:54 +02:00
Bertocq
c9bc028524
Remove all unnecesary extra spacing and Layout/ExtraSpacing list from rubocop file
2017-06-28 14:12:51 +02:00
Bertocq
775da2d581
Remove all Layout/EmptyLines issues on code and file list from rubocop_todo
2017-06-28 14:12:51 +02:00
Bertocq
2fa92937d2
Fix all Style/BracesAroundHashParameters rubocop issues and remove them from rubocop_todo list
2017-06-28 14:12:51 +02:00
Bertocq
1c8e039862
Fix all Layout/SpaceInsideParens rubocop issues and remove files from rubocop_todo list
2017-06-26 18:06:01 +02:00
Bertocq
f6fe9cc7d2
Fix all Layout/SpaceAroundOperators rubocop issues and remove file list from rubocop_todo list
2017-06-26 18:04:20 +02:00
Bertocq
e6dd33bd66
Fix all Layout/SpaceAfterComma issues and remove from rubocop_todo list
2017-06-26 17:57:53 +02:00
Bertocq
6562d8b9d8
Fix all Layout/SpaceBeforeFirstArg rubocop issues and remove from rubocop_todo list
2017-06-26 17:57:53 +02:00
Bertocq
80bcf38dc5
Fix all Layout/TrailingWhitespace rubocop issues and remove from rubocop_todo list
2017-06-26 17:57:53 +02:00
Raimond Garcia
6e60f5acde
Merge pull request #1680 from consul/chore/small_rubocop_cleanup
...
Chore/small rubocop cleanup
2017-06-26 17:42:10 +02:00
Bertocq
d759aca522
Fix all Rails/TimeZone rubocop issues and remove files from rubocop_todo list
2017-06-25 15:46:46 +02:00
Bertocq
6529e37ae8
Fix all rubocop Rails/PluralizationGrammar issues and remove the file list form rubocop_todo file
2017-06-25 15:46:46 +02:00
taitus
2fe663ef8f
Fix syntax and indentation errors.
2017-06-24 22:38:48 +02:00
taitus
f220952883
Add CRUD Milestone on Admin::BudgetInvestment. Rename Checkpoint to Milestone.
2017-06-24 22:38:48 +02:00
taitus
beeb5412d7
New Checkpoint model. Update factories. Model specs.
2017-06-24 22:38:48 +02:00
Eduardo Martinez Echevarria
a600dcbb36
Replace category factory in tags with a trait
2017-06-23 17:34:55 +02:00
Raimond Garcia
09a2f2b795
Merge pull request #1660 from consul/fix/rubocop_issues
...
Fix some Rubocop issues
2017-06-20 21:49:59 +02:00
Juanjo Bazán
315c57929a
allows managers to create users without email
...
allows managers to create users without email
hides email preferences from account page for email-less users
prevents email delivery to users with no email
adds spec for user creation from management
adds specs for user's email requirement
adds spec for no deliveries if no email
2017-06-19 13:02:48 +02:00
Bertocq
b104765ddc
Rubocop autocorrect Lint/BlockAlignment and remove from rubocop_todo list
2017-06-19 10:45:18 +02:00
Bertocq
d1a050fa4d
Fix shared example group rspec warning because of file name ended with _spec
2017-06-16 01:28:43 +02:00
Juanjo Bazán
9ab0f9cf8b
Merge branch 'master' into amiedes-api-dev-PRs-2
2017-06-14 12:46:58 +02:00
Raimond Garcia
ae82a563d6
Merge pull request #1651 from consul/fix/direct_message_today_scope
...
Fix DirectMessage today scope
2017-06-14 11:42:54 +02:00
Bertocq
cc0146e372
Use Time in utc on direct message specs when changing created_at directly
2017-06-14 01:17:32 +02:00
Bertocq
c18d1b6e8f
Check new enabled? logic on both Legislation::Process Phase and Publication classes
2017-06-14 00:21:08 +02:00
Bertocq
990437dc40
Remove no longer used active/show/open _phase helper methods from Legislation Process, and specs
2017-06-13 22:04:36 +02:00
Bertocq
12dc7a4790
Add specs for Legislation::Process Phase and Publication enabled?/started?/open? methods
2017-06-13 22:04:36 +02:00
Bertocq
e55328caf4
Rename legislation process final_version_publication phase name to more descriptive result_publication
2017-06-13 22:04:36 +02:00
Bertocq
0c27f1ffde
Rename Legislation Process final_publication_date field to more descriptive result_publication_date
2017-06-13 22:04:36 +02:00
kikito
1701111bf5
Merge branch 'api-dev-PRs' of https://github.com/amiedes/consul into amiedes-api-dev-PRs-2
2017-06-13 12:07:28 +02:00
