consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
15,211 Commits 1 Branch 0 Tags
b8e352145c9e3662dc0ec8e32944848186494de3
Commit Graph

15211 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Senén Rodero Rodríguez
264b3f0f82 Simpler calls to *_translatable shared specs 
Enable translations interface setting inside shared specs when needed.

Co-Authored-By: javierm <javim@elretirao.net>
 2019-06-27 09:20:25 +02:00
Senén Rodero Rodríguez
73563e5d86 Display needed translations when translation interface is disabled 
Display only current locale translation when translation interface is disabled.

Co-Authored-By: javierm <javim@elretirao.net>
 2019-06-27 09:20:25 +02:00
Senén Rodero Rodríguez
b5663a7c17 Add translation interface setting values 
* Disable translation interface by default
 * Also add rake task to enable translations interface through rake
   command
 2019-06-27 09:20:25 +02:00
Senén Rodero Rodríguez
7e3f0b5c18 Add translation interface feature setting 
Allow to enable/disable translation interface at frontend
 2019-06-27 09:20:25 +02:00
Senén Rodero Rodríguez
3176be43d9 Rename "translatable" shared example to "edit_translatable" 
Also rename all specs calls
 2019-06-27 09:20:25 +02:00
Senén Rodero Rodríguez
64bfab9c9c Extract spec methods to commons module to avoid code duplication 
Because "translatable" and "new_translatable" shared examples needs same methods to manipulate translations.
 2019-06-27 09:20:25 +02:00
Senén Rodero Rodríguez
d0bf0f8857 Add "new_translatable" shared example to proposals feature specs 2019-06-27 09:20:25 +02:00
Senén Rodero Rodríguez
1bcbcf4975 Add "new_translatable" shared example to debates feature specs 2019-06-27 09:20:25 +02:00
Senén Rodero Rodríguez
1abcd95441 Add "new_translatable" shared example to budget investments feature specs 2019-06-27 09:20:25 +02:00
Senén Rodero Rodríguez
673fecf92a Add "new_translatable" shared example to check creation of translatable records 
The existing shared example 'translatable' only works for edit actions.
This shared example allow us to check how translations behaves at new
resource pages.

Now this shared specs only works with Proposals, Budget::Investments and
Debates.
 2019-06-27 09:20:24 +02:00
taitus
44ef1ce5e1 Fix houncibot parse error 
Add missing quotes.

Notification Error:
warning: 2.6.0-dev-compliant syntax, but you are running 2.6.1.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
2 error(s) were found in ERB files
expected attribute value after '=' (at >)
 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
1565a5a71d Fix most of Hound offenses 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
522b1c9ef7 Add budget investment translations to dev_seeds 
Update budget investments development seeds with translations for all avaialble locales.
 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
f116477d6d Enable soft_deletion of Budget::Investment::Translations 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
ef786d0658 Fix hidden budget investments restore feature 
Add recursive restore option to restore all soft deleted relations.
 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
e8f53cb8b7 Add translations to budget investments pg_search_scope 
Some Budget::Investment attributes are now translatable so we need to
include all existing translations on pg_search model scope.
 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
9a459070e9 Fix budget investment suggest feature 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
661ca5a568 Add budget investments translation interface 
* Adapt translatable spec helper method to work with budget investments
* Remove old attributes from strong parameters
* Add missing locales to admin.yml and budgets.yml
* Change SpendingProposal.title_max_length and
  SpendingProposal.description_max_lenght to Budget::Investment methods
* Add budget investment translatable attribute translations
 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
5eb5f02cbe Fix budget investment specs 
After adding investment translatable fields to forms, they will be
generated with nested translations names and ids so we can no longer
use standard id locator.

Using input label text to fill in fields works with both types of forms.
 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
88ce8d7990 Add sanitization shared spec to budget investment 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
eb2e402a92 Fix budget investments sorting by title 
As we cannot order budget investments by any translatable field through
AR queries we are doing the same using ruby Array sort method and doing
array pagination manually with Kaminari 'paginate_array' helper method.
 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
bb2ee6dd3c Fix search_by_title_or_id method 
Results were not including records without translations for current
locale (I18n.locale). Now we search for given title against all
translation fallbacks for current locale.
 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
66f885f8e4 Rename deprecated attributes in budget investments 
To avoid deprecation warning thrown by Globalize after gem update. We
are going to keep these attributes with different names until next
release when we will be able to destroy them.
 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
eefb9ca4f7 Add budget investment translations 
Also fix sort_by_title method [1]

[1] Use ruby sort instead of active record order scope because Globalize
does not provide a way to search over all available fallbacks when
translation for current locale does not exist.
 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
8c2f1b894d Add controller concern to initialize Globalize fallbacks 
Ensure to initialize all requests including this concern into all
application base controllers.
 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
0011a0b4c7 Move Translation class inside Budget 
The reason to move Translation class is explained here [1]

[1] 106649a8a5
 2019-06-27 09:20:24 +02:00
Senén Rodero Rodríguez
3b03e583f9 Move Translation class inside Budget::Phase 
The reason to move Translation class is explained here [1]

[1] 106649a8a5
 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
27f6c8804f Move Translation class inside Budget::Heading 
The reason to move Translation class is explained here [1]

[1] 106649a8a5
 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
c2f393276a Move Translation class inside Budget::Group 
The reason to move Translation class is explained here [1]

[1] 106649a8a5
 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
da1c5fdb01 Remove unneded before validation callbacks 
After globalize gem update there is no need to keep this monkey patch.

More information here [1]

[1] 3075c89b70
 2019-06-27 09:19:37 +02:00
taitus
4068ef29ee Fix hidden budget investments restore feature 
Add recursive restore option to restore all soft deleted relations.
 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
7c137faf53 Fix broken spec 
Use existing I18n translations in broken spec.
 2019-06-27 09:19:37 +02:00
taitus
95f848f021 Fix specs after rebase with translations branch 
- Fix spec spec/features/management/proposals_spec.rb:24 adding single quotes.
- Remove spec related with 'proposal improvement info link' as master branch.
- Fix proposal rake task (now proposals have translations). We put the 'validate: false' to keep the existing html tags in the  proposal's description. Without the sanitizable module deleting them.
 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
4236a3a388 Move label translations to activerecord.yml files 
Moved only :es and :en translations from general.yml to activerecord.yml
and use them in related forms.
 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
5dc0f7f054 Add :except and :only options to translatable_params method 
Allow to choose among resource model translatable attributes.
 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
8103a16031 Add proposals translations to dev_seeds 
Update proposal development seeds with translations for all avaialble
locales.
 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
f70adbe23a Move label translations to activerecord.yml 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
78055555cf Add debates translations to dev_seeds 
Update debates development seeds with translations for all avaialble
locales.
 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
2079706845 Enable soft deletion of Proposal::Translations 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
fb4d4c6c5a Fix hidden proposals restore feature 
Add recursive restore option to restore all soft deleted relations.
 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
f572d5b579 Add translations to proposal pg_search_scope 
Some Proposal attributes are now translatable so we need to include all
existing translations on pg_search scope.
 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
0f4fcfb20e Fix proposals suggest feature 
Now we need one suggest placeholder for each translation. This also
fixes invalid usage of id HTML attribute.
 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
bd3bb72370 Add proposals translation interface 
* Convert proposal form into translatable one.
 * Adapt translatable shared spec to define an owner when running at
   frontend feature specs.
 * Remove old attributes from strong parameters.
 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
4ce006ec96 Enable soft deletion of Comment::Translations 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
16b3ec6e5f Rename deprecated attributes from comments 
To avoid deprecation warning thrown by Globalize after gem update.
 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
158af0217d Add comments translations 
Co-Authored-By: Sebastia <sebastia.roig@gmail.com>
 2019-06-27 09:19:37 +02:00
Senén Rodero Rodríguez
096a9f6bb8 Enable soft deletion of Debate::Translations 2019-06-27 09:19:36 +02:00
Senén Rodero Rodríguez
03375ae621 Fix debates restore feature 
Add recursive restore option to restore all soft deleted relations.
 2019-06-27 09:19:36 +02:00
Senén Rodero Rodríguez
ed750f6cce Move private method to a more reusable location 
This method will be used by any translatable model that uses pg_search
feature so it's better to have it within globalizable model concern so
all translatable models can use it.
 2019-06-27 09:19:36 +02:00
Senén Rodero Rodríguez
036a3d7636 Add translations to debate pg_search_scope 
Some Debate attributes are now translatable so we need to include all
existing translations on pg_search scope.
 2019-06-27 09:19:36 +02:00