consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
11,671 Commits 1 Branch 0 Tags
b463fc40b55173f76871aba2f814d16eba700b7b
Commit Graph

2349 Commits

Author SHA1 Message Date
Bertocq
ca3d759d9f Refactor Budget publishing prices phases constant to Budget::Phase model 2018-01-16 12:18:13 +01:00
Bertocq
66691b644a Refactor Budget::PHASES constant to Budget::Phase::PHASE_KINDS 2018-01-16 12:18:13 +01:00
rgarcia
34e0c23bb3 Fix valuators authorization spec 
This spec used to pass, because even though there were no budgets, as
Budget.current returned an array, it gracefully handled situations
without budgets

Now we assume that there can only be a single current budget, and so
calling any method of budget will raise an exception unless there is a
current budget present

Valuators should not access this page when there is no budget present,
however it might be wise to create an issue to cover this case, just in
case
 2018-01-15 22:02:05 +01:00
rgarcia
5086314bee Display only current budget for Valuators 
Before we could have multiple current budgets, as we now only have one
current_budget, some specs broke.

As there is no need to display multiple budgets to Valuators, only the
current budget is necessary, we can remove arrays and assume that only
a single budget, the current budget, is displayed to Valuators
 2018-01-15 22:02:04 +01:00
rgarcia
01ef439053 Display only current budget to Managers printing investments 
In the specs, some investment were missing a heading_id, thus creating
another unexpected budget

By explicitly setting the heading_id we can control better which
budgets are created in each test
 2018-01-15 22:02:04 +01:00
BertoCQ
3d5bf04829 Merge pull request #2311 from consul/2299-budget_investments_related_content 
Budget investments related content
 2018-01-15 20:02:34 +01:00
BertoCQ
61f52b3483 Merge pull request #2293 from wairbut-m2c/aperez-fix-deprecation-warnings 
Fix for test suite deprecations warnings
 2018-01-15 18:23:42 +01:00
María Checa
b2054ac531 Improved relationable tests for budget investments 2018-01-12 18:26:37 +01:00
decabeza
40d32f3e16 Merge branch 'master' into budgets-ui 2018-01-11 17:05:28 +01:00
Raimond Garcia
b0bd7792be Merge pull request #1917 from wairbut-m2c/iagirre-admin-budget-heading-action 
Actions for budgets' headings added. Edit headings, delete headings i…
 2018-01-11 13:47:27 +01:00
Bertocq
2f27a86034 Replace deprecated capybara only_path option for ignore_query 2018-01-11 00:07:56 +01:00
BertoCQ
71e045fece Merge pull request #2296 from consul/feature/2278#budget_price_show_phase 
New Budget's phase to publish investment prices
 2018-01-10 23:46:41 +01:00
Bertocq
db051beabc Fix to_not to not_to on spec 2018-01-10 22:43:52 +01:00
iagirre
0e11e21b2a Merged with master and solved conflicts 2018-01-10 13:23:39 +01:00
María Checa
02f7e423fe Improved tests 2018-01-10 13:03:52 +01:00
decabeza
3b6fa6cbb4 fixes specs 2018-01-10 11:36:33 +01:00
Bertocq
f350b99123 Remove deprecated investment test scenario for price explanation 2018-01-10 01:04:32 +01:00
Bertocq
1d6c3034cb Add test scenarios to check investment price showing rules 2018-01-10 01:04:31 +01:00
Angel Perez
9a0eca73d7 Fix: Deprecation warnings when running test suite (#2287) 2018-01-09 17:54:46 -04:00
Raúl Fuentes
29018e3062 changes made at the request of voodoorai2000 2018-01-09 13:08:03 +01:00
Raúl Fuentes
b3461b2051 final details 2018-01-09 12:45:30 +01:00
Raúl Fuentes
4f096a005d more style corrections 2018-01-09 12:45:30 +01:00
Raúl Fuentes
d7cc5d14c6 fixed test 2018-01-09 12:45:30 +01:00
Raúl Fuentes
56f4c3c3b9 added test to csv download and style corrections 2018-01-09 12:45:30 +01:00
María Checa
c27e6ab1d1 Merge pull request #2223 from wairbut-m2c/iagirre-prevent-edition-if-budget-final-phase 
Prevent edition of investments if budget is in the final phase
 2018-01-09 12:18:23 +01:00
María Checa
96859190be Merge pull request #2280 from consul/2277-budgets_new_form 
Budgets new form
 2018-01-09 11:55:10 +01:00
BertoCQ
6e96c8c057 Merge branch 'master' into feature/2275#destroy_budgets 2018-01-09 11:03:51 +01:00
BertoCQ
01c41c7cca Merge pull request #2284 from consul/feature/2276#admin_budget_edit_redirect 
Redirect admin to budget lists after edit
 2018-01-09 10:50:54 +01:00
Bertocq
2c3d8e9fd5 Avoid creating a budget in drafting phase to test results access 2018-01-09 01:16:09 +01:00
Bertocq
beee890285 Login as admin before visiting drafting budget on spec 2018-01-09 00:34:16 +01:00
Bertocq
0f5999fb8d Move admin creation into shared let on spec 2018-01-09 00:33:55 +01:00
María Checa
d8a6bb0f91 Changed tests 2018-01-09 00:09:50 +01:00
María Checa
5161988844 Removed external_url input 2018-01-08 23:22:46 +01:00
Bertocq
63694b5bae Increase admin budget feature spec for drafting phase 2018-01-08 22:52:56 +01:00
Bertocq
2026f537e6 Add drafting phase scenario to budget feature spec for list & show checks 2018-01-08 22:51:01 +01:00
Bertocq
506293fc80 Move level two user creation to a shared let on budget feature 2018-01-08 19:59:14 +01:00
Bertocq
377a514128 Refactor commmon budget creation to a shared one at budget feature spec 2018-01-08 19:40:27 +01:00
Bertocq
53842ba919 Add Update scenario to admin budget feature spec 2018-01-08 18:46:50 +01:00
Bertocq
51e3d75c62 Add destroy scenario to budget section of admin panel 2018-01-08 17:48:06 +01:00
Bertocq
16eae689f9 Enable RSpec/RepeatedExample cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedExample
 2018-01-07 18:46:32 +01:00
Bertocq
4f6597b200 Enable RSpec/RepeatedDescription cop & fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/RepeatedDescription
 2018-01-07 17:45:34 +01:00
Bertocq
34bb9d65b1 Enable RSpec/NotToNot cop and fix all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
 2018-01-07 17:39:48 +01:00
Bertocq
c4aa2d7093 Enable RSpec/MessageExpectation cop & fix issues 
There was 34 `allow` occurences and 17 `expect` occurences, so to be consistent `allow` form was chosen.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MessageExpectation
 2018-01-07 16:36:18 +01:00
Bertocq
2d355ce938 Enable RSpec/LetSetup cop & fix issues 
Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetSetup
 2018-01-07 16:23:49 +01:00
Bertocq
3e5b13ae4d Enable RSpec/LetBeforeExamples cop & fix issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetBeforeExamples
 2018-01-07 02:28:06 +01:00
Bertocq
eaf66e3ec1 Enable RSpec/IteratedExpectation cop and fix issues 
Suggested refactor is only available for `.to` and not for `.not_to` :(

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/IteratedExpectation
 2018-01-07 02:24:24 +01:00
Bertocq
1441de5107 Enable RSpec/HookArgument cop and fix issues 
To be consistent about before/after arguments, as `:each` or `:example`
 are same and default scopes, best not to send an argument in those
 scenarios.

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/HookArgument
 2018-01-07 02:07:19 +01:00
Bertocq
97c5490995 Fix unnecesary spacing 2018-01-07 01:58:45 +01:00
Bertocq
f6aed3f9f1 Enable RSpec/ExpectActual cop and fix all issues 
Always use a variable and not a literal as `expect` argument

Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectActual
 2018-01-07 01:55:38 +01:00
Bertocq
fa017b664f Enables RSpec/EmptyLineAfterFinalLet cop & fixes all issues 
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/EmptyLineAfterFinalLet
 2018-01-07 00:49:37 +01:00