Commit Graph

6 Commits

Author SHA1 Message Date
Javi Martín
13481fdf32 Use Ubuntu 24.04 in our workflows
This is what github actions currently uses when using ubuntu-latest, and
what we recommend for new Consul Democracy installations.
2024-10-14 14:02:28 +02:00
Javi Martín
26ebe619e3 Use a specific version of Ubuntu in workflows
Using ubuntu-latest might result in incompatibilities when this image
changes to a different version of Ubuntu. For example, the Ubuntu 24.04
image no longer includes imagemagick, meaning that we'll have to install
it manually when using Ubuntu 24.04.
2024-10-14 13:47:30 +02:00
Javi Martín
e2a8b3caae Fix linters workflow on Dependabot pull requests
The name of the actor is not dependabot but dependabot[bot] [1].

[1] https://docs.github.com/en/code-security/dependabot/working-with-dependabot/automating-dependabot-with-github-actions#responding-to-events
2024-06-18 19:54:06 +02:00
Javi Martín
995f7036de Run every linter separately in Github Actions
The main reason for this change is that Pronto doesn't run in pull
requests opened by external contributors, and we haven't found how to
fix this issue.

Another reason is that Pronto only detects issues in the lines where the
changes are done, but sometimes we introduce issues related to other
lines and those aren't detected by Pronto. Also, when adding or changing
Rubocop rules, or when we update Rubocop, Pronto doesn't check whether
those rules are applied in every Ruby and ERB file, and we sometimes
forget to do so (particularly in ERB files).

So, from now, the linters will check all the code in every pull request.

Note we're now excluding the `vendor` folder in our linters because the
`setup-ruby` action actions generates a `vendor/bundle/` folder with all
our gem dependencies, and we don't want to check those files.
2024-06-18 19:11:55 +02:00
Javi Martín
61a6ba26b1 Simplify dependabot condition in pronto workflow
We had the `*` because, in the past, pull request could be opened by
either dependabot or dependabot-bot. That's no longer the case since we
started using dependabot v2.
2024-06-18 19:01:31 +02:00
Javi Martín
e646689535 Rename linters workflow to pronto
We're going to add a linters workflow, so the name would be confusing.
2024-06-18 18:27:32 +02:00