Javi Martín
da121ebc53
Remove redundant setting resets in after blocks
...
Settings are stored in the database, and so any changes to the settings
done during the tests are automatically rolled back between one test and
the next one.
There were also a few places where we weren't using an `after` block but
changing the setting at the end of the test.
2019-09-23 13:47:45 +02:00
Javi Martín
58ba517717
Apply RSpec/ExampleWording rubocop rule
2019-09-10 21:43:39 +02:00
Javi Martín
f9ed186909
Add rubocop spacing rules
...
We were following these rules in most places; we just didn't define them
anywhere.
2019-09-10 21:04:56 +02:00
Javi Martín
e252d82cdb
Apply IndentationWidth rubocop rule
2019-09-10 20:02:15 +02:00
Senén Rodero Rodríguez
02be0c61f9
Add proposal translations
...
Adapt retire form to include needed translations and move validations
from controller to model.
Also change sanitizable concern to sanitize not marked for destruction
translations.
2019-06-27 09:19:36 +02:00
Senén Rodero Rodríguez
5881f8241e
Sanitization shared spec
...
Create sanitization shared spec to check sanitizable concern features
in all translatable models.
2019-06-27 09:19:36 +02:00
Senén Rodero Rodríguez
db38a87205
Add specs to check how paranoia and globalize work together
...
Create shared model spec to test paranoia and globalize behavior on
globalizable and paranoid models.
2019-06-27 09:19:35 +02:00
Julian Herrero
8e0bbf54f6
Replace harcoded images and documents settings
2019-06-04 11:50:09 +02:00
Julian Herrero
31ac8b7f55
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
Angel Perez
bdda397bf1
Use new RSpec stub syntax to fix deprecation warnings
2018-09-10 11:41:20 -04:00
Bertocq
44aeb7528d
Fix line lenght issues on spec files
2018-02-15 23:21:03 +01:00
Bertocq
34bb9d65b1
Enable RSpec/NotToNot cop and fix all issues
...
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
2018-01-07 17:39:48 +01:00
Bertocq
1441de5107
Enable RSpec/HookArgument cop and fix issues
...
To be consistent about before/after arguments, as `:each` or `:example`
are same and default scopes, best not to send an argument in those
scenarios.
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/HookArgument
2018-01-07 02:07:19 +01:00
Bertocq
ed16a78f42
Enables RSpec/ExampleWording and fixes all issues
...
Both avoiding 'should' and repiting 'it' on the tests description
improves reading them and also makes all descriptions consistent.
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
2018-01-07 01:03:45 +01:00
Bertocq
93e6a7e6aa
Fix indentation & spaces on map validation files
2017-12-25 23:34:18 +01:00
rgarcia
7889efd6ee
Fix map location update
...
When editing the map of a proposal or investment(the mappable) the
updated_at attribute of the mappable was not been updated and so the
map still displayed the old location after updating it
2017-12-20 12:43:49 +01:00
rgarcia
0152b6301c
adds specs
2017-12-19 20:36:10 +01:00
Bertocq
70f2ee0cf5
Fix Time.now usage to Time.current to include zone
2017-12-16 17:59:16 +01:00
rgarcia
2b52d26d82
refactors notifications into concerns and shared examples
2017-12-14 16:15:30 +01:00
Senén Rodero Rodríguez
92f66a6db9
Fix rpspec styub deprecated syntax
2017-09-26 13:57:14 +02:00
Senén Rodero Rodríguez
824dd26d5a
User new direct uploads controllers action on documentable. Skipped spec.
2017-09-26 13:55:51 +02:00
Senén Rodero Rodríguez
c6dabedb4a
Add missing image model spec. Add shared specs to check image validations at any imageable model
2017-09-26 13:55:03 +02:00
Senén Rodero Rodríguez
6f71da07ee
Duplicate documentable code and rename for imageable
2017-09-26 13:55:03 +02:00
Senén Rodero Rodríguez
8e91bbe5b5
Fix document validations specs
2017-08-25 18:34:53 +02:00
Senén Rodero Rodríguez
92e8468e89
Use documentables helper method within specs and document model.
2017-08-25 18:34:50 +02:00
Senén Rodero Rodríguez
3a7c9d9f83
Add documentables helper
2017-08-25 18:34:49 +02:00
Senén Rodero Rodríguez
38d4d59241
Add arguments to documentable concern to make it configurable for any recipient model.
2017-08-25 17:27:37 +02:00
Senén Rodero Rodríguez
34d06dad04
Add document model validations and model shared specs.
2017-08-25 17:27:37 +02:00
Senén Rodero Rodríguez
a141c82e33
Create new polymorphic model Document.
2017-08-25 17:27:37 +02:00
