Javi Martín
fe5b45ed18
Remove unnecessary poll creating assignments
...
The factory creating assignments automatically assigns a poll to it, so
we don't use the poll for anything else, there's no need to explicitely
create it.
2019-09-24 19:48:22 +02:00
Javi Martín
cb2069858c
Remove unnecessary code
...
It looks like these variables were left by accident. The Ruby
interpreter was giving us warnings about unused variables.
2019-09-24 18:49:40 +02:00
Javi Martín
ffc50246c2
Apply explict RSpec/DescribedClass rubocop rule
...
We settled on using this style in commit 4cbe81a1
2019-09-23 16:51:00 +02:00
Javi Martín
f9ed186909
Add rubocop spacing rules
...
We were following these rules in most places; we just didn't define them
anywhere.
2019-09-10 21:04:56 +02:00
Julian Herrero
31ac8b7f55
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
Bertocq
34bb9d65b1
Enable RSpec/NotToNot cop and fix all issues
...
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
2018-01-07 17:39:48 +01:00
Bertocq
ed16a78f42
Enables RSpec/ExampleWording and fixes all issues
...
Both avoiding 'should' and repiting 'it' on the tests description
improves reading them and also makes all descriptions consistent.
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
2018-01-07 01:03:45 +01:00
Bertocq
265d4d0967
Enables RSpec/DescribedClass cop & fixes all issues
...
Autocorrection for existing issues, and stashing at .rubocop_todo.yml
the false positives
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribedClass
2018-01-07 00:38:19 +01:00
Bertocq
6ec6f64675
Enable RSpec/DescribeClass rubocop rspec cop & fix issues
...
Manually fixes all issues & "stashed" false positives at .rubocop_todo.yml
Read about the cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribeClass
2018-01-07 00:20:55 +01:00
Bertocq
b1eb6698be
Add validation expectations for shift date/task/booth/officer combinations
2017-10-04 00:13:10 +02:00
Bertocq
1975099545
Refactor & cleanup let statements on Shift model spec
2017-10-04 00:07:11 +02:00
Bertocq
b893c0bace
Add shift task presence validation expectation
2017-10-03 23:45:13 +02:00
Bertocq
690ebfba01
Check Shift destroy also destroy only associated OfficerAssigments
2017-10-03 13:24:07 +02:00
Bertocq
c624129175
Check Shift creates final/not-final OfficerAssigments correctly
2017-10-03 12:57:40 +02:00
Bertocq
e4e78c8f16
Rubocop autocorrections
2017-09-14 15:08:35 +02:00
rgarcia
47564a91a0
persist a shift's officer data
2017-09-08 20:08:45 +02:00
rgarcia
0aba196ba2
adds specs for shifts
2017-08-04 21:27:30 +02:00
