Javi Martín
fd1325768f
Check exact array contents instead of inclusion
...
We're using `eq` and `match_array` in most places, but there were a few
places where we were still checking each element is included in the
array. This is a bit dangerous, because the array could have duplicate
elements, and we wouldn't detect them with `include`.
2019-09-29 23:57:35 +02:00
Javi Martín
320b7550ed
Simplify assigning poll to a booth in specs
...
We were creating booth assignments explicitely, but we can use the
`has_many :through` relationship to make the code easier to read.
2019-09-25 12:38:37 +02:00
Javi Martín
f27beb1e47
Simplify testing array contents
...
We were testing for the size and the content of the elements when we
could test for the array itself.
2019-09-24 21:32:52 +02:00
Javi Martín
ffc50246c2
Apply explict RSpec/DescribedClass rubocop rule
...
We settled on using this style in commit 4cbe81a1
2019-09-23 16:51:00 +02:00
Javi Martín
481184e7f3
Fix accidental translations join
...
We added the code thinking we were ordering by the name of the poll, but
here we're actually ordering by the name of the booth.
2019-06-03 18:36:03 +02:00
Julian Herrero
31ac8b7f55
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
decabeza
bc1679550b
Remove incoming polls filter
2019-02-08 14:28:19 +01:00
Bertocq
34bb9d65b1
Enable RSpec/NotToNot cop and fix all issues
...
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
2018-01-07 17:39:48 +01:00
Bertocq
ed16a78f42
Enables RSpec/ExampleWording and fixes all issues
...
Both avoiding 'should' and repiting 'it' on the tests description
improves reading them and also makes all descriptions consistent.
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExampleWording
2018-01-07 01:03:45 +01:00
Bertocq
265d4d0967
Enables RSpec/DescribedClass cop & fixes all issues
...
Autocorrection for existing issues, and stashing at .rubocop_todo.yml
the false positives
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribedClass
2018-01-07 00:38:19 +01:00
Bertocq
6ec6f64675
Enable RSpec/DescribeClass rubocop rspec cop & fix issues
...
Manually fixes all issues & "stashed" false positives at .rubocop_todo.yml
Read about the cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/DescribeClass
2018-01-07 00:20:55 +01:00
Bertocq
e4e78c8f16
Rubocop autocorrections
2017-09-14 15:08:35 +02:00
rgarcia
4d1f61a87e
adds specs
2017-09-08 22:00:50 +02:00
Juanjo Bazán
89979e549f
adds search to Booth model
2016-12-23 19:06:55 +01:00
rgarcia
63ccac963a
adds booth backend for index, show, create and edit actions
2016-11-14 13:57:16 +01:00
