Javi Martín
f535d81877
Simplify creating videos for a poll in specs
2019-09-30 14:10:46 +02:00
Javi Martín
dcc9a6b561
Use symbols instead of constants for behaviours
...
This way we can be more flexible about the factory we can pass as
parameter.
2019-09-29 22:31:13 +02:00
Javi Martín
7b0771106e
Remove isolated useless assignments
...
These variables are not surrounded by other assignments, and so they can
safely be removed without making it harder to read the code vertically.
2019-09-25 12:43:44 +02:00
Javi Martín
12cdbf6196
Simplify assigning officer to a poll in specs
...
While it could be argued we're hiding the real way we've defined
associations in our models, the tests are so much easier to read when we
don't have so many lines just creating data.
Furthermore, developers who care about vertically aligning the code will
be glad to see some variables disrupting this alignment are now gone.
2019-09-25 12:38:37 +02:00
Javi Martín
086e960d09
Add trait to simplify image creation in specs
2019-09-24 21:34:06 +02:00
Javi Martín
4edab79910
Use yes_no trait to simplify creating answers
...
We lose some variety in our answers, though, but on the plus side, we
reduce the risk of trademark issues :P.
2019-09-24 21:34:06 +02:00
Javi Martín
e1c09769a8
Remove unnecessary data in polls spec
...
This data was added in commit 62088bc6
2019-09-24 19:55:37 +02:00
Javi Martín
ef0330f671
Remove duplicate test
...
One test was testing regular users can't access results, and another one
was testing neither regular users nor managers can. So the second test
can just test the admin scenario, and we're still covering everything.
2019-09-24 19:50:18 +02:00
Javi Martín
adf59cc963
Move related tests together
2019-09-24 19:50:18 +02:00
lalo
dcbd2cb379
Fix broken tests
2019-06-12 19:44:14 +02:00
Javi Martín
307cf24846
Use describe on feature tests
...
The `type: :feature` is automatically detected by RSpec because these
tests are inside the `spec/features` folder. Using `feature` re-adds a
`type: :feature` to these files, which will result in a conflict when we
upgrade to Rails 5.1's system tests.
Because of this change, we also need to change `background` to `before`
or else these tests will fail.
2019-05-28 16:36:54 +02:00
Javi Martín
45a3d8daf0
Add option to enable advanced stats
2019-05-22 11:50:03 +02:00
Javi Martín
5ca528d2ce
Extract method to link to a poll
2019-05-21 17:30:46 +02:00
Javi Martín
e461c8d0ac
Generate navigation links for polls without a slug
2019-05-21 13:04:26 +02:00
María Checa
e3b16230e6
Added slug to polls for named urls
2019-05-16 23:40:50 +02:00
decabeza
eda6ea7f12
Merge branch 'master' into dashboard
2019-03-26 16:45:48 +01:00
Senén Rodero Rodríguez
c73aae9663
Remove before validation callback
...
This was breaking nested poll_questions_answers when submitting
more than one new answer at a time.
2019-03-21 14:51:17 +01:00
Julian Herrero
884274c4ad
Add a description for open polls
2019-02-18 13:34:07 +01:00
Julian Herrero
31ac8b7f55
Change single quotes to double quotes
2019-02-15 11:40:39 +01:00
decabeza
bc1679550b
Remove incoming polls filter
2019-02-08 14:28:19 +01:00
decabeza
62088bc635
Hide poll results and stats to admins
2019-01-24 14:33:41 +01:00
Alberto Garcia Cabeza
54fbae6339
adds links to login or verification on question answers
2018-12-05 14:31:58 +01:00
decabeza
546105d989
Merge branch 'master' into dashboard-master
2018-10-19 01:48:37 +02:00
Juan Salvador Pérez García
488e7e081f
Merge branch 'dashboard' into rebase_consul_master
2018-09-27 09:18:27 +02:00
Javi Martín
b787e33883
Use the same system to freeze time in all specs
...
This required changing the `voted_before_sign_in` slightly in order to
change what the method returns if the user signed in and voted at the
exact same microsecond.
It doesn't affect production code because it would be impossible for the
user to do both things at the same time.
As a side effect, the method now returns what the method name suggests.
Before this change, the correct method name would have been
`voted_before_or_at_the_same_time_of_sign_in`.
As a less desirable side effect, in the tests now we need to make sure
at least one second passes between the moment a user votes and the
moment a user signs in again. One microsecond wouldn't work because
the method `travel_to` automatically sets microseconds to zero in order
to avoid rounding issues.
2018-09-19 14:11:50 +02:00
decabeza
bc5741fb16
Adds status icons on polls poll group
2018-08-23 18:46:14 +02:00
Juan Salvador Pérez García
50f73abb0c
Fixes #voodoorai2000 comments
...
Fixes some comments from #voodoorai2000 for the PR to consul
2018-07-27 16:30:03 +02:00
iagirre
ccc8d9e8ea
Stub the Date and Time classes so that the test doesn't depend on the time it is run.
2018-07-13 11:59:59 +02:00
decabeza
3f7395fa19
Adds message on polls index if there are no open polls
2018-04-27 18:24:17 +02:00
Bertocq
34bb9d65b1
Enable RSpec/NotToNot cop and fix all issues
...
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
2018-01-07 17:39:48 +01:00
rgarcia
2b52d26d82
refactors notifications into concerns and shared examples
2017-12-14 16:15:30 +01:00
rgarcia
21c7ff15fe
fixes routes for poll's results and stats
2017-10-23 21:39:59 +02:00
decabeza
aa7dbaa9c4
replace eq200 to text content on specs
2017-10-23 20:13:11 +02:00
decabeza
e11957a91c
adds specs for poll title link
2017-10-23 19:56:39 +02:00
María Checa
f7dce94a45
Added tests for Poll results and stats views
2017-10-23 15:50:53 +02:00
iagirre
f7bb3ec8b7
Merge remote-tracking branch 'consul/master' into iagirre-poll-stats
2017-10-18 09:48:02 +02:00
iagirre
73365ad9d2
Added spects to check de stats model and view
2017-10-18 09:34:17 +02:00
BertoCQ
a476019c49
Merge pull request #2020 from consul/poll-videos
...
Poll answer videos
2017-10-16 20:03:34 +02:00
rgarcia
c2dcad79b3
adds video spec
2017-10-16 17:14:40 +02:00
decabeza
279adaa00d
starts with polls show answers with video specs
2017-10-16 13:14:44 +02:00
Bertocq
34c278db74
Small fixes for Poll Question Answer ordering
2017-10-11 12:05:20 +02:00
iagirre
943c1f23af
Spects added to test the order of answers. Default order for question_answers set.
2017-10-10 16:38:55 +02:00
Raimond Garcia
e9276037f9
Merge pull request #2009 from consul/votable_by_fix
...
Fixed already-answered logic
2017-10-07 18:21:05 +02:00
María Checa
8b2f6d454c
Show poll answers in poll show view after voting on a booth
...
If the user votes in a booth, it can see the poll and answers but can't see what he/she voted and the answers are inactive (no link, inactive ui style).
2017-10-07 17:33:27 +02:00
María Checa
b19953b38f
Added tests
2017-10-07 17:06:53 +02:00
Bertocq
a487159e39
Add scenario for user that voted on booth can't vote on website
2017-10-07 00:53:21 +02:00
Bertocq
cb15428742
Add scenario for re-voting after sing out the same answer
2017-10-06 19:57:31 +02:00
María Checa
305b5dcf07
Fixed test
2017-10-06 14:45:44 +02:00
BertoCQ
1e22108431
Merge pull request #1980 from wairbut-m2c/iagirre-polls-show
...
Specs added for branch polls-show in consul and thumbnail for poll im…
2017-10-05 00:52:08 +02:00
rgarcia
007bcb7ec7
fixes specs
2017-10-04 17:46:25 +02:00
