Javi Martín
f9ed186909
Add rubocop spacing rules
...
We were following these rules in most places; we just didn't define them
anywhere.
2019-09-10 21:04:56 +02:00
rgarcia
f23fd6f3bb
Remove parameterise deprecation warning
...
DEPRECATION WARNING: Passing the separator argument as a positional
parameter is deprecated and will soon be removed. Use `separator: '_'`
instead.
2019-04-17 17:40:55 +02:00
Javi Martín
2b4e1cf358
Add missing double quotes
...
We overlooked a few single quotes while we changed thousands of them.
2019-03-25 13:22:35 +01:00
Julian Herrero
b460c024f3
Use double quotes in app/helpers
2019-03-15 09:26:49 +01:00
rgarcia
88cde6d018
Deal gracefully with hidden followable in my activity
...
We were seeing an exception when a user was following a proposal and
that proposal becomes hidden
With this commit we are skipping this proposals and hopefully fixing
this exception
We are also adjusting the count of followed proposals, without
including hidden proposals. It might be cleaner, to remove a `Follow`
when its `Followable` becomes hidden. But then we should probably
activate the `Follow` again if the `Followable` becomes non-hidden…
For now this commit should suffice 😌
2018-07-10 17:50:51 +02:00
decabeza
d273ba2ba5
improves following page, shows public interest only in this view
2017-12-07 13:40:12 +01:00
Bertocq
7d406cae76
Rubocop autocorrections
2017-07-25 13:01:03 +02:00
Senén Rodero Rodríguez
b7bce2e699
Remove complex methods from follow model. Create instance method followed_by? on followable model concern. Some code improvements.
2017-07-19 21:50:37 +02:00
Senén Rodero Rodríguez
119a6b3397
Remove where clause from followable button partial and rename followable_button partial to follow_button.
2017-07-19 17:51:51 +02:00
Senén Rodero Rodríguez
c9a6630c94
Remove popup on follow buttons and remove uneeded code.
2017-07-19 17:51:45 +02:00
Senén Rodero Rodríguez
cba497b32e
Create new followables helper to have some methods previously on follows helper. Rename entity to followable.
2017-07-19 17:50:46 +02:00