consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
20,144 Commits 1 Branch 0 Tags
a6d470ded657ff18d11d25b901b63facbfae6eb1
Commit Graph

9884 Commits

Author SHA1 Message Date
Javi Martín
ed51c5dcd3 Add basic SDG Management content section 
Note using `params[:relatable_type].classify` is recognized as a
security risk by some tools. However, it's a false positive, since we've
added constraints to the URL so that paramenter can only have the values
we trust.
 2020-12-21 18:04:48 +01:00
Javi Martín
5590ecaaa6 Extract methods to generate SDG management menu 2020-12-21 18:04:48 +01:00
taitus
9ac6511d96 Render interface translation by default on SDGManagement 2020-12-21 17:08:39 +01:00
taitus
6d5333fc7a Add generic method for header 
Unify Header to be able to use it from the admin as from the seg_management.
 2020-12-16 13:16:48 +01:00
taitus
dfec661a52 Use human_attribute_name 
We use this method whenever possible
 2020-12-16 13:16:48 +01:00
taitus
9521d87d03 Remove unneeded for_render 
for_render does is including organizations and there is no need to
 render organizations on these controllers
 2020-12-16 13:16:48 +01:00
taitus
6a46f68fa6 Improve styles on shared admin login items 2020-12-16 13:16:48 +01:00
taitus
d64518d173 Add sdg manager section to admin profile section 2020-12-16 13:16:48 +01:00
taitus
9fe24aec9d Add sdg manager section to admin 
Allow a user to become an sdg manager
 2020-12-16 13:16:45 +01:00
taitus
fb5965fe63 Add cancancan to SDG content 
Only allow access to the SDG content section to administrators and sdg managers
 2020-12-16 11:43:17 +01:00
taitus
65d6282b51 Allow sdg_manager access to sdg management section 2020-12-16 11:43:17 +01:00
taitus
cd7185f317 Create sdg manager 2020-12-16 11:43:15 +01:00
Javi Martín
599332f26e Merge pull request #4271 from consul/sdg_local_targets 
Add SDG local targets
 2020-12-16 11:35:12 +01:00
Javi Martín
41dba842a6 Cache I18nContent translations 
This way we avoid fetching each translation every time it's requested.
This reduces the amount of queries in the development logs and also
makes the test suite faster.
 2020-12-15 11:57:09 +01:00
Senén Rodero Rodríguez
5fa7503374 Include local_targets controller 2020-12-11 16:10:37 +01:00
Senén Rodero Rodríguez
8f7809ddb4 Allow to destroy SDG local targets 2020-12-11 16:10:37 +01:00
Senén Rodero Rodríguez
a211937744 Add SDG page to update local targets 2020-12-11 16:10:37 +01:00
Senén Rodero Rodríguez
eb0f13018c Add actions column to SDG local targets index 2020-12-11 16:10:37 +01:00
Senén Rodero Rodríguez
5611f58909 Add SDG page to create local targets 2020-12-11 16:10:37 +01:00
Senén Rodero Rodríguez
3364423698 Update SDG header component 
* Add a header element as component markup wrapper
* Allow component to receive an optional block
* Add reusable styles for header links

Co-autored-by: Javi Martín <javim@elretirao.net>
 2020-12-11 16:09:43 +01:00
Senén Rodero Rodríguez
88bcf527d8 Add local_targets index to the administration 2020-12-11 16:09:42 +01:00
Senén Rodero Rodríguez
2ad66409e2 Add SDG LocalTarget model 2020-12-08 11:30:46 +01:00
Javi Martín
0c482ae418 Fix active class for proposals in admin menu 2020-12-07 19:28:12 +01:00
Javi Martín
1046ec5e78 Move link methods from view to component 
This way the view is not as hard to read as it was.
 2020-12-07 15:28:56 +01:00
Javi Martín
7680bfc94b Use aria-current to mark the current element 
This way screen reader users will be notified that the element is the
current one.

I'm not entirely sure whether `aria-current="page"` is more appropriate
than `aria-current="true"`, since it's a general helper which can be
used for any collection of links.
 2020-12-07 15:28:56 +01:00
Javi Martín
55d2cfe5b1 Use link list helper in admin menus 
For now we're not including lists with nested lists.
 2020-12-07 15:28:56 +01:00
Javi Martín
c156621a4c Add method to generate a list of links 
A list of links is a very common pattern in the web, and we use it in
many places. Here we're applying it to one of the most simple ones; the
help page.

Generally speaking, I'm not a big fan of helpers, but there are methods
which IMHO qualify as helpers when:

* They do not deal with application objects but mainly strings and
  arrays
* They return text or an HTML tag
* Their logic is simple and splitting it into several methods is not
  necessary

Many Rails helpers, like `tag`, follow these principles.
 2020-12-07 15:28:56 +01:00
Javi Martín
190ced4d2a Remove unused views 2020-12-07 15:28:56 +01:00
Javi Martín
f9de601841 Fix double <nav> tag in valuation menu 
We were defining a <nav> tag which was already defined in the admin
layout.
 2020-12-07 15:28:56 +01:00
Javi Martín
cf510043a4 Search on the same URL by default 2020-12-07 14:28:36 +01:00
Javi Martín
e33794e45e Reuse admin search component in other sections 
There are some sections where we are not reusing it:

* The budget investments search is completely different, so this
  component isn't appropriate there
* Booth assignment and officers are slightly different, and I'm not
  entirely sure it's safe to refactor these cases
 2020-12-04 19:57:05 +01:00
Javi Martín
a9427f5971 Allow custom options in search form component 
So we keep the same API as the form_tag method.
 2020-12-04 19:57:05 +01:00
Javi Martín
9b073599f0 Allow different labels in admin search component 2020-12-04 19:57:05 +01:00
Javi Martín
0a3acf3c5f Use a shared translation for search buttons 
We were writing the same text over and over for the same translations.
Since they all serve the same function, it's perfectly fine for them to
have the same text, and so we can have a shared translation.
 2020-12-04 19:57:05 +01:00
Javi Martín
49c22b880c Use CSS to style the search component 
We simplify the view, and so make it easier to customize.
 2020-12-04 19:57:05 +01:00
Javi Martín
b453ed6c14 Add ARIA role and ARIA label to admin search form 
This way screen reader users will have an easier access to it.
 2020-12-04 19:57:05 +01:00
Javi Martín
155da08cf0 Use a generic name for the search parameter 
This way we can use it for any model.
 2020-12-04 19:57:05 +01:00
Javi Martín
9a24a8efe2 Use form_tag in search form 
This form does not depend on an object at all, so we can use a generic
tag which is model-independent.
 2020-12-04 19:57:05 +01:00
Javi Martín
2cf49b28de Extract users search view to a component 
We're going to make this search component more generic, but for now,
we're keeping the exact same behavior we had.
 2020-12-04 19:57:05 +01:00
taitus
7b6294199c Include the searched term in the search input form 2020-12-04 19:57:05 +01:00
Javi Martín
c0edd1b227 Allow SDGs to get all their related contents 
Note we cannot directly get all related contents through SQL because
related contents are spread through different tables.
 2020-12-04 18:27:49 +01:00
Javi Martín
42699275a1 Add relations between relatable models and SDGs 
Note we cannot directly get all related SDGs through SQL because they're
spread through different tables.
 2020-12-04 18:27:49 +01:00
Javi Martín
1740e0ba66 Add SDG::Relation model 2020-12-04 18:27:49 +01:00
Senén Rodero Rodríguez
e9d52b5e11 Add subnavigation component to targets and goals 
Add a new SDG component to make easier to create subnavigation menus.

Co-Authored-By: Javi Martín <35156+javierm@users.noreply.github.com>
 2020-12-04 15:15:32 +01:00
Senén Rodero Rodríguez
7fb3f1920e Add targets index to the administration 
Co-authored-by: Javi Martín <javim@elretirao.net>
 2020-12-04 15:15:32 +01:00
Senén Rodero Rodríguez
c39c7213c7 Add SDG target model 
and its relation with the SDG goal model.

Add comparable module be able to sort collections of targets
by code attribute.

Co-Authored-By: Javi Martín <35156+javierm@users.noreply.github.com>
 2020-12-04 15:15:32 +01:00
taitus
cb63185837 Render SDG content sidebar when sdg feature setting is enabled 2020-12-03 18:26:00 +01:00
taitus
72e64bd543 Render 'how to enable' when the related feature setting is disabled 
Add 'how to enable' information on SDG configuration tab when related
sdg feature setting is disabled.
 2020-12-03 18:26:00 +01:00
taitus
676adfcb3f Add new SDG feature Setting 2020-12-03 18:26:00 +01:00
taitus
0abc82d520 Add new sdg settings on sdg-tab 2020-12-03 18:00:10 +01:00