consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,628 Commits 1 Branch 0 Tags
a15e372f7ea48c35d13013380076cbb423ebff98
Commit Graph

2643 Commits

Author SHA1 Message Date
Bertocq
e38e74169e Improve valuation comments spec to avoid public leaks 
Check that on both comment creation and comment reply the public facing
investment page doesn't show them
 2018-01-31 16:27:07 +01:00
Angel Perez
47c9b343ee Admins can search investments by title or ID (#2401) 2018-01-31 09:52:55 -04:00
Raimond Garcia
45d07fa16f Merge pull request #2407 from wairbut-m2c/aperez-investment-filters-aggregation 
Investments can be applied several filters at once
 2018-01-31 14:39:02 +01:00
BertoCQ
05a6406189 Merge branch 'master' into remove_investments_internal_comments 2018-01-31 13:47:15 +01:00
BertoCQ
ec81f399bf Merge pull request #2403 from consul/valuation_comments 
Valuation comments
 2018-01-31 13:46:22 +01:00
Angel Perez
137aa7e779 Add spec to test aggregation when filtering investments 2018-01-31 07:21:51 -04:00
Alberto García
0d64f51b78 Merge pull request #2405 from consul/more-info-pages 
Improve texts of help page
 2018-01-31 11:09:12 +01:00
BertoCQ
4020720b32 Merge pull request #2370 from consul/improve_budget_heading_style 
Improve budget heading style
 2018-01-31 02:35:51 +01:00
BertoCQ
f0f41b0403 Merge pull request #2373 from consul/single_heading_group_names 
Improve heading names at select boxes
 2018-01-31 02:35:11 +01:00
Bertocq
a4718f6555 Add Budget Investment valuation comments feature spec 2018-01-31 02:04:17 +01:00
Bertocq
26cf91c61a Create valuation comments creation ability 
Why:

Only admins or valuators (for those investments they've assigned) can
create internal valuation comments on them.

How:

* Creating a new `comment_valuation` ability for admins and valuators in
the same manner the `valuate` ability works.

* Adding a validation at Comment model for those with `valuation` flag
active that checks if the author can make a valuation comment on the
commentable, as well as the respective active record error messages.
This will prevent comments from being created at a controller level as
well.

* Improving comment factory trait `valuation` to have an associated
investment, author that is a valuator and setting the valuator on the
valuators list of the investment
 2018-01-31 02:03:03 +01:00
Bertocq
149c81371b Allow valuation internal comments to be created 
How:

Using a local variable at partials to set a hidden true/false value for
`valuation` parameter on the comment creation form.

Allowing that new param at the comment controller and using it when
building a new Comment.
 2018-01-31 02:03:02 +01:00
Bertocq
56fc5c9583 Filter internal valuation comments from public api 
Why:

Internal valuation comments are only for admins and valuators,
not for the public view.

How:

Adding a `not_valuations` scope and use it at the `public_for_api` one
 2018-01-30 19:22:27 +01:00
decabeza
42d0f471ee Updates i18n keys and images folder 2018-01-30 19:10:48 +01:00
decabeza
286371c9d9 Changes more_info folder and path to help 2018-01-30 18:26:30 +01:00
Bertocq
345d513342 Remove unnecesary feature flag setting at spec 2018-01-30 12:13:01 +01:00
Bertocq
b3e7f8a78f Remove no longer neccesary feature flags from valuation feature spec 2018-01-30 12:10:15 +01:00
Bertocq
093b191f16 Small rubocop autocorrections 2018-01-30 03:07:52 +01:00
Bertocq
04d5a83031 Improve Budget's index feature spec scenarios 2018-01-30 03:01:44 +01:00
BertoCQ
dab1562132 Merge pull request #2369 from consul/fix_finished_budgets_list 
Correctly show finished budgets at budget index
 2018-01-30 02:25:06 +01:00
Bertocq
d280c254c8 Remove usage of Investment's internal_comments attr 2018-01-29 21:15:28 +01:00
Raimond Garcia
b5cb5e2563 Merge pull request #2387 from wairbut-m2c/show_only_current_budget_tags_in_admin_budget 
Show only current budget tags in admin budget
 2018-01-29 20:14:10 +01:00
Vicente Mendoza
45a86d0db8 Added test to verify that the search of the tags is only from the current budget 2018-01-26 11:31:14 +01:00
Angel Perez
e04dc5b8f2 Add sorting options for Admin::BudgetInvestments (#2336) 2018-01-25 08:18:04 -04:00
Angel Perez
680ca46ef1 Add search form for Admin::BudgetInvestments (#2336) 2018-01-25 08:16:32 -04:00
decabeza
12fbd50fc4 updates specs 2018-01-25 11:14:06 +01:00
Bertocq
e5cff2fb60 Make budget feature spec comply with 100 linelenght 2018-01-25 00:48:52 +01:00
Bertocq
bc3c92acb4 Remove no longer valid drafting budget scenarios 
Drafting budgets will no longer be listed under any conditions at the
budget index... not even as "current" budget.
 2018-01-25 00:48:52 +01:00
Bertocq
210032e1ce Expect finished budget be listed at budget index 
But only finished budgets should be listed here, not drafting ones,
neither current ones.
 2018-01-25 00:48:31 +01:00
Bertocq
d692ff781a Refactor Budget feature spec Index scenario 
Budget's home page has changed, no longer we'll be showing a list of
active budgets, but only one current (open) budget and a list of
finished ones.

So no need to create 3 budgets in a row, but a finished budget (because
we already have a valid budget created)
 2018-01-24 22:00:03 +01:00
Bertocq
62d7d08a10 Remove no longer valid scenarios: image&doc removal by admin 2018-01-24 21:50:13 +01:00
Bertocq
43c8506f84 Remove deprecated expecations about admin image&doc destroyal 2018-01-24 21:42:20 +01:00
Bertocq
d6a6b99624 Fix rare flaky test, expect a price not just the number 2018-01-24 15:06:40 +01:00
Bertocq
e0abb86267 Update specs for new heading options naming rules 
* Update budget heading order scenario to check new option name rules
* Update other scenarios that were expecting old heading naming convention
 2018-01-24 14:15:10 +01:00
Bertocq
2a500a14bc Make budget admin feature spec linelenght compliant 2018-01-24 01:20:29 +01:00
Bertocq
bd64c4749f Update groups & headings management feature spec 2018-01-24 01:17:38 +01:00
Raimond Garcia
c96e8d1203 Merge pull request #2357 from consul/travis-logs 
Clean up Travis logs
 2018-01-23 21:31:29 +01:00
María Checa
1c2949b60d Merge pull request #2344 from wairbut-m2c/aperez-investments-filters 
Improvements for Admin::Budget::Investment filters
 2018-01-23 20:09:54 +01:00
iagirre
4bb872bef7 Fixed errors detected in Travis 2018-01-23 15:42:01 +01:00
Raúl Fuentes
82b750de68 moved duplicated code to helper 2018-01-23 15:42:01 +01:00
iagirre
c37496601c Budget and phases specs updated (model specs) to include the new 'Information' phase 2018-01-23 15:42:01 +01:00
iagirre
846898f3ec New phase "Information" added and UI modified to not show the links. 
Specs to test the functionality added.
 2018-01-23 15:42:01 +01:00
iagirre
8f3df54453 Fixed errors detected in Travis 2018-01-23 13:33:10 +01:00
Bertocq
e59ed81528 Return 404 accesing community without communitable 
Why:

Somehow we're seeing communities without proposals at production. We
must find why and fix it, but first we need to throw a 404 at the user
instead of a 500 internal server error

How:

First catching the scenario of non-existent communitable at the
controller and raising a 404 error. Secondly preventing the author_id
access over a possibly nil object, this is a smell but it can't be
easily fixed right now... we need to correctly implement a relation
between Community and communitable and avoid the multiple occurences of
`community.from_proposal?` in the codebase that makes it impossible to
extend to a fourth communitable model.
 2018-01-23 00:22:53 +01:00
Bertocq
cc69225b7a Assert phases list order in admins budget edit form 2018-01-23 00:15:06 +01:00
Bertocq
217f62116e Correctly scape budget phase summary on phases list 2018-01-22 23:29:48 +01:00
Angel Perez
1027896617 Reenable 'winners' tab under Admin::Budget::Investment 2018-01-22 14:04:57 -04:00
Angel Perez
a79e60ecd1 Add spec for Admin::Budget::Investment 'max_per_heading' filter 2018-01-22 14:04:56 -04:00
Angel Perez
dddf026a59 Adapt Admin::Budget::Investment failing specs to new filter UI 2018-01-22 14:04:56 -04:00
María Checa
1f461b09f0 Merge pull request #2353 from consul/2339-admin_budgets_phases 
Allow admins to edit Budget phases
 2018-01-22 18:07:34 +01:00