Commit Graph

25 Commits

Author SHA1 Message Date
Javi Martín
749428d93f Replace content_tag with new tag builder syntax
One of the main advantages of this syntax is we can now omit the content
parameter when it's empty.
2020-04-27 19:26:37 +02:00
Javi Martín
ac6d50e06b Remove tracker role
The current tracking section had a few issues:

* When browsing as an admin, this section becomes useless since no
investments are shown
* Browsing investments in the admin section, you're suddenly redirected
to the tracking section, making navigation confusing
* One test related to the officing dashboard failed due to these changes
and had been commented
* Several views and controller methods were copied from other sections,
leading to duplication and making the code harder to maintain
* Tracking routes were defined for proposals and legislation processes,
but in the tracking section only investments were shown
* Probably many more things, since these issues were detected after only
an hour reviewing and testing the code

So we're removing this untested section before releasing version 1.1. We
might add it back afterwards.
2019-11-01 20:08:46 +01:00
Javi Martín
db97f9d08c Add and apply rubocop rules for empty lines
We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
2019-10-24 17:11:47 +02:00
Javi Martín
1004ac01f8 Add and apply Style/SafeNavigation rubocop rule
We were already using it most of the time, but not always.
2019-10-22 17:37:51 +02:00
German Galia
9ce524e1f3 Create tracker rol 2019-06-12 16:23:40 +02:00
decabeza
cbbe188d6a Move officing link inside header dropdown menu
Also include the condition to hide this link on officing namespace.
2019-05-17 17:48:43 +02:00
Julian Herrero
b460c024f3 Use double quotes in app/helpers 2019-03-15 09:26:49 +01:00
iagirre
90f8ad2663 Fixed some code that crashed in Travis build and added some test to check the functionality 2018-07-15 17:35:30 -04:00
iagirre
7a7ae5fa2e The admin menu is shown in the management section if the user who logged in is an admin 2018-07-15 17:32:30 -04:00
decabeza
377a1d9f01 improves following view and updates specs 2017-12-07 16:31:05 +01:00
decabeza
668745f3e1 moves officing menu outside of admin dropdown 2017-10-21 17:36:44 +02:00
decabeza
d676018a23 remove condition on current poll officer helper 2017-09-01 20:52:43 +02:00
decabeza
dd6ad5294c improves show_admin_menu helper 2017-09-01 19:01:19 +02:00
decabeza
c68923c5a8 adds helper to prevent show empty admin menu 2017-09-01 18:31:03 +02:00
decabeza
a18d86e8a7 replaces html to content_tag on users helper 2017-08-03 10:14:45 +02:00
decabeza
b2b15d1fd7 improves deleted elements on user activity 2017-08-03 10:14:45 +02:00
Senén Rodero Rodríguez
3370896ead Add empty interests list message. 2017-07-26 17:48:47 +02:00
taitus
7e2e94d709 Add following tab to user public page. 2017-07-13 20:29:34 +02:00
Juanjo Bazán
7a448b6890 adds BudgetInvestment case to users_helpers 2017-01-10 20:58:01 +01:00
Juanjo Bazán
5aa9cf9c50 changes links in 'My activity' to point to comment
(instead of to commentable)
Closes #947
2016-03-14 13:17:29 +01:00
Juanjo Bazán
a881ced801 adds user's email to activity page for admins 2015-11-12 12:04:34 +01:00
rgarcia
56e752e829 brings back extra security checks 2015-11-09 15:20:23 +01:00
rgarcia
ceb157b53b removes unused code 2015-11-09 13:46:29 +01:00
rgarcia
7259ac06e8 renames user_helper 2015-11-09 13:28:02 +01:00
Juanjo Bazán
0614629d35 adds info about deleted items on comments activity 2015-11-09 13:12:44 +01:00