Commit Graph

16 Commits

Author SHA1 Message Date
Javi Martín
7bf4e4d611 Sanitize descriptions in the views
Sanitizing descriptions before saving a record has a few drawbacks:

1. It makes the application rely on data being safe in the database. If
somehow dangerous data enters the database, the application will be
vulnerable to XSS attacks
2. It makes the code complicated
3. It isn't backwards compatible; if we decide to disallow a certain
HTML tag in the future, we'd need to sanitize existing data.

On the other hand, sanitizing the data in the view means we don't need
to triple-check dangerous HTML has already been stripped when we see the
method `auto_link_already_sanitized_html`, since now every time we use
it we sanitize the text in the same line we call this method.

We could also sanitize the data twice, both when saving to the database
and when displaying values in the view. However, doing so wouldn't make
the application safer, since we sanitize text introduced through
textarea fields but we don't sanitize text introduced through input
fields.

Finally, we could also overwrite the `description` method so it
sanitizes the text. But we're already introducing Globalize which
overwrites that method, and overwriting it again is a bit too confusing
in my humble opinion. It can also lead to hard-to-debug behaviour.
2019-10-21 21:32:02 +02:00
Javi Martín
24359f8152 Remove extra space in HTML tags 2019-09-10 20:02:15 +02:00
decabeza
be8bcf9269 Adds missing i18n on welcome recommendations 2018-06-06 17:33:15 +02:00
decabeza
0bf31bde6c Updates all active to is-active classes 2018-06-06 12:02:13 +02:00
decabeza
0ac6531612 Adds styles for homepage users view 2018-05-28 18:17:26 +02:00
decabeza
5a35189958 improves html markup for recommended carousel partial 2017-12-15 18:48:24 +01:00
Senén Rodero Rodríguez
92c774cdeb Merge with master 2017-09-28 13:36:20 +02:00
taitus
11395e0b27 Remove old code. Add whitespaces. 2017-08-01 16:48:42 +02:00
Alessandro Cuoghi
6e12f2cddf Added style buttons (All recommended debates/proposal). Added translations ES/EN. 2017-08-01 16:31:44 +02:00
taitus
c6a9ffc19c Remove recommended investments 2017-08-01 16:28:01 +02:00
taitus
b6d5be3df0 Rename dynamic display to carousel size 2017-08-01 16:28:01 +02:00
taitus
ee0a10855d Calculate carousel size. 2017-08-01 16:28:01 +02:00
Senén Rodero Rodríguez
fd9bec4d1f Remove uneeded files and rename. 2017-08-01 16:28:01 +02:00
taitus
fd8e2c1503 Allow to display images on carousel partial. 2017-08-01 16:28:01 +02:00
taitus
f8c6422b30 Testing links on carousel. Improve tests descripions 2017-08-01 16:28:01 +02:00
taitus
522c4e2cfc Regroup all carousels on 1 partial. Rename partial 2017-08-01 16:28:01 +02:00