consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,880 Commits 1 Branch 0 Tags
8fd6f8f1d63b19a7eb66f98113cd021daeea825c
Commit Graph

8880 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bertocq
307fe18c59 Enable rubocop Performance cops without issues 2018-02-10 21:17:56 +01:00
Bertocq
a419b36ff3 Enable rubocop Security cops without issues 2018-02-10 21:13:03 +01:00
Bertocq
45e4222aa5 Update rubocop_todo.yml 2018-02-10 21:08:48 +01:00
Bertocq
537e6e175d Enable rubocop Gemspec cops without issues 2018-02-10 21:03:50 +01:00
Bertocq
fc88e1ef79 Enable rubocop Bundler cops without issues 2018-02-10 21:03:38 +01:00
Bertocq
5de51b5f3c Enable rubocop Performance/Caller cop without issues 2018-02-10 20:59:20 +01:00
Bertocq
b3b28e21d0 Fix translation indentation on investments partial 2018-02-10 20:44:02 +01:00
Bertocq
9aa6d646d4 Remove usage of instance variables at specs 2018-02-10 19:34:54 +01:00
Bertocq
9abbf874f2 Enable rubocop-rspec RSpec/InstanceVariable cop 2018-02-10 19:34:30 +01:00
Bertocq
86a60a8b7c Fix space & comma typo 2018-02-10 19:15:00 +01:00
Bertocq
a46e9f756a Fix end's indentations at budget index page 2018-02-10 18:23:38 +01:00
Bertocq
9f47bce7f5 Improve budget index info page with classes 2018-02-10 18:22:45 +01:00
Bertocq
2915788487 Add budget id to finished budgets list on budget index 2018-02-10 18:20:15 +01:00
Bertocq
089ccdae7c Fix html alignments 2018-02-10 16:58:00 +01:00
Bertocq
189fa5ba50 Fixes advanced filters link position 2018-02-10 16:42:54 +01:00
Bertocq
6d9926441e Reverse investment scoped filter for budget by slug and then id 2018-02-10 16:39:27 +01:00
Bertocq
2341a2f70b Add by_budget scope to Investment and use it 2018-02-10 16:36:14 +01:00
Bertocq
bd10285431 Fix line length at budget investments helper 2018-02-10 16:30:07 +01:00
Bertocq
13314a1d95 Update unreleased section of changelog 2018-02-10 16:04:46 +01:00
Alberto Calderón Queimadelos
a4e6c4e9c6 Merge pull request #2386 from wairbut-m2c/2377_show_investment_links_only_on_balloting_or_later 
Show investment links only on phase balloting or later
 2018-02-10 16:04:00 +01:00
Raúl Fuentes
ecdbc4a3f7 added balloting to the list of phases allowed to see all the links 2018-02-10 15:27:40 +01:00
Raúl Fuentes
6871193cbc Added test to bugets/index to ensure the correcto showing of the investment links over ths changes of the buget's phase 2018-02-10 15:27:40 +01:00
Raúl Fuentes
5b16d395e7 Added logic to not show invetment links is the budget phase isn't reviewing_ballots or finished 2018-02-10 15:27:40 +01:00
Bertocq
90636daf87 Update unreleased section of changelog 2018-02-09 13:57:27 +01:00
BertoCQ
6ba8b68fe8 Merge pull request #2458 from wairbut-m2c/BP_flaky_residence_assigned_officers_error 
Fix flaky spec: Residence Assigned officers Error
 2018-02-09 13:52:39 +01:00
Bertocq
86a174fba0 Update unreleased section of changelog 2018-02-09 13:47:26 +01:00
Bertocq
0857d3be1f Update unreleased section of changelog 2018-02-09 13:47:19 +01:00
Bertocq
207069f737 Update unreleased section of changelog 2018-02-09 13:47:08 +01:00
BertoCQ
8ca61e4e3e Merge pull request #2455 from wairbut-m2c/backport_1180_flaky_commenting_legislation_questions 
Fixed flaky spec: missing comment on legislation annotation
 2018-02-09 13:44:18 +01:00
Vicente Mendoza
910d49d18c Focus the search of the button 2018-02-09 12:51:15 +01:00
Bertocq
fe071fcf38 Update unreleased section of changelog 2018-02-09 12:17:16 +01:00
BertoCQ
37f0a412d9 Merge pull request #2454 from wairbut-m2c/backport_1191_flaky_budget_investments_orders_random 
Fix flaky spec: random investments order scenario
 2018-02-09 12:11:18 +01:00
BertoCQ
2bcb9b321f Merge pull request #2452 from consul/help-text 
Help text
 2018-02-09 12:08:59 +01:00
decabeza
2154a614c2 Adds new legislation processes section on help page 2018-02-08 19:06:41 +01:00
Bertocq
31cece096b Verify manager & moderator sample users in dev_seeds 2018-02-08 18:23:29 +01:00
Raúl Fuentes
dbf4ec9716 changed test, fixed variable instead os us the let option 2018-02-08 16:36:35 +01:00
Raúl Fuentes
ebebbdf078 Added bigger pool for random seeds, now with a 9 * 10e-07 % of chance of appearing, also added test to cover edge cases (case in fact, the coincidence of the seeds it's correct) 
Conflicts:
	app/controllers/budgets/investments_controller.rb
 2018-02-08 16:33:15 +01:00
Raúl Fuentes
ae25fdfc15 fix for the flaky 2018-02-08 16:29:21 +01:00
BertoCQ
5ddcac8aab Merge pull request #2453 from wairbut-m2c/backport-1194-emails-users-wo-email-should-not-receive-emails 
Backport PR #1206 from Madrid's fork
 2018-02-08 15:37:34 +01:00
iagirre
80f97b3ca6 The flaky test has been modified completely to test the functionality described. JS has been avoided because it was one of the problems involved and it wasn't completely necessary. 2018-02-08 14:47:10 +01:00
decabeza
dac5b7c9a2 Adds missing polls button on help page 2018-02-07 19:09:30 +01:00
Bertocq
9579a751ab Improve flaky issue template 2018-02-07 02:03:17 +01:00
Bertocq
2e82442dbf Update unreleased section of changelog 2018-02-06 23:35:36 +01:00
Raimond Garcia
f5c5293321 Merge pull request #2444 from consul/specs 
Improve spec boot time and clean up logs
 2018-02-06 17:15:03 +01:00
BertoCQ
f9770d1243 Merge pull request #2445 from consul/coveralls-badge 
Expire Coveralls badge cache
 2018-02-06 14:12:55 +01:00
Bertocq
b54b27da79 Add travis failed build link to flakie spec issue template 2018-02-06 13:12:24 +01:00
rgarcia
3a182629ca Remove default profiling 
This makes tests run a tiny bit faster and cleans up the logs when
running specs locally

We can still configure rspec to run the profiler when we go into improving spec performance
 2018-02-06 12:22:34 +01:00
rgarcia
7b7a426f6a Run Coveralls only in Travis CI 
We were seeing a log message when running specs locally

```
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's 'rails' settings.
```

As Coveralls is mainly used in Travis CI, we do not need to load it in
every spec run
 2018-02-06 12:22:34 +01:00
rgarcia
6f4d23fdef Remove circular argument reference warning 
We were seeing this warning when running specs
`spec/features/admin/budgets_spec.rb:322: warning: circular argument
reference - phase_kind`

This commit should fix the warning
 2018-02-06 12:22:34 +01:00
rgarcia
a359517288 Regenerate bin stubs 
These are the new binstubs available in the our current `spring`
version, which make specs run much faster 😌
 2018-02-06 12:22:19 +01:00