nairobi

Author SHA1 Message Date

Author	SHA1	Message	Date
Bertocq	bdbb32e824	Move `newsletter` User scope outside UserSegments Why: UserSegments are not only used for Newsletters or Email downloads, but also for internal Global Notifications. We don't want to have that scope hardcoded inside UserSegments as users that have opted-out from the newsletter should still be recipients of global notifications. How: Removing the scope from the UserSegments `all_users` method that acts as base for all the other segments. Including that `newsletter` scope only on the places that is relevant: * When listing recipients for a newsletter * When downloading a listing emails that can be newsletter recipients Also updated relevant tests	2018-02-21 11:45:38 +01:00
María Checa	cb15a2e25b	Added EmailsDownload controller and routes Removed original method to return emails file from Newsletters controller and NewsletterZip class, included `rubyzip` gem that's no longer necessary.	2018-02-20 22:33:01 +01:00

Bertocq

bdbb32e824

Move newsletter User scope outside UserSegments

Why:

UserSegments are not only used for Newsletters or Email downloads, but
also for internal Global Notifications. We don't want to have that scope
hardcoded inside UserSegments as users that have opted-out from the
newsletter should still be recipients of global notifications.

How:

Removing the scope from the UserSegments `all_users` method that acts as
base for all the other segments. Including that `newsletter` scope only
on the places that is relevant:
* When listing recipients for a newsletter
* When downloading a listing emails that can be newsletter recipients

Also updated relevant tests

2018-02-21 11:45:38 +01:00

María Checa

cb15a2e25b

Added EmailsDownload controller and routes

Removed original method to return emails file from Newsletters controller and NewsletterZip class, included `rubyzip` gem that's no longer necessary.

2018-02-20 22:33:01 +01:00

2 Commits