Commit Graph

12 Commits

Author SHA1 Message Date
Javi Martín
db97f9d08c Add and apply rubocop rules for empty lines
We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
2019-10-24 17:11:47 +02:00
Javi Martín
f9ed186909 Add rubocop spacing rules
We were following these rules in most places; we just didn't define them
anywhere.
2019-09-10 21:04:56 +02:00
Javi Martín
47b2c42a1d Apply IndentationConsistency rubocop rule 2019-09-10 20:02:15 +02:00
Bertocq
2888c20489 Fix all Style/RedundantSelf rubocop issues 2017-07-05 11:55:52 +02:00
Bertocq
775da2d581 Remove all Layout/EmptyLines issues on code and file list from rubocop_todo 2017-06-28 14:12:51 +02:00
Bertocq
e6dd33bd66 Fix all Layout/SpaceAfterComma issues and remove from rubocop_todo list 2017-06-26 17:57:53 +02:00
kikito
b1534c1f56 moves html escaping to search_cache 2016-02-03 18:39:07 +01:00
kikito
986919503a refactors proposals search 2016-02-03 18:26:48 +01:00
beagleknight
f595c6ee7f Use model table name instead of hardcoding it 2016-01-19 12:44:15 +01:00
rgarcia
f63500b0c8 breaks down method into smaller ones 2015-11-18 17:57:57 +01:00
kikito
c7bf31c588 Make search cache order aware & accept values instead of column names 2015-11-18 17:57:57 +01:00
rgarcia
1de91658c7 extracts cached tsvector to concern 2015-11-18 17:57:56 +01:00