Javi Martín
747767386a
Use this instead of @ in CoffeeScript
...
We're using `this` most of the time, and it's what's used in JavaScript.
2019-09-11 03:14:17 +02:00
Javi Martín
1634cd5263
Use each instead of $.each
...
Iterating through the jQuery elements with `each` is more similar to
other iterators we use. Furthermore, we avoid declaring the `index`
variable we don't use.
2019-09-11 03:14:17 +02:00
Javi Martín
3b5d295cdc
Simplify function call
2019-09-11 03:14:17 +02:00
Javi Martín
879cc2571f
Use different names for variable and parameter
...
Using the same name means from that point the name doesn't refer to the
original parameter, which might be confusing when reading the method.
2019-09-11 03:14:17 +02:00
Javi Martín
4d7c124188
Remove unnecessary conditions
...
The code won't do anything if there are no elements, so there's no need
to check that condition.
2019-09-11 03:14:16 +02:00
Javi Martín
3120e0aa41
Use ECMAScript 5 array and string methods
...
These methods were added in 2009 and are supported by 98.5% of the
browsers, including Internet Explorer 9, 10 and 11. We were already
using them in some places.
2019-09-11 03:14:16 +02:00
Javi Martín
36a557927a
Remove unused variables
2019-09-11 01:56:27 +02:00
Javi Martín
b27855c1cf
Use double quotes in CoffeeScript files
...
As we do in the rest of the application.
Note we cannot add a rule enforcing double quotes because CoffeeScript
Lint does not have such rule.
2019-03-06 11:41:21 +01:00
Javi Martín
9e80c75032
Use string interpolation in CoffeeScript
...
We use it in Ruby, and it will make it easier to change all quotes to
double quotes in CoffeeScript files.
2019-03-06 11:41:21 +01:00
Senén Rodero Rodríguez
0a86727c6a
Move method 'recover_image_from_cache' from imageable controllers to image.
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
d98d1312ca
Add _destroy parameter to nested image
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
f8d78ec4ab
Remove new_nested action from images controller. Use cocoon gem to manage new nested fields creation on images.
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
88a7a29d27
Remove new_nested action from documents controller. Use cocoon gem to manage new nested fields creation on documents.
2017-09-26 13:57:13 +02:00
Alessandro Cuoghi
3745e76c07
Solve conflicts. Refactor documentable and imageable styles.
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
95016a1bf3
Some renaming and cleaning
2017-09-26 13:56:06 +02:00
Senén Rodero Rodríguez
966ff4dc03
User new direct uploads controllers action on imageable.
2017-09-26 13:56:06 +02:00
Senén Rodero Rodríguez
824dd26d5a
User new direct uploads controllers action on documentable. Skipped spec.
2017-09-26 13:55:51 +02:00
Senén Rodero Rodríguez
6f71da07ee
Duplicate documentable code and rename for imageable
2017-09-26 13:55:03 +02:00
