Javi Martín
8b5cca746c
Apply rubocop rules to freeze constants
...
Added by popular demand among our team members.
2019-10-26 13:21:36 +02:00
Javi Martín
42d2e5b3ad
Apply Rails/InverseOf rubocop rule
...
Not doing so has a few gotchas when working with relations, particularly
with records which are not stored in the database.
I'm excluding the related content file because it's got a very peculiar
relationship with itself: the `has_one :opposite_related_content` has no
inverse; the relation itself is its inverse. It's a false positive since
the inverse condition is true:
```
content.opposite_related_content.opposite_related_content.object_id ==
content.object_id
```
2019-10-25 19:29:12 +02:00
Javi Martín
27ed26d6f2
Remove unnecessary class names in relations
...
Just like we do in the Budget module, and in some places in the Poll and
Legislation modules, we don't need to specify the class name when the
name of the relation matches the name of a class in the same module.
2019-10-25 19:03:14 +02:00
Javi Martín
69e3e67c85
Avoid "Overwriting existing method open" warning
...
In Ruby, the Kernel class defined the `open` method, which is available
for (almost) every object. So creating a scope with the name `open`
generates a warning indicating we are overwriting the existing `open`
method.
While this warning is pretty much harmless and we could ignore it, it
generates a lot of noise in the logs. So I'm "undefining" the method
before generating the scope, so we don't get the warning all the time.
2019-10-23 18:07:50 +02:00
Javi Martín
657f8d129c
Use class methods for multi-line scopes
...
Some of our team members don't like using `do...end` for scopes, and
some other team members don't like using `{ ... }` for multi-line
blocks, so we've agreed to use class methods instead.
2019-10-05 14:34:52 +02:00
Raimond Garcia
259e05c3e0
Merge pull request #3410 from LextrendIT/report_generation
...
Report generation, download CSV
2019-06-12 11:45:59 +02:00
German Galia
9d1ca3bfd4
Report generation. Download csv
2019-06-12 10:17:31 +02:00
lalo
ef345ca87c
Collaborative legislation summary
2019-06-11 14:31:44 +02:00
lalo
46e5d6a9fa
Create Legislation::PeopleProposal model
2019-06-06 17:22:49 +02:00
Julian Herrero
8e0bbf54f6
Replace harcoded images and documents settings
2019-06-04 11:50:09 +02:00
German Galia
4f50e67ac3
Collaborative legislation summary
2019-06-03 12:34:25 +02:00
Juanjo Bazán
7ab602175a
makes models inherit from ApplicationRecord
2019-04-17 17:40:56 +02:00
Julian Herrero
3ba961a2d7
Use double quotes in models
2019-03-14 17:25:43 +01:00
decabeza
0d834744fd
Replace open to active filter on admin legislation processes index
...
Now active filter show open processes and the next ones, processes with a start date greather than current date.
2019-02-20 13:32:09 +01:00
decabeza
060a4c684f
Remove legislation processes next filter
2019-02-08 14:29:43 +01:00
Alberto
9475a0c6ee
Merge pull request #3249 from consul/custom-pages
...
Refactor processes header colors and custom pages
2019-01-30 20:05:20 +01:00
decabeza
41f9ef167d
Refactor hexadecimal color validation
2019-01-30 13:17:04 +01:00
Julian Nicolas Herrero
81b65ec821
Merge pull request #3202 from consul/sort_legislation_processes_by_start_date
...
Sort Legislation Processes by descending start date
2019-01-29 17:30:02 +01:00
Julian Herrero
33d6f6c18d
Sort Legislation Processes by descending start date
2019-01-22 18:51:22 +01:00
Manu
b462b7131e
validations were added for the process banner
2019-01-21 12:02:27 -05:00
Manu
bd4e12112d
Add image to legislation processes and banner colors
2019-01-21 12:02:27 -05:00
decabeza
73637de0d0
Adds homepage phase and tab to legislation processes show
2019-01-15 16:13:38 +01:00
decabeza
dd8e2d6311
Shows participation phases only if there is a phase enabled
2018-12-28 18:23:08 +01:00
dperez
bef404c443
add homepage for legislation processes
2018-12-15 18:04:24 +01:00
decabeza
534ef9c492
Hides process on index if draft dates match with date current
2018-12-12 18:23:17 +01:00
decabeza
df221b43a0
Fixes hound warnings on legislation processes
2018-12-12 18:23:11 +01:00
Javi Martín
a42f5fab37
Add milestones summary to legislation processes
2018-12-11 20:19:48 +01:00
Javi Martín
03dc43a500
Manage legislation process milestones
2018-12-11 20:18:53 +01:00
João Lutz
34b58a5208
Adds draft phase functionality in legislation processes
2018-11-19 22:18:50 -02:00
Javi Martín
863b326142
Validate both the model and its translations
...
This way we guarantee there will be at least one translation for a model
and we keep compatibility with the rest of the application, which
ideally isn't aware of globalize.
2018-10-22 16:30:28 +02:00
Javi Martín
2ab49a1832
Refactor globalize models code using a concern
...
I've chosen the name "Globalizable" because "Translatable" already
existed.
2018-10-22 16:28:53 +02:00
Javi Martín
5bfc7ca2e3
Update legislation process translatable fields
2018-10-22 15:46:16 +02:00
Javi Martín
3fb98b1752
Fix typos
2018-09-19 14:54:52 +02:00
Marko Lovic
d78aea1fd3
Make Legistlation Processes translatable
2018-09-19 14:54:24 +02:00
Raimond Garcia
ad37606129
Merge branch 'master' into legislation-processes-documents
2017-11-08 11:31:09 +01:00
Manuel Ortega
97fb986626
Added documentable feature to legislation processes
2017-10-18 19:50:34 +02:00
María Checa
02fa3a83b5
Custom tags for Legislation Process available
...
Custom tags for Legislation Processes, editable in the admin section.
2017-09-22 17:16:04 +02:00
María Checa
335399e571
Created Legislation Proposals model
2017-09-14 12:50:48 +02:00
María Checa
f521a9023b
Added Proposal model to Legislation
...
This new Legislation::Proposal model inherits from the original Proposal, as it will behave in a very similar way.
2017-09-13 15:43:36 +02:00
María Checa
dc9fe973f4
Added proposals phase attributes to legislation processes form
...
Also added them to the list of accepted params and completed translations.
2017-09-13 12:33:16 +02:00
Bertocq
69f4e1c683
Fix all rubocop Metrics/LineLength issues (140+)
2017-07-10 13:22:49 +02:00
Eduardo Martinez Echevarria
a599a0b91e
Set legislation processes visibility depending on publication
2017-06-30 15:08:23 +02:00
Bertocq
a147765273
Add enabled_phases_and_publications_count helper method on legislation process for views
2017-06-13 23:48:31 +02:00
Bertocq
cb7358bb97
Send to both Phase and Publication classes the enabled flag and use for enabled? helper method
2017-06-13 23:47:14 +02:00
Bertocq
990437dc40
Remove no longer used active/show/open _phase helper methods from Legislation Process, and specs
2017-06-13 22:04:36 +02:00
Bertocq
10954859c7
Add debate/allegations phases and draft/result publications helper methods to Legislation Process
2017-06-13 22:04:36 +02:00
Bertocq
e55328caf4
Rename legislation process final_version_publication phase name to more descriptive result_publication
2017-06-13 22:04:36 +02:00
Amaia Castro
7d118a0c27
Add draft versions comments count to admin views
2017-03-10 12:10:28 +01:00
Amaia Castro
28de717300
Show only active phases
2017-02-09 17:32:38 +01:00
Amaia Castro
08ab7474d0
Make process texts optional
2017-02-09 12:27:16 +01:00