Javi Martín
db97f9d08c
Add and apply rubocop rules for empty lines
...
We were very inconsistent regarding these rules.
Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.
The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.
[1] https://rubystyle.guide/#empty-lines-around-bodies
2019-10-24 17:11:47 +02:00
Juan Salvador Pérez García
a05e5c003f
Fixed failing tests
2018-07-17 17:50:46 +02:00
Angel Perez
88a5e8b1d2
Spec: Admins/users can destroy only their authored documentables/imageables ( #2375 )
2018-01-26 09:10:58 -04:00
Bertocq
62d7d08a10
Remove no longer valid scenarios: image&doc removal by admin
2018-01-24 21:50:13 +01:00
Bertocq
2d355ce938
Enable RSpec/LetSetup cop & fix issues
...
Read more about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetSetup
2018-01-07 16:23:49 +01:00
Senén Rodero Rodríguez
eef8ad1b73
Remove images single uploads
2017-09-27 10:41:48 +02:00
Senén Rodero Rodríguez
f8d78ec4ab
Remove new_nested action from images controller. Use cocoon gem to manage new nested fields creation on images.
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
baf9ce90a9
Obfuscate documentable and imageable file names.
2017-09-26 13:56:06 +02:00
Senén Rodero Rodríguez
826385f659
Extract ajax upload and destroy_upload actions from images and documents controllers and place them at new controllers to manage direct uploads
2017-09-26 13:55:28 +02:00
Senén Rodero Rodríguez
4f53865b25
Remove sleep from imageable shared feature specs. Use matchers able to wait new content to appear.
2017-09-26 13:55:03 +02:00
Senén Rodero Rodríguez
2a12b222ed
Fix some tranlations on new image page. Add missing shared specs for imageable feature.
2017-09-26 13:55:03 +02:00
Senén Rodero Rodríguez
16692c933e
Move specs from imageable shared feature spec to proposals and budget investments path.
2017-09-26 13:55:03 +02:00
Senén Rodero Rodríguez
ceabd16d57
Refactor. Create index scope inside imageable shared examples to check index action of any imageable model. Add image to proposals index.
2017-09-26 13:55:03 +02:00
Senén Rodero Rodríguez
6f71da07ee
Duplicate documentable code and rename for imageable
2017-09-26 13:55:03 +02:00
