consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
14,352 Commits 1 Branch 0 Tags
5fe56a62f16b475eed24dcb83e7ee431766a57cc
Commit Graph

14352 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Javi Martín
8118926ba7 Simplify tests creating poll voters 2019-03-19 13:29:43 +01:00
Javi Martín
4a3115607a Simplify poll stats test 
Adding the option to assign a poll to a poll recount factory meant we
didn't need to create so much data.

Also note we're removing the `create(:poll_voter, origin: "booth")`
code, since it isn't used in the stats calculations.
 2019-03-19 13:24:24 +01:00
Javi Martín
4830b563ea Create only one poll for a poll voter 
The factories were creating strange database relations:

* The voter belonged to a poll, to a booth and to an officer
* The booth belonged to a different poll
* The officer belonged to a different booth

The code uses an unusual syntax because the following code:

association :booth_assignment,
            factory: :poll_booth_assignment,
            poll: poll

Would generate the following error:

ActiveRecord::AssociationTypeMismatch: Poll(#46976420451940) expected,
got FactoryBot::Declaration::Implicit
 2019-03-19 13:19:24 +01:00
Javi Martín
b05ea2964c Simplify poll voter factory associations 2019-03-19 13:19:24 +01:00
Julian Herrero
f6489bc604 Use double quotes in app/views 2019-03-19 12:33:07 +01:00
Julian Nicolas Herrero
d83bf940be Merge pull request #3370 from consul/double_quoutes_everywhere 
Change single quotes to double quotes everywhere
 2019-03-19 12:20:16 +01:00
Julian Herrero
dbe99f058e Use double quotes in app/views/shared 2019-03-19 12:16:50 +01:00
Julian Herrero
7fe6285fe3 Use double quotes in app/views/proposals 2019-03-19 12:16:50 +01:00
Julian Herrero
129a258f19 Use double quotes in app/views/moderation 2019-03-19 12:16:50 +01:00
Julian Herrero
0e0462368b Use double quotes in app/views/management 2019-03-19 12:16:50 +01:00
Julian Herrero
2b83be1c7c Use double quotes in app/views/legislation 2019-03-19 12:16:50 +01:00
Julian Herrero
25ed245689 Use double quotes in app/views/layouts 2019-03-19 12:16:50 +01:00
Julian Herrero
b78ff808c1 Use double quotes in app/views/debates 2019-03-19 12:16:50 +01:00
Julian Herrero
c87267d34f Use double quotes in app/views/budgets 2019-03-19 12:16:50 +01:00
Julian Herrero
0bb2633c7a Use double quotes in app/views/admin 2019-03-19 12:16:50 +01:00
Julian Herrero
c32a98be10 Use double quotes in app/views/admin/site_customization 2019-03-19 12:16:50 +01:00
Julian Herrero
e63a862882 Use double quotes in app/views/admin/poll 2019-03-19 12:16:50 +01:00
Julian Herrero
7b4b4b716c Use double quotes in app/views/admin/legislation 2019-03-19 12:16:50 +01:00
Julian Herrero
5bfc9add78 Use double quotes in app/views/admin/budget 2019-03-19 12:16:50 +01:00
Julian Nicolas Herrero
4d6ddd2bb3 Merge pull request #3362 from consul/double_quotes_for_models 
Change single quotes to double quotes for models
 2019-03-19 12:14:31 +01:00
Julian Nicolas Herrero
af55366e57 Merge pull request #3360 from consul/double_quotes_for_controllers 
Change single quotes to double quotes for controllers
 2019-03-19 12:13:07 +01:00
Julian Nicolas Herrero
1c71e01646 Merge pull request #3341 from consul/improvement_for_options_display_results_polls 
Improvements about displaying results for voted polls
 2019-03-18 10:51:03 +01:00
Julian Nicolas Herrero
542c744a6a Merge pull request #3367 from consul/keep_images_uploaded_with_ckeditor 
Keep images uploaded with CKEditor when deploying
 2019-03-18 10:47:59 +01:00
Julian Herrero
6d281affa5 Use double quotes 2019-03-15 10:29:07 +01:00
Julian Herrero
002e16ce30 Use double quotes in lib/ 2019-03-15 10:29:07 +01:00
Julian Herrero
c9cdc72537 Use double quotes in config/ 2019-03-15 10:29:07 +01:00
Julian Herrero
8510624692 Use double quotes in config/routes 2019-03-15 10:29:07 +01:00
Julian Herrero
a8d8d2cdf9 Use double quotes in config/initializers 2019-03-15 10:29:03 +01:00
Julian Herrero
9f9b1ed100 Assign officer assignment when creating voter from booth 
If `officer_assigment' is not set the model cannot be validated,
because it cannot be blank.
 2019-03-15 09:58:16 +01:00
Julian Herrero
58f22915e9 Use double quotes 2019-03-15 09:57:09 +01:00
Julian Herrero
da04f6caa7 Add test for booth votes case 2019-03-15 09:55:12 +01:00
Julian Herrero
18bd2c7de8 Refactor (improve readability) 2019-03-15 09:55:12 +01:00
Julian Herrero
92979b84b5 Set correct origin for booth poll votes 2019-03-15 09:55:12 +01:00
Julian Herrero
9f21d9c64e Use double quotes in app/mailers 2019-03-15 09:27:01 +01:00
Julian Herrero
b460c024f3 Use double quotes in app/helpers 2019-03-15 09:26:49 +01:00
Julian Herrero
d9eaea4ea0 Use double quotes in app/assets 2019-03-15 09:26:00 +01:00
Julian Nicolas Herrero
6012638597 Merge pull request #3353 from consul/default_custom_pages 
[Backport] Default site customization pages
 2019-03-14 18:36:38 +01:00
Julian Herrero
1e04643576 Adjust spec after changing welcome pages 
Welcome pages no longer have classes or `span' tags.
They still have the 4 `li' tags, so we check for them.
 2019-03-14 18:35:51 +01:00
Julian Herrero
ddca825f9f Update spec after adding default pages 
The spec was assuming there was only 1 custom page created in the
DB. With this change the spec will pass no matter how many  custom
pages there are in the DB.
 2019-03-14 18:35:51 +01:00
Julian Herrero
87be6f302c Add default site customization pages 
From now on these static pages:

`/privacy'
`/conditions'
`/accesibility'
`/help/faq'
`/welcome'

have been moved to the DB and can be modified easily by any
administrator in `/admin/site_customization/pages'
 2019-03-14 18:35:51 +01:00
Julian Herrero
a0b8d076b7 Remove extra space 2019-03-14 18:34:55 +01:00
Julian Herrero
3ba961a2d7 Use double quotes in models 2019-03-14 17:25:43 +01:00
Julian Herrero
63182569f4 Keep images uploaded with CKEditor when deploying 
Images uploaded with CKEditor go to a folder that was not linked, so
every new deploy with capistrano the reference to those images was
lost.

By linking the directory the references to the images remain after a
new deploy.
 2019-03-14 15:57:26 +01:00
Alberto
f99a92a9ff Merge pull request #3366 from consul/a11y-fixes 
[Backport] Fix accessibility and HTML warnings
 2019-03-14 14:08:00 +01:00
decabeza
88cae1424e Add missing mobile social share message 2019-03-14 11:32:14 +01:00
decabeza
2d166cdeca Replace spaces to %20 on whatsapp share url 
This avoid have an invalid href with spaces.
 2019-03-14 11:31:40 +01:00
decabeza
e2e29cd9bc Replace summary to title on proposals social share message 2019-03-14 11:31:37 +01:00
decabeza
be8f2dca88 Remove unnecessary anchor link for finished budgets 2019-03-14 11:31:33 +01:00
decabeza
df68822111 Improve color contrast on leaflet map 2019-03-14 11:31:28 +01:00
decabeza
f7e327af09 Change label for search text 
Label wraps input field to prevent error on missing label (hidden by CSS).
 2019-03-14 11:31:21 +01:00