Angel Perez
4ddc869441
Mitigate recurrent flaky specs for voting comments
2018-07-13 22:42:41 +02:00
Angel Perez
92af93e8bd
Fix failing tests that simulated a click against the DOM
...
The now-deprecated `.trigger('click')` API simulated a click against
the DOM rather a click on the UI, which made our tests fragile and
wouldn't simulate actual user interaction
2018-03-27 14:47:51 -04:00
Angel Perez
26f2f2fea6
Refactor test to avoid interaction with non-visible element
2018-03-27 14:47:50 -04:00
Angel Perez
b3ce674ffc
Enable previously disabled test scenarios
2018-03-27 14:47:50 -04:00
Angel Perez
38af45d450
Replace deprecated .trigger('click') API with .click
2018-03-27 14:47:49 -04:00
Bertocq
c0986c7bfb
Fix investment creation for single budget usage
...
Budget Investment factory creates a secondary budget as a collateral
effect because it has a Heading factory that has a Group factory that
creates a Budget.
This was resulting in problems due to having two "active" Budgets created
and `current_budget` method not choosing the one that we expected
2018-03-12 23:06:32 +01:00
Raúl Fuentes
dbf4ec9716
changed test, fixed variable instead os us the let option
2018-02-08 16:36:35 +01:00
Bertocq
5420cd36bf
Disallow comment actions on valuation comments
2018-01-31 17:46:36 +01:00
Bertocq
e38e74169e
Improve valuation comments spec to avoid public leaks
...
Check that on both comment creation and comment reply the public facing
investment page doesn't show them
2018-01-31 16:27:07 +01:00
Bertocq
a4718f6555
Add Budget Investment valuation comments feature spec
2018-01-31 02:04:17 +01:00
Bertocq
149c81371b
Allow valuation internal comments to be created
...
How:
Using a local variable at partials to set a hidden true/false value for
`valuation` parameter on the comment creation form.
Allowing that new param at the comment controller and using it when
building a new Comment.
2018-01-31 02:03:02 +01:00
Bertocq
34bb9d65b1
Enable RSpec/NotToNot cop and fix all issues
...
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/NotToNot
2018-01-07 17:39:48 +01:00
Bertocq
3e5b13ae4d
Enable RSpec/LetBeforeExamples cop & fix issues
...
Read about cop at http://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/LetBeforeExamples
2018-01-07 02:28:06 +01:00
rgarcia
2b52d26d82
refactors notifications into concerns and shared examples
2017-12-14 16:15:30 +01:00
Angel Perez
2bdc2c27d7
Add email specs for Poll
2017-11-17 13:14:03 -04:00
Bertocq
ce0a7f6fad
Rubocop autocorrections
2017-10-17 22:00:00 +02:00
rgarcia
37cae41ee9
adds specs
2017-10-10 12:07:04 +02:00
Bertocq
e4e78c8f16
Rubocop autocorrections
2017-09-14 15:08:35 +02:00
BertoCQ
440c448ae4
Merge pull request #1862 from wairbut-m2c/iagirre-comments-empty-html
...
Iagirre comments empty html
2017-09-13 19:16:25 +02:00
iagirre
2621d2694b
Added test for comments
2017-09-13 16:04:45 +02:00
iagirre
1356ea217b
Erased extra empty HTML for comments without replies. Added .gitignore rules for Netbeans projects
...
Cambios para hacer commit:
modificado: .gitignore
modificado: app/assets/javascripts/comments.js.coffee
modificado: app/views/comments/_comment.html.erb
modificado: spec/features/comments/debates_spec.rb
2017-09-13 13:30:37 +02:00
taitus
748a54934c
Add missing specs on comments from topics
2017-09-06 15:01:39 +02:00
taitus
5d22558c2b
Fix specs
2017-09-05 12:54:32 +02:00
taitus
895c942a39
Add community to investments
2017-09-05 12:52:45 +02:00
taitus
4539c5fa00
Refactor and tests.
2017-09-05 12:52:14 +02:00
Bertocq
69f4e1c683
Fix all rubocop Metrics/LineLength issues (140+)
2017-07-10 13:22:49 +02:00
Bertocq
c9bc028524
Remove all unnecesary extra spacing and Layout/ExtraSpacing list from rubocop file
2017-06-28 14:12:51 +02:00
Bertocq
f6fe9cc7d2
Fix all Layout/SpaceAroundOperators rubocop issues and remove file list from rubocop_todo list
2017-06-26 18:04:20 +02:00
Raimond Garcia
6e60f5acde
Merge pull request #1680 from consul/chore/small_rubocop_cleanup
...
Chore/small rubocop cleanup
2017-06-26 17:42:10 +02:00
Bertocq
6529e37ae8
Fix all rubocop Rails/PluralizationGrammar issues and remove the file list form rubocop_todo file
2017-06-25 15:46:46 +02:00
taitus
e0d11d6b2a
Fix create comment on budget investment spec.
2017-06-25 11:06:05 +02:00
rgarcia
792b15b224
Merges annotations
2017-06-07 14:58:34 +02:00
decabeza
5e0d5fc8c3
Merge branch 'legislation-module-stable' of https://github.com/medialab-prado/consul into medialab-legislation
2017-05-22 18:43:49 +02:00
Amaia Castro
3009706b0d
Don’t allow comments on questions for unverified users and when the phase is closed
2017-02-08 18:19:10 +01:00
Juanjo Bazán
113f9b32d7
Merge branch 'master' into polls
2017-01-19 16:51:19 +01:00
Amaia Castro
53e9837db3
Change texts for legislation questions comments
2017-01-17 15:42:42 +01:00
Amaia Castro
a2a61341fe
Merge branch 'master' into legislation-module-stable
2017-01-11 22:54:41 +01:00
Juanjo Bazán
76d818dd1b
adds Budget::Investment comments specs
2017-01-10 14:31:28 +01:00
Amaia Castro
f43f13e826
Create first comment automatically from the annotation
2017-01-09 17:03:00 +01:00
Amaia Castro
b8f034d896
Legislation annotations/comments page
2017-01-09 09:29:15 +01:00
Juanjo Bazán
5ec12e4b5b
Merge branch 'master' into redux-polling
2016-12-27 18:22:06 +01:00
Amaia Castro
de5df61359
Legislation question comments spec
2016-12-23 15:40:52 +01:00
kikito
f0b8cfd4a2
Time.now -> Time.current
2016-11-23 19:19:19 +01:00
rgarcia
dd1e85d1c5
adds placeholder spec for comments
2016-11-17 22:48:12 +01:00
Alberto Garcia Cabeza
702cfe13d1
Fixes specs
2016-07-06 14:47:09 +02:00
rgarcia
18dd9c95f3
fixes specs
2016-06-16 12:06:26 +02:00
Juanjo Bazán
91199cda77
removes capybara warning messages
2016-04-25 11:44:33 +02:00
kikito
171c4dde13
forces capybara to wait after pushing a button by adding an extra expectation
2016-02-24 11:25:37 +01:00
Juanjo Bazán
f849f30e13
fixes flaky spec
2016-02-17 13:12:18 +01:00
Juanjo Bazán
3bd767e36f
collapsable comments on proposals/debates
2016-02-10 19:27:15 +01:00
