Commit Graph

9 Commits

Author SHA1 Message Date
Javi Martín
5214d89c88 Use order links to sort comments and topics
We use order links in many places in the web. However, in the comments
section and the list of community topics, we were displaying a
`<select>` element, and changing the location when users select an
option.

This has several disadvantages.

First, and most important, it's terrible for keyboard users. `<select>`
fields allow using the arrow keys to navigate through their options, and
typing a letter will select the first option starting with that letter.
This will trigger the "change" event and so users will navigate through
a new page while they were probably just checking the available options
[1]. For these reasons, WCAG Success Criterion 3.2.2 [2] states:

> Changing the setting of any user interface component does not
> automatically cause a change of context unless the user has been
> advised of the behavior before using the component.

Second, the form didn't have a submit button. This might confuse screen
reader users, who might not know how that form is supposed to be
submitted.

Finally, dropdowns have usability issues of their own [3], particularly
on mobile phones [4]

The easiest solution is to use the same links we generally use to allow
users select an order, so using them here we make the user experience
more consistent. They offer one disadvantage, though; on small screens
and certain languages, these links might take too much space and not
look that great. This issue affects pretty much every place where we use
order or filter links, so we might revisit it in the future.

Note we're moving the links to order comments after the form to add a
new comment. In my opinion, having an element such as a form to add a
new comment between the element to select the desired order of the
comments and the comments themselves is a bit confusing.

[1] https://webaim.org/techniques/forms/controls#javascript
[2] https://www.w3.org/WAI/WCAG21/Understanding/on-input.html
[3] https://www.youtube.com/watch?v=CUkMCQR4TpY
[4] https://www.lukew.com/ff/entry.asp?1950
2021-06-28 00:08:18 +02:00
decabeza
6642d47f4c fixes scss lint errors 2017-09-20 19:26:43 +02:00
Alessandro Cuoghi
69a97bb835 Added to the button create theme the property pointer-events: none. Now the button when disabled is not clickable. 2017-09-05 12:52:45 +02:00
Alessandro Cuoghi
555c47e012 Clean code. 2017-09-05 12:51:08 +02:00
Alessandro Cuoghi
1e60bc5cc2 Remove some css. Pass scss-lint 2017-09-05 12:51:08 +02:00
Alessandro Cuoghi
322ecf4fd5 Changed some translations. 2017-09-05 12:51:08 +02:00
Alessandro Cuoghi
e5fb90f954 Renaming class. Topic show: Added author_info. 2017-09-05 12:51:08 +02:00
Alessandro Cuoghi
11f6515e84 Style topic show. Fix tabs-panel. 2017-09-05 12:51:08 +02:00
Alessandro Cuoghi
b4cdca215d Added style show community. 2017-09-05 12:51:08 +02:00