Commit Graph

32 Commits

Author SHA1 Message Date
Javi Martín
10479148eb Override Foundation variables everywhere
We were loading all Foundation variables and then overriding them. This
is problematic because we were overriding variables after using them.
For instance, we had this code in `_settings.scss`:

```
$black: #0a0a0a;
$white: #fefefe;
$body-background: $white;
$body-font-color: $black;
```

That meant we were setting `$body-background` to `#fefefe`, and
`$body-font-color` to `#0a0a0a`. Even if we changed the values of
`$black` and `$white` later, `$body-background` and `$body-font-color`
were not affected by this change.

So now we're overriding `$black` and `$white` before setting
`$body-background` and `$body-font-color`. In order to keep our custom
values instead of overriding them, we're using the `!default` flag in
the `_settings.scss` file.

This way of defining variables in the `_settings.scss` file with the
`!default` flag is recommended in the documentation regarding the
settings file [1].

There's also a disadvantage to this approach. Now that we're loading the
`_consul_settings.scss` file first, we can no longer use Foundation
variables inside the `_consul_settings.scss` file unless we define them
in this file as well.

[1] https://get.foundation/sites/docs/sass.html#the-settings-file
2021-06-29 17:08:40 +02:00
decabeza
acc7cf65e3 Replace single quotes to double quotes on scss files 2019-02-11 17:42:58 +01:00
decabeza
43e2a58907 Fixes lint sccs warnings 2018-06-06 12:01:16 +02:00
decabeza
e3b92f1c0c Adds foundation assets 2018-06-06 12:00:39 +02:00
decabeza
894bda92ba moves custom setting to consul settings css 2017-10-03 13:53:57 +02:00
Alessandro Cuoghi
c913687be5 Moved below the header the recomended. Changed orbit-bullets diameter.Align text on the left. Used all width space for each container of the recomended. 2017-08-01 16:28:01 +02:00
decabeza
7d6b8e49fe moves foundation settings to consul settings scss 2017-07-24 17:13:41 +02:00
decabeza
76b7f66fb3 fixes scss lint warnings 2017-06-16 12:09:01 +02:00
Juanjo Bazán
16edbf15a2 Merge pull request #1620 from consul/medialab-legislation
Adds Collaborative Legislation
2017-06-07 18:06:15 +02:00
decabeza
4f5c163036 removes duplicated abbr border bottom 2017-06-02 16:41:35 +02:00
decabeza
5e0d5fc8c3 Merge branch 'legislation-module-stable' of https://github.com/medialab-prado/consul into medialab-legislation 2017-05-22 18:43:49 +02:00
Juanjo Bazán
113f9b32d7 Merge branch 'master' into polls 2017-01-19 16:51:19 +01:00
Amaia Castro
a2a61341fe Merge branch 'master' into legislation-module-stable 2017-01-11 22:54:41 +01:00
Alberto Garcia Cabeza
9c2857e75b changes budget color 2017-01-04 19:17:58 +01:00
Martín González
fa3d188a09 Add draft editor markup and styles 2016-12-28 18:59:12 +01:00
Juanjo Bazán
5ec12e4b5b Merge branch 'master' into redux-polling 2016-12-27 18:22:06 +01:00
Alberto Garcia Cabeza
8cbd39df69 adds styles to wrapper and new partial to filter subnav vertical 2016-12-22 18:31:26 +01:00
Alberto Garcia Cabeza
1968cc97f3 improves colours contrast 2016-12-07 13:52:19 +01:00
Alberto Garcia Cabeza
e778c49e64 removes orange blocks and improves contrast on proposals 2016-11-02 16:31:38 +01:00
Alberto Garcia Cabeza
6d9ced63a2 renames and removes unused variables 2016-10-31 13:10:15 +01:00
Alberto Garcia Cabeza
616e8abe28 Updates foundation rails gem 2016-07-13 14:22:24 +02:00
Alberto Garcia Cabeza
988f1f645a Improves proposal notification mailer and fixes settings.scss 2016-06-10 18:02:37 +02:00
Alberto Garcia Cabeza
84f9dcaa76 Adds tabs for notifications on proposal show 2016-06-06 17:26:48 +02:00
Alberto Garcia Cabeza
1103703ace Removes duplicates styles 2016-05-19 16:29:37 +02:00
Alberto Garcia Cabeza
10a2412e20 Removes unused scss 2016-05-19 16:25:10 +02:00
Alberto Garcia Cabeza
a59cb3481e Removes unused scss 2016-05-19 12:44:40 +02:00
Alberto Garcia Cabeza
49c8145e76 Cleans scss 2016-05-18 18:39:35 +02:00
Alberto Garcia Cabeza
58aa0309ac Fixes typo 2016-05-18 17:24:08 +02:00
Alberto Garcia Cabeza
e77b9cf46c Moves custom variables to settings.scss 2016-05-18 17:16:06 +02:00
Alberto Garcia Cabeza
d9cca3cbf1 Updates settings.scss 2016-05-18 16:52:17 +02:00
kikito
b2976b3b7e shows all pagination links in mobile 2016-03-08 11:23:06 +01:00
Alberto Garcia Cabeza
3752f3a53b Adds foundation 6 🎉 2016-02-26 19:33:33 +01:00