Commit Graph

13 Commits

Author SHA1 Message Date
Javi Martín
cb596a8163 Fix build status badge
As mentioned in the GitHub Actions documentation [1]

> Note: Referencing the workflow file using the file path does not work
  if the workflow has a name.

[1] https://docs.github.com/en/free-pro-team@latest/actions/managing-workflow-runs/adding-a-workflow-status-badge
2020-11-23 15:06:20 +01:00
Javi Martín
9c4d24d767 Use Knapscack Pro to run tests in parallel
Just like we used to do with Travis.

The configuration was taken from the Knapsack Pro documentation [1].

[1] https://docs.knapsackpro.com/2019/github-actions-ci-config-for-ruby-on-rails-project-with-mysql-redis-elasticsearch-how-to-run-parallel-tests
2020-11-23 14:00:36 +01:00
Javi Martín
375134ea04 Run the test suite using GitHub Actions
Using GitHub Actions has a few advantages over using Travis CI:

* More jobs can be run in parallel
* All CONSUL repositories on GitHub will be configured automatically

Besides, Travis have recently changed their policy twice. First, they
announced their site for free software projects would be shut down but
free software projects could still use their site for private projects.
And then, they limited the usage of their services for free software
projects.

Just like we used to do with Travis, we're enabling builds for pull
requests but not for pushed branches.

We're also building the master branch. Even if we never push to the
master branch directly, we're aware other CONSUL repositories do, so
we're running the tests for this case.
2020-11-23 14:00:33 +01:00
Javi Martín
6a5e5729dd Simplify pull request template 2018-12-07 13:57:32 +01:00
Arun Kumar
e4d5307c06 Add issue template 2018-07-04 02:50:16 -05:00
decabeza
24f0418ddf Updates pull resquest template 2018-06-08 15:10:21 +02:00
Bertocq
d0c7bae364 Improve Github's Pull Request Template file
The actual PR template feels more like bureaucracy than an actual guide
or checklist to help the PR author explain all important thigs that any
reviewer or changelog reader may need to understand.

We'll be moving most of the redundant things (like remembering tests are
needed, or explaning how things where implemented with a clear and
granular commit history) into a Wiki/Doc entry.

For regular contributors there is no need for reminders, we need to
improve new contributors landing with good guides and lowering the bar
for first PR's
2018-03-06 11:05:31 +01:00
Bertocq
9579a751ab Improve flaky issue template 2018-02-07 02:03:17 +01:00
Bertocq
b54b27da79 Add travis failed build link to flakie spec issue template 2018-02-06 13:12:24 +01:00
Bertocq
b39c1b5992 Recommend trying mobile viewport & screenshot on PR template 2018-02-03 18:30:14 +01:00
Bertocq
86b27b5bac Add github issue template for flaky specs 2018-02-03 14:47:54 +01:00
Bertocq
167df16567 Fix Github Pull Request template
Why:

* The template tried to specify a placeholder for the title, but instead it was used as first line in the description
* The template tried to specify a guide for each section with a `>` character to imply it was a comment, but people didn't remove it

How:

* Removing the first line specifying the title placeholder that has no use
* Changing the `>` character on each section guide for a `-` that can be easily reused for enumerations
2017-06-25 01:37:42 +02:00
Bertocq
e377314b52 Add .github/PULL_REQUEST_TEMPLATE file to be used as default template when manually creating a PR at github 2017-06-10 23:39:17 +02:00