Javi Martín
cc7e0d586b
Reduce local variables usage in CoffeeScript
...
Local variables are one of the things CoffeeScript doesn't compile to
modern JavaScript automatically: it uses `var` instead of `const` or
`let`.
Besides, using `$this = $(this)` is usually done to reference the
current object in another function where the current object is a
different one. Here we were using it with no clear purpose.
2019-09-11 03:14:17 +02:00
Javi Martín
86e704d8a4
Use strict mode in JavaScript
...
Strict mode is supported by 98% of the browsers, including Internet
Explorer 10, and it helps developers avoid common JavaScript pitfalls.
2019-09-11 03:14:17 +02:00
Javi Martín
747767386a
Use this instead of @ in CoffeeScript
...
We're using `this` most of the time, and it's what's used in JavaScript.
2019-09-11 03:14:17 +02:00
Javi Martín
1634cd5263
Use each instead of $.each
...
Iterating through the jQuery elements with `each` is more similar to
other iterators we use. Furthermore, we avoid declaring the `index`
variable we don't use.
2019-09-11 03:14:17 +02:00
Javi Martín
3b5d295cdc
Simplify function call
2019-09-11 03:14:17 +02:00
Javi Martín
879cc2571f
Use different names for variable and parameter
...
Using the same name means from that point the name doesn't refer to the
original parameter, which might be confusing when reading the method.
2019-09-11 03:14:17 +02:00
Javi Martín
3120e0aa41
Use ECMAScript 5 array and string methods
...
These methods were added in 2009 and are supported by 98.5% of the
browsers, including Internet Explorer 9, 10 and 11. We were already
using them in some places.
2019-09-11 03:14:16 +02:00
Javi Martín
36a557927a
Remove unused variables
2019-09-11 01:56:27 +02:00
Javi Martín
b27855c1cf
Use double quotes in CoffeeScript files
...
As we do in the rest of the application.
Note we cannot add a rule enforcing double quotes because CoffeeScript
Lint does not have such rule.
2019-03-06 11:41:21 +01:00
Javi Martín
9e80c75032
Use string interpolation in CoffeeScript
...
We use it in Ruby, and it will make it easier to change all quotes to
double quotes in CoffeeScript files.
2019-03-06 11:41:21 +01:00
Vicente Mendoza
410caced3e
test added for changes at documentable's view
2018-01-24 12:48:06 +01:00
Senén Rodero Rodríguez
77f63a4c44
Add _destroy parameter to nested documents
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
f8d78ec4ab
Remove new_nested action from images controller. Use cocoon gem to manage new nested fields creation on images.
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
88a7a29d27
Remove new_nested action from documents controller. Use cocoon gem to manage new nested fields creation on documents.
2017-09-26 13:57:13 +02:00
Alessandro Cuoghi
3745e76c07
Solve conflicts. Refactor documentable and imageable styles.
2017-09-26 13:57:13 +02:00
Senén Rodero Rodríguez
34a0aa25b6
Documentable js script fix
2017-09-26 13:56:06 +02:00
Senén Rodero Rodríguez
966ff4dc03
User new direct uploads controllers action on imageable.
2017-09-26 13:56:06 +02:00
Senén Rodero Rodríguez
824dd26d5a
User new direct uploads controllers action on documentable. Skipped spec.
2017-09-26 13:55:51 +02:00
Senén Rodero Rodríguez
826385f659
Extract ajax upload and destroy_upload actions from images and documents controllers and place them at new controllers to manage direct uploads
2017-09-26 13:55:28 +02:00
decabeza
b43e464292
renames js class
2017-09-20 19:27:11 +02:00
Alessandro Cuoghi
b0e4c5d66c
Hide progress bar for remove white space on init form. Added display block via js to show progrss bar. Added some margin.
2017-08-25 18:50:02 +02:00
Senén Rodero Rodríguez
796e6f9ce1
Code adaptation to work with nested documents and plain documents.
2017-08-25 18:34:55 +02:00
Senén Rodero Rodríguez
cc89907bff
Add nested documents to proposal form.
2017-08-25 18:34:52 +02:00
Senén Rodero Rodríguez
f226d2ac94
Fix edit and update actions
2017-08-25 18:34:52 +02:00
Senén Rodero Rodríguez
e9c5f77368
Accept nested attributes for documents on proposals. Adapt documentable js file to allow many input files at the same page.
2017-08-25 18:34:51 +02:00
Senén Rodero Rodríguez
e327b420ff
Ajax file upload to tmp dir. Add cached_attachment to document. Recover image from cache. Add progress bar.
2017-08-25 18:34:51 +02:00
Senén Rodero Rodríguez
9a0b34fffe
Install jquery-file-upload assets for rails.
2017-08-25 18:34:51 +02:00
