5 Commits

Author	SHA1	Message	Date
Javi Martín	91c21b0982	Remove instance variables in RSpec ... Instance variables might lead to hard-to-detect issues, since using a nonexistent instance variable will return `nil` instead of raising an error.	2019-09-30 16:43:10 +02:00
Javi Martín	cced12c3a0	Use feasibility traits to simplify code	2019-09-24 21:34:06 +02:00
Javi Martín	f9ed186909	Add rubocop spacing rules ... We were following these rules in most places; we just didn't define them anywhere.	2019-09-10 21:04:56 +02:00
Javi Martín	bd85aede99	Use describe on new feature tests ... The `type: :feature` is automatically detected by RSpec because these tests are inside the `spec/features` folder. Using `feature` re-adds a `type: :feature` to these files, which will result in a conflict when we upgrade to Rails 5.1's system tests. Because of this change, we also need to change `background` to `before` or else these tests will fail. We're also adding a rubocop rule so we dont' accidentally add these keywords again.	2019-08-07 13:53:27 +02:00
German Galia	16ffa2a259	Add change log in investment participatory budget	2019-06-12 13:06:20 +02:00